If you want a "land" unit to be able to cross oceans as well, without ever embarking, it takes a little more work in my experience; simply adding an all-terrain promotion to a land unit didn't prevent embarkation when I tried it. My own mods added a half-dozen or so units (usually anti-grav ones) that could cross oceans like this, but in the end the only way I found that worked was to start with a domain_sea (but NOT naval combat class) unit and then give it an all-terrain promotion. This had a few unfortunate side effects: since they counted as sea units, these wouldn't get bonus XP from buildings that boosted only land units, they could only be built in coastal cities, they'd be vulnerable to submarines, they'd stack with land units (but not with naval units), and so on. Some of these ended up being useful bonuses, but it's something to keep in mind if you're adding similar units to your own mods.