hidden nationality, any got it?

[Salamandre]

Is not working. Looked in promotions data, is only mentioned as boolean, never applied. I used it in my promotions mod, naval get it, still asks me to declare war. Is there any issue with this promotion, similar to "support fire" broken one?

 

[whoward69]

It works, it just doesn't do what people expect it to. It just changes the visual owner of the unit to the Barbs. You'll still need the promotion that allows you to enter enemy lands if you want to sneak about, and you'll still have to declare war if you want to ambush a unit

 

[Salamandre]

Ah my bad, then is totally worthless. I was thinking at civ4 behavior, where you can attack anyone without declaring war. So what works for then? If we can get same effect by adding "enter enemy lands", then HN is no use.

And I just tested and saw no graphical changes. Did you mean barbs flag? Didn't get it. Same civilization colors.

 

[Klisz]

And I just tested and saw no graphical changes. Did you mean barbs flag? Didn't get it. Same civilization colors.

Were you the owner of the unit?

 

[whoward69]

If you own the unit, you won't see any change. Other human/AI player units with the promotion will appear as barbs to you.

 

[Salamandre]

Ah ok, and if my navy is looking as barbs to AI, will he attack it? Without declaring war.

 

[whoward69]

I didn't dig into the code that far, as it's a half-hearted attempt at something that got ditched along the way. Easiest way to find out is to use FireTuner to set up a situation and see what the AI does - give the AI a destroyer and you a "hidden" trireme. The AI will definitely go for those odds of success!

 

[FarceSensitive]

@whoward69
could you possibly address this in your Dll. mod?

 

[whoward69]

@whoward69
could you possibly address this in your Dll. mod?

I actually started looking at this, as I wanted a unit that could ambush enemy units by appearing as Barbs and also wanted to keep acquired Barb units (actually CivBE Alien units if we ever get that source code) appearing as barbs but under player control.

The problem is that the C++ code doesn't use best practice getter/setter techniques for class data, but directly accesses the variables. Which results in several hundred (over 300 IIRC) minor changes across many files before you can even start looking at more complex logic (basically, instead of a single GetOwner() method you need a GetRealOwner() method and an alternative GetOwner(TeamTypes iAskingTeam) method. You can't use a single overloaded method, as that would confuse the Lua API, and you also need to rewrite bits of the Lua UI as well)

TL;DR; Basically the vast numbers of changes make it a maintenance/integration nightmare, and I gave up.

But then I said that once about Unified Yields ...

 

[Salamandre]

Oh, just imagine, having hidden nationality (the one from civ4) as promotion available for every unit. Maybe one day, you the boss.

 

[Dimmy]

Bump as I would love to see this feature in civ5/CPP