I was able to test it before than expected, this perfectly works!!!
Sorry if I ask your help again, I'm trying to fix the expansionist attribute n.5. I basically fixed it, except that now it doesn't work on new towns
The reason these are happening per age and per game is the age transition is actually just an advanced start on a new game, using all the info of the old game. So extra terracotta dude, a huge amount of culture from Hale o Kauwe reapplying all the culture from coastal buildings, etc.Thanks a lot to everyone!
@FungeonKeeper reported the requirement "REQ_AGE_IS_ANTIQUITY", which would fix a good part of the problem for terracotta army (still the bug would appear if the city with terracotta army changes owner during antiquity age, but this fix would be better than nothing for sure), the only questions is "why I don't find this requirement in the Excel kindly sent by @Smayo ?".I don't understand if "REQ_AGE_IS_ANTIQUITY" is something already used by the game or not.
Tonight (European time) I'll try it to see if it works.
Also, if I understood correctly, not only the +1 population expansionist attribute repeat itself every age, but also the +1 promotion for commander militarist attribute? Basically everything happening "once in the game" instead happen "once every age" I guess.... I tried to understand how to fix it but I've no idea, also because I'm definitely someone who is self-teaching how to code and I definitely miss some basic knowledge about it
In the meantime, I agree that after the patch of 22 april we could do a "brainstorming" about what should be in the mod and what not; I REALLY hope mods fix a lot of the (MANY) bugs, but I'm losing my hope a bit more everyday.
I would think someone who conquers it should get a commander, no? every other wonder gives benefits on conquering.
That requirement is used for SALES_AND_TRADE_MOD_RESOURCE_SCIENCE_SUBJECT_REQUIREMENTS_1, which is an Abbassid one that looks for at least 8 pop in a settlement.Sorry if I ask your help again, I'm trying to fix the expansionist attribute n.5. I basically fixed it, except that now it doesn't work on new towns
In order to fix it totally I think it should be enough to add the requirement "make it works if city population = 1", which I guess is related to this line of your really usefull file:
Spoiler code :
But I'm not sure how I can read it and make it a real requirement in the code. I tried the following:
Spoiler code 2 :
but it's not working, I'm pretty sure something is wrong in the bold part. Do someone know how can I fix it?
I've not found anywhere the REQUIREMENT_CITY_POPULATION used in the original code, but if it's in the file I guess it's somewhere
Thanks a lot in advance!!!!
This is honestly a terrible decision by 2K. It just reinforces my belief that they’ll never fix these issues — probably because doing so would require a completely new approach, and they’re already struggling with problems that should be easy to solve.
I'm not entirely sure what's intended, but I’m pretty confident that, in previous Civ games, wonders that granted one-time bonuses didn’t re-trigger those bonuses when the city was conquered, so I guess this should be the intended behavior (also because otherwise it could create definitely "strange" situation, because it's not so rare especially in multiplayer that a city get conquered, reconquered and then conquered again in just 3/4 turns....that's 3 more commanders in 3/4 turns for this situation).
If I find a way to say "give the bonus always, but just to towns with exactly 1 population" I guess I can fix it. Tonight I'll try again.
RequirementId vs RequirementType:This is honestly a terrible decision by 2K. It just reinforces my belief that they’ll never fix these issues — probably because doing so would require a completely new approach, and they’re already struggling with problems that should be easy to solve.
What worries me even more is that I’ve reported multiple bugs through 2K’s official support channel. Not only is the process incredibly slow and bureaucratic, but the responses suggest they barely understand basic concepts about their own game. I’m guessing they’ve left interns in charge of support — which wouldn’t be a huge issue if I wasn’t starting to suspect the interns might also be the ones developing the game.
Also, sorry if this is a dumb question — I’m completely new to this and trying to learn — but what’s the difference between RequirementType and requirementId?
I'm not entirely sure what's intended, but I’m pretty confident that, in previous Civ games, wonders that granted one-time bonuses didn’t re-trigger those bonuses when the city was conquered, so I guess this should be the intended behavior (also because otherwise it could create definitely "strange" situation, because it's not so rare especially in multiplayer that a city get conquered, reconquered and then conquered again in just 3/4 turns....that's 3 more commanders in 3/4 turns for this situation).
Anyway I've already """partially""" fixed the problem; now that attribute works perfectly when taken and at the age transition (in this last case, it doesn't give bonus); the "just little problem" is that now it's not giving any bonus to new towns
Anyway I've already """partially""" fixed the problem; now that attribute works perfectly when taken and at the age transition (in this last case, it doesn't give bonus); the "just little problem" is that now it's not giving any bonus to new towns
Totally agree with this, the bug report process is 10,000 feet level above the actual bugs we are taking about. When you submit they ask you to verify game files integrity, check installation etc issues. It is more geared towards “can’t play the game” level of issues vs these nuanced bugs we’re talking about. The people reading these don’t know about the game; like you said they’re just admins passing tickets.
Lol same esperience, they closed one of my ticket "because I opened two ticket with same issue" while they obviously were COMPLETELY different topic (not even similar subjects). I told them they were wrong and they reopened both of them, but it's embarassing if they do this each time someone open two different ticket. Their inefficiency is ridiculous...
Actually thanks to the beatiful file of @Smayo I had another idea and now it works!!!
I've fixed also the free commander promotion!!!
This bug I reported has been fixed exactly like above, all the others bug I reported/ fixed unluckily are the same in the new patch
huh. Does that do anything except just visually show a different string?
cool. Well I'll make a update on Extended. Also managed to fix Hale o Kauwe and Erdene Zuu regranting culture for the buildings/Cav you made last age.This bug I reported has been fixed exactly like above, all the others bug I reported/ fixed unluckily are the same in the new patch
resources-gameeffects.xml shows ivory for the modifier.
<Modifier id="MOD_IVORY_DESERT_WONDER_PRODUCTION" collection="COLLECTION_ALL_CITIES" effect="EFFECT_CITY_ADJUST_BIOME_WONDER_PRODUCTION_PER_RESOURCE">
<Argument name="Empire">true</Argument>
<Argument name="BiomeType">BIOME_DESERT</Argument>
<Argument name="ResourceType">RESOURCE_IVORY</Argument>
<Argument name="Amount">10</Argument>
</Modifier>UPDATE ProgressionTreeNodeUnlocks SET TargetType= 'MOD_ATTRIBUTE_MILITARISTIC_09_A' WHERE TargetType='MOD_ATTRIBUTE_MILITARISTIC_09';
INSERT INTO ProgressionTreeNodeUnlocks(ProgressionTreeNodeType, TargetType, TargetKind, UnlockDepth) VALUES
('NODE_ATTRIBUTE_MILITARISTIC_09', 'MOD_ATTRIBUTE_MILITARISTIC_09_B', 'KIND_MODIFIER', 1);
INSERT INTO Modifiers (ModifierId, ModifierType, Permanent, RunOnce, SubjectRequirementSetId) VALUES
('MOD_ATTRIBUTE_MILITARISTIC_09_A', 'MOD_ATTRIBUTE_MILITARISTIC_09_TYPE', 1, 0, 'SLTH_BUGFIX_FREE_COMMANDER_PROMOTION_REQS'), -- can apply whenever, to get new commanders a promo
('MOD_ATTRIBUTE_MILITARISTIC_09_B', 'MOD_ATTRIBUTE_MILITARISTIC_09_TYPE', 0, 1, 'MOD_ATTRIBUTE_MILITARISTIC_09_SUBJECT_REQUIREMENTS'); -- applies only clicking button and transient. reuse old subject reqs
INSERT INTO ModifierStrings(Context, ModifierId, Text) VALUES ('Description', 'MOD_ATTRIBUTE_MILITARISTIC_09_A', 'LOC_MOD_ATTRIBUTE_MILITARISTIC_09_DESCRIPTION');
INSERT INTO ModifierArguments(ModifierId, Name, Value) VALUES
('MOD_ATTRIBUTE_MILITARISTIC_09_A', 'Amount', 1),
('MOD_ATTRIBUTE_MILITARISTIC_09_B', 'Amount', 1);
INSERT INTO Requirements(RequirementId, RequirementType, Inverse) VALUES
('SLTH_BUGFIX_COMMANDER_HAS_NO_PROMOTIONS_REQ', 'REQUIREMENT_COMMANDER_HAS_X_PROMOTIONS', 1);
INSERT INTO RequirementArguments(RequirementId, Name, Value) VALUES
('SLTH_BUGFIX_COMMANDER_HAS_NO_PROMOTIONS_REQ', 'Amount', 1),
('SLTH_BUGFIX_COMMANDER_HAS_NO_PROMOTIONS_REQ', 'PromotionsOnly', 'true');
-- ('SLTH_BUGFIX_COMMANDER_HAS_NO_PROMOTIONS_REQ', 'OnPromotionInterval', 0), -- undocumented if we need this
INSERT INTO RequirementSets(RequirementSetId, RequirementSetType) VALUES
('SLTH_BUGFIX_FREE_COMMANDER_PROMOTION_REQS', 'REQUIREMENTSET_TEST_ALL');
INSERT INTO RequirementSetRequirements(RequirementSetId, RequirementId) VALUES
('SLTH_BUGFIX_FREE_COMMANDER_PROMOTION_REQS', 'MOD_ATTRIBUTE_MILITARISTIC_09_SUBJECT_REQUIREMENTS_1'), -- reused, checks for commander tag
-- ('SLTH_BUGFIX_FREE_COMMANDER_PROMOTION_REQS', 'SLTH_BUGFIX_NOT_TURN_ONE_REQ'), -- new commanders dont get any promo if this is attached.
('SLTH_BUGFIX_FREE_COMMANDER_PROMOTION_REQS', 'SLTH_BUGFIX_COMMANDER_HAS_NO_PROMOTIONS_REQ');Wait but did you test it? Is it not working? With me it was working, I test both in game and during age transition. Tomorrow I'll check better eventually!
I'll try it again soon also, maybe copypasting something went missing!!
