Culture from Killing trait integration

[TheManFromMars]

Hello there,

I can't for the life of me for some reason work out what the code is I'm meant to enter to get the Aztecs 'CultureFromKills' trait into a new civ. Preferably with a lower 25, instead of 50 point value.

I would have thought it'd be something like:

<TraitsType>TRAIT_WHATEVER_IT_IS</TraitType>
<YieldType>CULTURE_FROM_KILLS</YieldType>
<Yield>25</Yield>

Or just

<TraitType>TRAIT_WHATEVER_IT_IS</TraitType>
<CultureFromKills>25</CultureFromKills>

I know there is other code around it in the XML, this is just part of a 'two part' trait really, the first part is working fine, it is just this part that is the problem.

I look at the Table layouts and the only template so to speak that makes sense is the yields threshold, but i can't seem to get it working, anyone know or could just jott down the code here?

Thanks in advance

 

[Iceco]

Currently the CIV5Traits.XML has this:

<Table name="Traits">
<Column name="CultureFromKills" type="integer" default="0" />
</Table>

and

<Traits>
<Row>
<Type>TRAIT_CULTURE_FROM_KILLS</Type>
<Description>TXT_KEY_TRAIT_CULTURE_FROM_KILLS</Description>
<ShortDescription>TXT_KEY_TRAIT_CULTURE_FROM_KILLS_SHORT</ShortDescription>
<CultureFromKills>50</CultureFromKills>
</Row>
</Traits>

So you have to make a variation on the second object.
Pretty much this:

<?xml version="1.0" encoding="utf-8" ?> 
<GameData>
  <Traits>
    <Row>
      <Type>TRAIT_CULTURE_FROM_KILLS_VARIATION</Type> 
      <Description>TXT_KEY_TRAIT_CULTURE_FROM_KILLS_VARIATION</Description> 
      <ShortDescription>TXT_KEY_TRAIT_CULTURE_FROM_KILLS_SHORT_VARIATION</ShortDescription> 
      <CultureFromKills>25</CultureFromKills> 
    </Row>
  </Traits>
</GameData>

 

[TheManFromMars]

Hi,
That didn't seem to work, this is what I currently have, if anyone could take a look and see what is wrong --> neither trait entity works at all, which is odd, because one is pretty much just copied across. There are no crashes, it loads fine, all text is referenced fine - it is reading the change, is fine with it, but no implementation.

Spoiler :

<?xml version="1.0" encoding="utf-8"?>
<!-- Created by ModBuddy on 10/28/2010 11:41:05 AM -->
<GameData>
<Traits>
<Row>
<Type>TRAIT_ART_OF_SADISM</Type>
<Description>TXT_KEY_TRAIT_ART_OF_SADISM</Description>
<ShortDescription>TXT_KEY_TRAIT_ART_OF_SADISM_SHORT</ShortDescription>
<CultureFromKills>25</CultureFromKills>
</Row>
</Traits>
<Trait_FreePromotionUnitCombats>
<Row>
<TraitType>TRAIT_ART_OF_SADISM</TraitType>
<UnitCombatType>UNITCOMBAT_RANGED</UnitCombatType>
<PromotionType>PROMOTION_LOGISTICS</PromotionType>
</Row>
</Trait_FreePromotionUnitCombats>
</GameData>

Thanks for any help in advance.

 

[LoneGamer]

That looks ok. How many units did you kill when testing this out? you might be getting a decimal and it may not show up just yet in the tab.

 

[Iceco]

You put a space in "TXT_KEY_TRAIT_ART_OF_SADISM_SHORT" just before the last T.

That's all I can see for now.

 

[TheManFromMars]

Well the description seems fine, so not sure the space makes a difference, but I'll correct it anyway. I only killed a couple of units, I'm not sure what '50' or '25' even means. I can't help but think it surely isn't actual points, but not sure how much I have to kill for it to show up, it isn't clear.At the very least the logistics promotion is not being given to ranged units... I'll test it, but it's just struck me that that might not be a category, I might need to tediously put something like _ARCHER and _CROSSBOW _SIEGE etc, I'll have a look if _RANGED is even a category.

But any other comments are still welcome. Cheers

 

[LoneGamer]

You are right, there is no _RANGED. You should get Windows Grep. It really helps me with my .xml searches. Replace the _RANGED with _ARCHER

 

[TheManFromMars]

Thankyou very much all of you for your help.
My assumption was right in the end, the ranged needed to be archer, and all worked fine, including the culture from kills - I didn't realise it was a percentage value, so didn't notice until I started to accumulate enough culture to notice the jump.

Anyways good stuff, it all works!