Ah yes you are right it does say 25% in the editor. I had looked all over for that value and only used a different value as I couldn't find the value set in the editor. And yes this is with version 1.21 (I can't do the unit placements otherwise). I will have to run some more tests and look at this some more. It is possible that terrain bonuses add up differently when a river is in place (possibly for flat lands dropping the 10%, but will have to run more trials).
And yes I do realize that these are non integer values, I had even posted in a previous thread a few months ago asking why people though the game was rounding to integer values. I have excel to the calculations and it keeps the numbers of course as doubles.
I know that more trials is important and that the other guy did not really grasp statistics. Of course he did have a point on how rapidly the randomness converges to the expected. Since we are dealing with a finite number of units in a game, we expect convergance of the probabilities for that average number of combat rounds in a game.
I am also working under the assumption that the random number generator is working correctly. Another poster a while back hacked the game and ran calls on the random number generator and than used the DIEHARD suite of tests on the results. His conclusions were that the generator was performing fine.
Consequently, when my data remained consistant from one set of experimental runs to the next I took that as indication that I was seeing convergance. Now ideally someone could hack into the game and find a way to generate calls to the combat function saying tank attacking spearman across river in a jungle and repeate that a few thousand times. Unfortunately this is the best that I can do. However, this data is more hard than the ancedotal evidence used that the combat system/RNG is buggy or that there are AI cheats. In fact given the above result there would appear to be an anti-ai cheat
The river bonus only made a minor differance in a spearman match up. So that could very well be the cause of my error, had not thought about that. However, if it hadn't been for the two different matchups showing the same error, I would not have changed the value of the river bonus in my spreadsheet. Well will run more of those tests, and it should converge more correctly.