[R&F] Regaining the old Jerusalem Suzerain Bonus

[xsr]

[ Rise and Fall made it that your cities with holy sites act like holy cities, but Jerusalem no longer converts and acts as a holy city itself. ]

Hello and thank you for any help in advance. I have no modding background (read a bit but still poor understanding). I tried to take out all lines related to Jerusalem in Expansion1_Leaders.xml (result: no suzerain bonus), or tried to "shift" the lines from the base game's Leaders.xml to Expansion1_Leaders.xml (result: crash to main menu).

Base game's Leaders.xml
<!--Unlike other Suzerain bonuses, Jerusalem's bonus emerges from modifiers applied to itself rather than modifiers applied to another player-->
<Row TraitType="MINOR_CIV_JERUSALEM_TRAIT" ModifierId="MINOR_CIV_JERUSALEM_RELIGION_BONUS"/>
<Row TraitType="MINOR_CIV_JERUSALEM_TRAIT" ModifierId="MINOR_CIV_JERUSALEM_HOLY_CITY_BONUS"/>

Expansion1_Leaders.xml
<ModifierId>MINOR_CIV_JERUSALEM_UNIQUE_INFLUENCE_BONUS</ModifierId>
<ModifierType>MODIFIER_ALL_PLAYERS_ATTACH_MODIFIER</ModifierType>
<SubjectRequirementSetId>PLAYER_IS_SUZERAIN</SubjectRequirementSetId>
<ModifierId>MINOR_CIV_JERUSALEM_HOLY_SITE_UPGRADE</ModifierId>
<ModifierType>MODIFIER_PLAYER_TREAT_HOLY_SITES_AS_HOLY_CITIES</ModifierType>

 

[xsr]

Under My Games/.../Logs/Database.log (when I tried to replace the lines under <TraitModifiers>, <Modifiers> and <ModifierArguments> witth the old lines from the base game, and it couldn't load)

[3268914.519] [FullTextSearch]: FTS - Creating Context
[3268932.122] [Gameplay] ERROR: UNIQUE constraint failed: Modifiers.ModifierId
[3268932.122] [Gameplay]: While executing - 'insert into Modifiers('ModifierId', 'ModifierType') values (?, ?);'
[3268932.122] [Gameplay]: In XMLSerializer while inserting row into table insert into Modifiers('ModifierId', 'ModifierType') with values (MINOR_CIV_JERUSALEM_RELIGION_BONUS, MODIFIER_PLAYER_ADOPT_ALLY_FOUNDED_RELIGIONS, ).
[3268932.122] [Gameplay]: In XMLSerializer while updating table Modifiers from file Expansion1_Leaders.xml.
[3268932.122] [Gameplay] ERROR: UNIQUE constraint failed: Modifiers.ModifierId
[3268932.245] [Gameplay] ERROR: FOREIGN KEY constraint failed
[3268932.245] [Gameplay] ERROR: FOREIGN KEY constraint failed

 

[thecrazyscot]

You need to remove the following lines from the following files to maintain the old Suzerain Bonus in R&F:

In Expansion1_RemoveData, delete this line:

<Delete Type="MINOR_CIV_JERUSALEM_TRAIT"/>

In Expansion1_Leaders, delete these lines:

<Row Type="MINOR_CIV_JERUSALEM_TRAIT" Kind="KIND_TRAIT"/>

<Row LeaderType="LEADER_MINOR_CIV_JERUSALEM" TraitType="MINOR_CIV_JERUSALEM_TRAIT"/>

<Row TraitType="MINOR_CIV_JERUSALEM_TRAIT" Name="LOC_LEADER_TRAIT_JERUSALEM_NAME_EXPANSION" Description="LOC_LEADER_TRAIT_JERUSALEM_DESCRIPTION_EXPANSION"/>

<Row TraitType="MINOR_CIV_JERUSALEM_TRAIT" ModifierId="MINOR_CIV_JERUSALEM_UNIQUE_INFLUENCE_BONUS"/>

The issue you're running into is that Firaxis first deleted all references to the old trait before putting the new one in, so you need to reverse their deletion and then remove the code inserting the new ability.

 

[xsr]

Yay; I understand, and should have checked through the various file names. [ Even non-modder me can guess that there might be a deleting of the old trait done somewhere. ]

Thank you for your time

[ edit: Will only take effect upon new games ]