Simple question: "If Unit Domain = Land"

[Cybah]

on combat result:

if gc.getDomainInfo(unitX.getDomainType()).getType() == gc.getInfoTypeForString("DOMAIN_LAND") and gc.getDomainInfo(unitY.getDomainType()).getType() == gc.getInfoTypeForString("DOMAIN_LAND"):

this does not work (no error). where is the mistake?



edit: must look like this right?

if gc.getUnitInfo(pWinner.getUnitType()).getDomainType() == gc.getInfoTypeForString("DOMAIN_LAND") and gc.getUnitInfo(pLoser.getUnitType()).getDomainType() == gc.getInfoTypeForString("DOMAIN_LAND"):

edit2: better should be then...

if unitX.getDomainType() == gc.getInfoTypeForString("DOMAIN_LAND") and unitY.getDomainType() == gc.getInfoTypeForString("DOMAIN_LAND"):

 

[Afforess]

Try:

DomainTypes.DOMAIN_LAND

 

[Thomas SG]

Have you added your new tag to GlobalDefines and created a new dll with the changes in CvXMLLoadUtilitySet?

 

[Cybah]

It's no new tag.

 

[Thomas SG]

It's no new tag.

gc.getInfoTypeForString("DOMAIN_LAND")

Where is this string defined?

 

[Afforess]

gc.getInfoTypeForString("DOMAIN_LAND")

Where is this string defined?

It isn't. There is no Global Define value for DomainTypes, DomainTypes are enumerated in the SDK. Cybah was simply confused, you use DomainTypes.DOMAIN_LAND in python.

 

[Thomas SG]

Damn. Python. Oh, I hate it. I'm going crazy...

 

[Cybah]

in Civ4UnitInfos.xml

			<Class>UNITCLASS_LION</Class>
			<Type>UNIT_LION</Type>
(...)
			<Domain>DOMAIN_LAND</Domain>

 

[Cybah]

Oh, I was too late.

 

[God-Emperor]

I think somebody never noticed CIV4DomainInfos.xml and, as Cybah pointed out, all those entires in the unit data. When loading the unit data it does this:

	pXML->GetChildXmlValByName(szTextVal, "Domain");
	m_iDomainType = pXML->FindInInfoClass(szTextVal);

so the various domains had better be in there to be looked up.

The Python gc.getInfoTypeForString("DOMAIN_LAND") ought to work - it's used from time to time including in Rhye's and Fall of Civilization as shipped with BtS and in FfH2 (both of which also use DomainTypes.DOMAIN_LAND).

Using the predefined DomainTypes.DOMAIN_LAND ought to be considerably faster.