Sneak Promotion duplication

[Dancing Hoskuld]

Currently we have two bits of python which are the same except one is for the Sneak promotion and the other is for the Sneak1 promotion. Both these promotions are defined but only one is used by any units. The Sneak1 promotion is used. Sneek1 is defined in core whereas Sneak is defined in The_J's modules.

Almost the same thing can be said for the Marauder promotion, the python is the same but both promotions are used in the units file.

Is this duplication? Can we get rid of a bit of python and very slightly speed up the game?

 

[strategyonly]

De4finitely, that stuff was mine, sorry, i dont know python, so i left it alone, and didnt bother with it, but as lo9ng as one does what the others does no biggy, as long as WE get the Spartacus unit working again, Correctly.

I also want to get something done about spawning individual units at certain times, is that possible??

 

[Dancing Hoskuld]

Well the python is the same but are the promotion definitions? If they are I reckon we should get rid of the ones ending 1. Note that the text definitions of the promotions also occur in a couple of places so they would need to be tidied up also.

 

[strategyonly]

Well the python is the same but are the promotion definitions? If they are I reckon we should get rid of the ones ending 1. Note that the text definitions of the promotions also occur in a couple of places so they would need to be tidied up also.

OK, i will see what i can do, on a side NOTE:

I just ran a unit artdefines missing script and i found this: (see pic 1)

MissingArt: art/LeaderHeads/Suppiluliuma/kublai_khan.nif

MissingArt: art/LeaderHeads/Suppiluliuma/kublai_khan.kfm

MissingArt: art/LeaderHeads/Menelik/mansa_musa.nif

MissingArt: art/LeaderHeads/Menelik/mansa_musa.kfm

Question is, should i keep it like the LEFT side in pic 1 or just leave it as is in RIGHT side??

@ Hydro:

I cant find this either??
MissingArt: Modules/Hydro/Goods/Art/goodpoultry.dds (found it BUT)

EDIT: I think i know why its having a HARD time finding things, because you have it in the above, whereas, it should be Assets/Modules/Hydro/Goods/Art/goodpoultry.dds

The first one is correct IF you left it IN the modules area, but its not. )2nd pic)

DH should this be changed or is it ok the way it is for modules??

 

[Dancing Hoskuld]

OK, i will see what i can do, on a side NOTE:

I just ran a unit artdefines missing script and i found this: (see pic 1)

MissingArt: art/LeaderHeads/Suppiluliuma/kublai_khan.nif

MissingArt: art/LeaderHeads/Suppiluliuma/kublai_khan.kfm

MissingArt: art/LeaderHeads/Menelik/mansa_musa.nif

MissingArt: art/LeaderHeads/Menelik/mansa_musa.kfm

Question is, should i keep it like the LEFT side in pic 1 or just leave it as is in RIGHT side??

Since you are using static leader heads I would have thought the side with <KMF/> was right.

@ Hydro:

I cant find this either??
MissingArt: Modules/Hydro/Goods/Art/goodpoultry.dds (found it BUT)

EDIT: I think i know why its having a HARD time finding things, because you have it in the above, whereas, it should be Assets/Modules/Hydro/Goods/Art/goodpoultry.dds

The first one is correct IF you left it IN the modules area, but its not. )2nd pic)

DH should this be changed or is it ok the way it is for modules??

This is the reason you should have your art files in your modules have the same structure as the core art files and just use Art/... in the art define. That way when you move the art into core you don't have to change your XML. There is a small load time cost to not having them defined as Modules/Hydro/Goods/Art. (I am assuming that the XML is in Modules/Hydro/Goods)

 

[Hydromancerx]

@strategyonly

Well I have all the "goods" icon/buttons in my Hydro.FPK under the Goods folder. If I recall Poultry started out as a building (aka goods) and then to a building produced resource and then finally a map resource.

 

[strategyonly]

Well the python is the same but are the promotion definitions? If they are I reckon we should get rid of the ones ending 1. Note that the text definitions of the promotions also occur in a couple of places so they would need to be tidied up also.

Hopefully i got them correct in latest SVN.

 

[Dancing Hoskuld]

Spartacus is spawned by an event not built nor python. I don't understand events so I can't comment on it.

 

[strategyonly]

Spartacus is spawned by an event not built nor python. I don't understand events so I can't comment on it.

OK no problem, i just wanted to make sure the python was ok is all, thx anyways, i think i will try something new then.