Some assistance with Civilization Traits in Lua

LeeS · Jul 11, 2016

Go to this website : http://www.lua.org/cgi-bin/demo

enter this code

Code:

local bThisThing = true
print(tostring(bThisThing == 1))

press the 'run' and see the result

Spoiler :

unless you put '1' in for the value of 'bThisThing' you get false.
boolean values do not evaluate for equality against integer values as anything except false

Harkodos · Jul 12, 2016

Well, since I pretty much just changed one thing from what was essentially a copy/paste, I have no idea what any of that means.

Spoiler :

Anyways, that aside, I think what you're telling me is that maybe IsDenouncedPlayer is a boolean term? Which makes sense. But since I have no real IsDenouncedPlayer code to reference (aside from something overly complicated), I can't make this stuff click in my head.

Harkodos · Jul 12, 2016

I'm currently programming in a Civ that requires its units to receive a promotion while said civilization has no cities in its empire. I was able to get most of everything working except a few things:

1. When the Civilization has a city I set their unique Palace replacement to remove said unique promotion (PROMOTION_INDOMITABLE_WILL), but that didn't work, so then I set the Palace to give them the PROMOTION_SUBSIDED_WILL which negates the ability of the first promotion (which works). The Problem is that when the city is lost, they should then lose the second promotion, since there is no longer a need for said promotion when they have no cities.

2. The unique Palace gives a unique building in the Capital that gives the player +2 Happiness. If the Capital is captured, the unique building is set to 100 ConquestProb so that they will receive the "normal" version, which should reduce the effectiveness of their defensive buildings by 25%, but it does not seem to want to keep said building when the Capital is captured.

For problem 1, if I cannot do what I desire with a building, is it possible to give a Civilization's units a promotion when they have no cities?

And for problem 2, which probably doesn't require lua, how would I fix the unique building so that it stays in the city upon capture by the enemy?

I've attached the code below for reference.

Harkodos · Jul 18, 2016

I'm currently working on a Civilization trait where the Civ will receive a Combat Bonus against captured cities. To achieve this, I modified the code found in OTiger's Mario Land civilization so that I could achieve this.

However, I'm not quite sure if I've been able to program what I wanted with it. I made a few changes, listed below, but I just want to have someone go over it to make sure that it works correctly.

And just to be clear I want this:
"Military Units receive a combat bonus against captured cities" (This includes cities captured from Major Civilizations, not just City States like in OTiger's original code).

Code:

local iRequiredCiv = GameInfoTypes.CIVILIZATION_AMERICA
local iPromoExtraStrength = GameInfoTypes.PROMOTION_INDOMITABLE_WILL

function GetPlayersAtWarWith(iOurTeamID)
	local tPlayersAtWarWith = {}
	for iTeam = 0, GameDefines.MAX_CIV_TEAMS - 1 do
		if iTeam ~= iOurTeamID then
			local pTheirTeam = Teams[iTeam]
			if not pTheirTeam:IsBarbarian() and not pTheirTeam:IsMinorCiv() and pTheirTeam:IsAlive() then
				if Teams[iOurTeamID]:IsAtWar(iTeam) then
					for PlayerID = 0, GameDefines.MAX_MAJOR_CIVS - 1, 1 do
						local pPlayer = Players[PlayerID]
						if (pPlayer ~= nil) then
							if (pPlayer:GetTeam() == iTeam) and pPlayer:IsAlive() then
								tPlayersAtWarWith[PlayerID] = PlayerID
							end
						end
					end
				end
			end
		end
	end
	return tPlayersAtWarWith
end
function GetConqueredCities(tPlayersAtWarWith)
	local ConqueredCities = "NONE"
	for k,v in pairs(tPlayersAtWarWith) do
		for pCity in Players[v]:Cities() do
			if Players[pCity:GetOriginalOwner()]:IsMinorCiv() or not Players[pCity:GetOriginalOwner()]:IsMinorCiv() then
				if ConqueredCities == "NONE" then
					ConqueredCities = {}
				end
				table.insert(ConqueredCities, pCity)
			end
		end
	end
	return ConqueredCities
end
function ExtraStrengthCityLiberate(iPlayer)
	local pPlayer = Players[iPlayer]
	if pPlayer:GetCivilizationType() == iRequiredCiv then
		local iOurTeamID = pPlayer:GetTeam()
		local bIsAtWar = (Teams[iOurTeamID]:GetAtWarCount(true) > 0)
		for pUnit in pPlayer:Units() do
			if pUnit:IsCombatUnit() then
				local bUnitShouldHavePromotion = false
				if bIsAtWar then
					local tPlayersAtWarWith = GetPlayersAtWarWith(iOurTeamID)
					local tCitiesToBeLiberated = GetConqueredCities(tPlayersAtWarWith)
					if tCitiesToBeLiberated ~= "NONE" then
						local pUnitPlot = pUnit:GetPlot()
						local iTileOwnerID = pUnitPlot:GetOwner()
						if tPlayersAtWarWith[iTileOwnerID] then
							for pCity in Players[iTileOwnerID]:Cities() do
								local bCityIsInConqueredList = false
								for k,v in pairs(tCitiesToBeLiberated) do
									if pCity == v then
										bCityIsInConqueredList = true
										break
									end
								end
								if bCityIsInConqueredList and (Map.PlotDistance(pUnitPlot:GetX(), pUnitPlot:GetY(), pCity:GetX(), pCity:GetY()) <= 3) then
									bUnitShouldHavePromotion = true
								end
							end
						end
					end
				end
				pUnit:SetHasPromotion(iPromoExtraStrength, bUnitShouldHavePromotion)
			end
		end
	end
end
GameEvents.PlayerDoTurn.Add(ExtraStrengthCityLiberate)

Harkodos · Jul 20, 2016

Perhaps I should rephrase what I want from the previous post:

I want to know if the code, as-is, will work in the intended way with the way I have programmed it and not cause some unforeseen hiccups down the line like: "This code will work in circumstances X and Y, but not Z."

Does that make sense?

So, will the code, as-is, allow the Civilization's Military Units to receive a Combat Bonus against captured cities without other unforeseen hiccups?

qqqbbb · Jul 20, 2016

The code above does not make much sense. To give units combat bonus vs certain cities you have to use combat events from VMC.

Harkodos · Jul 20, 2016

VMC?

Well, it's pretty much just a code I've edited slightly from a mod by OTiger, that LeeS made.

Really, this line is the most I changed from it in function GetConqueredCities:

Code:

if Players[pCity:GetOriginalOwner()]:IsMinorCiv() [COLOR="Blue"]or not Players[pCity:GetOriginalOwner()]:IsMinorCiv()[/COLOR] then

From what I've observed, it does work, but the unit has to begin its turn right next to said City in order to gain said combat bonus.

qqqbbb · Jul 20, 2016

Harkodos said:
VMC?

Various mod components dll.

Harkodos said:
the unit has to begin its turn right next to said City in order to gain said combat bonus.

Exactly.

Harkodos · Jul 20, 2016

Hmmm. I'm trying to make sure my mods don't require any modded .dlls, because they might conflict with one another, or add extra workload for the CPU. I want as little inter-dependencies as possible.

Harkodos · Aug 1, 2016

Alright, with the completion of Phase 1 for my Custom Civilizations, I've decided to go through each of my civs one last time before starting Phase 2 with what I call: Phase 1.5. Essentially, I want to know under what circumstances with would be okay to keep a Civilization's custom Dummybuildings due to the circumstance that LeeS brought to my attention where having Civilizations on Teams or having more than one of the same Civilization in the game can cause irregularities with Dummybuildings.

So, I'm going to list every Civilization I've made that uses Dummybuildings and lump each one into what type of circumstance the Dummybuilding was used for, and I just want to know if leaving the Dummybuilding and the associated XML or Lua code is fine, or if I will have to replace it with something else.

Circumstance #1: for The Monarch's Butterfly Empire and The Mystics:

Spoiler :

Circumstance #2: for Clan Bravo:

Spoiler :

Circumstance #3: for Duckburg, Nowhere, Spargus, and The Legion of Beavers:

Spoiler :

Circumstance #4: for Haven City, Peach Creek, Petoria, Spargus, Sudanya, The Air Nomads, The Barnyard Burglars, The City of Townsville, The Digital World, The Imaginary Friends, The Land of Discord, The Legion of Beavers, The Mistlands, The Mystics, The Riptocs, The Shinra Electric Power Company, The Simpsons, The Twin Baronies, The Ultimecian Empire, The Valley of Peace, The World of Darkness, The Zanarkand Abes, and Venture Industries:

Spoiler :

Circumstance #5: for Hueco Mundo:

Spoiler :

Circumstance #6: for South Park, The Land of Discord, The Monarch's Butterfly Empire, and Jack's Kingdom:

Spoiler :

Circumstance #7: for Springfield, Mewni, and Mystery Twins Incorporated:

Spoiler :

Circumstance #8: for The Aku Empire and The Pollutors:

Spoiler :

Circumstance #9: for The Chroniclers, The Hamato Clan, The Simpsons, and The Valley of Peace:

Spoiler :

Klisz was nice enough to provide a modified code from his Radiant Garden civilization, so I'm fairly certain this one should work, but again, just want confirmation. Anyways, this code provides a number of Dummybuildings in a City based upon how many Great Works it currently possesses. Code by Klisz for The Chroniclers here:

Code:

local iCivilization = GameInfoTypes.CIVILIZATION_AMERICA
local iDummyBuilding = GameInfoTypes.BUILDING_AMERICA_DUMMYBUILDING

local iMaxCivs = GameDefines.MAX_MAJOR_CIVS
local iMaxPlayers = GameDefines.MAX_CIV_PLAYERS
local bPopup;
local tGreatWorkBuildings = {};
for pBuilding in GameInfo.Buildings() do
	if pBuilding.GreatWorkCount > 0 then
		local pBuildingClass = GameInfo.BuildingClasses("Type = '" ..pBuilding.BuildingClass.. "'")()
		tGreatWorkBuildings[pBuildingClass.ID] = pBuildingClass.Type
	end
end

function UpdateDummyBuildings(iPlayer)
	local pPlayer = Players[iPlayer]
	if pPlayer:GetCivilizationType() ~= iCivilization then return end
	if pPlayer:IsEverAlive() and not pPlayer:IsMinorCiv() then
		for pCity in pPlayer:Cities() do
			local iBuildingsToAdd = 0
			for iBuildingClass, pBuildingClass in pairs(tGreatWorkBuildings) do
				local iCurrentWorks = pCity:GetNumGreatWorksInBuilding(iBuildingClass)
				print("In the " .. pBuildingClass .. " in " .. pCity:GetName() .. " there are " .. iCurrentWorks .. " Great Works")
				if iCurrentWorks > 0 then
					for i = 0, iCurrentWorks - 1, 1 do
						local iWorkType = pCity:GetBuildingGreatWork(iBuildingClass, i)
						print("Found a Great Work!")
						iBuildingsToAdd = iBuildingsToAdd + 1;
					end
				end
			end
			print("Adding " .. iBuildingsToAdd .. " buildings to " .. pCity:GetName())
			pCity:SetNumRealBuilding(iDummyBuilding, iBuildingsToAdd);
		end
	end
end

function UpdateDummyBuildingsUI()
	if bPopup then
		UpdateDummyBuildings(Game:GetActivePlayer())
	end
end

GameEvents.PlayerDoTurn.Add(UpdateDummyBuildings)
Events.SerialEventCityInfoDirty.Add(UpdateDummyBuildingsUI)

function SetCurrentPopup(popupInfo)
	local popupType = popupInfo.Type
	if popupType == ButtonPopupTypes.BUTTONPOPUP_CULTURE_OVERVIEW then
		bPopup = true
	end
end
Events.SerialEventGameMessagePopup.Add(SetCurrentPopup)

function ClearCurrentPopup()
	bPopup = nil;
end
Events.SerialEventGameMessagePopupProcessed.Add(ClearCurrentPopup)

Circumstance #10: for Slugterra, The City of Nerekhall, and The Zanarkand Abes:

Spoiler :

Circumstance #11: for The Equalists and The Simpsons:

Spoiler :

Circumstance #12: for Jack's Kingdom, and The Imaginary Friends:

Spoiler :

Circumstance #13: for The World of Darkness:

Spoiler :

And that's it. So, just to reiterate: I want to know if any of these uses of Dummybuildings will come into complications when playing on Teams or with more than one of the same Civilization in-game. Most of these I'm pretty sure are fine, but I just want to double check to make sure.

Harkodos · Aug 10, 2016

Alright, so I went through each of the Mods individually to scope out what was wrong with any of the buildings/UAs, and I found a few problems that I'd like help with:

For Clan Bravo:

Spoiler :

It seems that when conquering Clan Bravo's Capital, they will lose all of their unique buildings, but will regain them once they've completed a new Policy Tree. This is pretty much true for all copies of the civ when playing with multiple copies. Basically, I need the code below to recheck for when they have a new Capital and give them the allotted copies of the appropriate Dummybuilding for how many Policy Trees they've finished; not just when they finish a new Policy Tree, but also when they have a new Capital in place (or regain their old one).

Code:

local iBuildingForCompletedPolicyBranches = GameInfoTypes.BUILDING_AMERICA_POLICY_DUMMYBUILDING
local tPolicyAndBranchCorrespondances = {}
for Policy in DB.Query("SELECT ID, Type, PolicyBranchType FROM Policies WHERE Level = '0'") do
	local iPolicyId, sPolicyType, sPolicyBranchName, iPolicyBranchID = Policy.ID, Policy.Type, Policy.PolicyBranchType, -1
	if (sPolicyBranchName ~= nil) then
		for PolicyBranch in GameInfo.PolicyBranchTypes("Type='" .. sPolicyBranchName .. "'") do
			iPolicyBranchID = PolicyBranch.ID
		end
	end
	if iPolicyBranchID ~= -1 then
		if (GameInfo.PolicyBranchTypes[iPolicyBranchID].FreePolicy ~= sPolicyType) and (GameInfo.PolicyBranchTypes[iPolicyBranchID].FreeFinishingPolicy ~= sPolicyType) then
			local bPolicyIsAPreReq = false
			for row in GameInfo.Policy_PrereqPolicies("PrereqPolicy = '" .. sPolicyType .. "'") do
				bPolicyIsAPreReq = true
				break
			end
			if not bPolicyIsAPreReq then
				tPolicyAndBranchCorrespondances[iPolicyId] = iPolicyBranchID
			end
		end
	end
end

function PolicyBranchFinished(PlayerID, policyID)
	if tPolicyAndBranchCorrespondances[policyID] then
		local pPlayer = Players[PlayerID]
		if pPlayer:IsPolicyBranchFinished(tPolicyAndBranchCorrespondances[policyID]) then
			local pCapitalCity = pPlayer:GetCapitalCity()
			if pCapitalCity ~= nil then
				print("We Should have added " .. pPlayer:GetNumPolicyBranchesFinished() .. " Dummy Buildings in the city of " .. pCapitalCity:GetName())
				pCapitalCity:SetNumRealBuilding(iBuildingForCompletedPolicyBranches, pPlayer:GetNumPolicyBranchesFinished())
			end
		end
	end
end
GameEvents.PlayerAdoptPolicy.Add(PolicyBranchFinished);

For Slugterra:

Spoiler :

For The Aku Empire and The Pollutors:

Spoiler :

For The Equalists:

Spoiler :

This one should be pretty simple. Almost all of The Equalists' UA works except for the below excerpt I borrowed from The Koopa Troop which I need to work for multiple copies of the same Civilization. Basically, this code reduces the time a City spends in Resistance when captured by The Equalists by half. Perhaps I removed something necessary when transferring it to my Mod, I don't know, but I would love help fixing it in either case.

Code:

-- ============================================================================
-- Enables debug statements
-- ============================================================================
local bDebug = false

function dprint(...)
  if (bDebug) then
    print(string.format(...))
  end
end

-- ============================================================================
-- AmonConquerCheck
-- ============================================================================
--We have a couple of things to check when a city is conquered...
function AmonConquerCheck(iPlayer, isCapital, cityX, cityY, iNewPlayer)

	-- Get the city that was specified by the coordinates
	local pCity = Map.GetPlot(cityX, cityY):GetPlotCity()
	
	-- Check if this is an Equalist city
	local pPlayer = Players[iPlayer];
	local pNewPlayer = Players[iNewPlayer];
	if (pNewPlayer:GetCivilizationType() == GameInfo.Civilizations.CIVILIZATION_AMERICA.ID) then
		dprint("Amon has conquered " .. pCity:GetName() .. "!")
		AmonHalveResist(pCity)
	end
end

-- ============================================================================
-- AmonHalveResist
-- ============================================================================
-- Halves the resistance time of a conquered city if Amon conquered it
function AmonHalveResist(pCity)
		dprint("Halving resistance time for " .. pCity:GetName() .. " (original was " .. pCity:GetResistanceTurns() .. " turns)...");
		-- Only fixed this just before release! I suppose I should have known since the function is "ChangeResistanceTurns()" rather than "SetResistanceTurns()"...
		pCity:ChangeResistanceTurns(-pCity:GetResistanceTurns()/2);
		dprint("Resistance time for " .. pCity:GetName() .. " is now " .. pCity:GetResistanceTurns() .. " turns.");
end

For The Monarch's Butterfly Empire and The Mystics:

Spoiler :

Some assistance with Civilization Traits in Lua

LeeS

Imperator

Harkodos

Warlord

Harkodos

Warlord

Attachments

Harkodos

Warlord

Harkodos

Warlord

qqqbbb

Prince

Harkodos

Warlord

qqqbbb

Prince

Harkodos

Warlord

Harkodos

Warlord

Harkodos

Warlord

Similar threads