The question isn't what traits are better or worse, it's how you need to play each one. Only if you're stuck on a single strategy will there be absolutely "good" and "bad" traits.
1. tier
- Protective (it just sucks overall, I mean how often do u spam longbows for an attack?)
In the early game, Protective gives you superior defenders, which helps you hold out against both barbarians and AI when -- as you WILL be at higher difficulty levels -- you are on the defensive instead of on the attack. Also, including some Longbows in your SoD when you are on the attack helps protect the stack, and gives you superior city garrison. Remember, the AI always prioritizes taking back a city you've taken from them. Superior defense is just as important as superior attack.
Plus, in the Industrial Age, when your main attackers become gunpowder units, Protective boosts your attackers, too. City Garrison isn't an attack promotion, but Drill is, and it opens up other promotions that are even better. And even the City Garrison will help defend your -- city garrisons. Since you will want to hold the cities you take, unless of course you're just razing.
- imperialistic (those 50 % settlers doesnt do that much. The GG's are okay though)
The settler-build boost is an early-game advantage entirely. It helps your initial expansion. But that's a good thing. That initial start can help you throughout the game. Of course, it's not much advantage if you choose to expand through an early rush instead of with settlers, but hey -- if that's what you want to do, don't choose an Imp leader, and if you go random and get an Imp leader, don't use that strategy.
- Indostrious (I like cheap forges. but still not that good)
The best thing about Industrious is the cheap wonders, not the cheap forges, although that's OK too. The way you play an Ind leader is, of course, to spam wonders, and use the benefits of those wonders to fuel your progress and expansion.
- aggressive (well, you dont allways need war. If you fancy classical/medievel war, it's the way to go)
Aggressive, like Protective, boosts gunpowder units, not just melee units, so it's good right to the end of the game. Combat I isn't so much by itself, but it opens up a lot of other promotions that are.
Of course, if you want to play a peaceful game, this trait is worthless, but see above under Imperialistic and an early rush. If you want to play peacefully, don't go with Aggressive, and if you get an Agg leader randomly, don't play peacefully.
- spiritual (think it's a good trait, I just don't think I use it the right way)
It is a good trait, and the way to use it is of course to change civics and/or religions whenever you need do, for whatever purpose you have. Where any other leader has to minimize civic changes, a Spiritual leader can go back and forth between (say) Pacifism and Theocracy, or Slavery and Caste System, to meet whatever need arises.
- expansive (extra health + cheap granny's = big cities fast)
Yes, that's the best thing about expansive, all right.
- creative (gr8 early game not having to worry about expanding BFC)
Plus it gives you a small extra edge in the culture struggle between border cities, plus it lets you build libraries, theaters, and colosseums cheaply. The libraries are especially great, in the early game.
- financial (good when doing CE, but I'm not a big fan of total cottage spam)
Yes, it's at its best when running a CE. If you run a pure SE, don't use Financial, and if you're Financial, don't run a pure SE. But then, I don't believe in running a pure SE anyway.
- Philosophical (Gimmi more GP's! MORE MORE MORE!)
This is nice; of course, same caveat in reverse: if you're running a pure CE, don't bother with Philo, and if you're Philo, don't run a pure CE. But then, I don't believe in running a pure CE anyway.
- Charismatic (nice for warmongering AND brilliant in the beginning if u get Stonehenge!)
It does make Stonehenge a better wonder choice, but I still like the cheap promotions better, and don't forget the +1 happy face per city! I think my two favorite warmongering leaders are Churchill (Protective/Charismatic) and Boudica (Aggressive/Charismatic).
I can't really show you mine, because what I want is to learn how to play with any and all traits. My feel is that they're all about equally good, but require different strategies to leverage well.
