[1.0.1.501] Issue with COLLECTION_PLAYER_CITIES not including captured cities

[pokiehl]

For some Effects, this collection inexplicably does not apply to conquered cities when applied via Civilization or Leader trait.

So for example, a Civilization Trait that adds +2 Production to Shrines, using this ModifierType:

"MODIFIER_PLAYER_CITIES_ADJUST_BUILDING_YIELD_CHANGE"

The bonus will NOT apply to conquered cities.

EDIT: As I clarified below, the issue appears to be within the EFFECTS themselves, not the COLLECTIONS.

The bugged EFFECT types are:
EFFECT_ADJUST_BUILDING_YIELD_CHANGE
EFFECT_ADJUST_EXTRA_GREAT_WORK_SLOTS

What's weird is that the issue does not arise for say, a Policy using MODIFIER_PLAYER_CITIES_ADJUST_BUILDING_YIELD_CHANGE. So the Military Research policy, which grants +2 Science to Military Academies, works fine for conquered cities...

 

[pokiehl]

Actually, it seems like the EFFECTS themselves are bugged, not the Collection.

So another modifier that gives this issue is MODIFIER_PLAYER_CITIES_ADJUST_EXTRA_GREAT_WORK_SLOTS. I wanted a Trait that gives the Amphitheater a Music slot. However, as I stated above, this effect was not applying to captured cities.

------
To get around this, I did an experiment. I thought MODIFIER_SINGLE_CITY_ADJUST_EXTRA_GREAT_WORK_SLOTS would work.

1. I created a GameModifier with MODIFIER_ALL_CITIES_ATTACH_MODIFIER, which attached MODIFIER_SINGLE_CITY_ADJUST_EXTRA_GREAT_WORK_SLOTS.

2. I tested it on my capital. It worked.

3. I conquered a city, built an Amphitheater. It did not work.

4. Repeat process for
-------

So there must be something in certain EFFECTS themselves preventing them from applying to captured cities.

So far the two bugged Effects are:

EFFECT_ADJUST_BUILDING_YIELD_CHANGE
EFFECT_ADJUST_EXTRA_GREAT_WORK_SLOTS