adapt a script

[globosud]

In this attempt it didn't crash, but it gave me these errors
Traceback (most recent call last):
File "BugGameUtils", line 340, in callHandler
TypeError: doHolyCity() takes exactly 1 argument (0 given)
the error may depend on the fact that it is now just (arglist) while the original is (self, arglist)?

 

[f1rpo]

Ah, good that there is an error message now. (The error messages that appear on the screen also get written to PythonErr.log -- not to PythonErr2.log, that one is pretty much never useful --, so in the event of a crash to desktop there may still be something useful in the log.) Yes, we forgot to remove one self argument. Since doHolyCity takes no other arguments, it should just be def doHolyCity(): I think. So doHolyCityTech(argsList) should be fine, doHolyCity is the one that causes the error.

 

[globosud]

I took a test, this is what happens when I discover a religion
Traceback (most recent call last):
File "BugGameUtils", line 342, in callHandler
File "LimitedReligionsHandlers", line 129, in cannotTrain
File "LimitedReligions", line 355, in getReligionMissionary
AttributeError: 'NoneType' object has no attribute 'getPrereqReligion'

 

[f1rpo]

Looks like the mod assumes that every civ has access to every unit class; very much not the case in Realism Invictus.
Adding ...

			if pCivilization.getCivilizationUnits(iUnitClass) < 0:
				continue

(indented) under if gc.getUnitClassInfo(iUnitClass).getMaxPlayerInstances() > 0: should fix that.

Spoiler :

So that it says:

	for iUnitClass in range(gc.getNumUnitClassInfos()):
		if gc.getUnitClassInfo(iUnitClass).getMaxPlayerInstances() > 0:
			if pCivilization.getCivilizationUnits(iUnitClass) < 0:
				continue
		#if gc.getBuildingClassInfo(iUnitClass).getMaxPlayerInstances() > 0:
			kUnit = gc.getUnitInfo(pCivilization.getCivilizationUnits(iUnitClass))
			if kUnit.getPrereqReligion() == iReligion:

So this is probably a compatibility issue with LimitedReligions and Realism Invictus specifically, not with the BUG framework. The function getReligionMissionary is supposed to return the ID of the missionary unit for a given religion. Hopefully, there is still exactly one missionary per religion in Realism Invictus, otherwise, this task isn't really well-defined. (The error message basically says that kUnit was None, which probably happened because pCivilization.getCivilizationUnits(iUnitClass) didn't return a valid unit ID for the given unit class ID.)

 

[globosud]

I thought about it too, do you think it's possible to eliminate the whole part that refers to the missionaries? otherwise in my personal mod mod, I will insert a missionary for each religion, and then make that type of missionary unbuildable, so as to avoid that problem,

 

[globosud]

Now i have this error.:
Traceback (most recent call last):
File "BugConfig", line 110, in unknown_endtag
File "BugConfig", line 334, in endChild
File "BugConfig", line 337, in end
File "BugConfig", line 318, in process
File "BugConfig", line 525, in handle
File "BugUtil", line 642, in getFunction
File "BugUtil", line 629, in lookupFunction
File "BugUtil", line 621, in lookupModule
File "<string>", line 52, in load_module
File "LimitedReligionsHandlers", line 8, in ?
File "<string>", line 35, in load_module
File "<string>", line 13, in _get_code
IndentationError: unindent does not match any outer indentation level (LimitedReligions, line 356)

 

[f1rpo]

The kUnit= line should be at the same level as the if pCivilization. The intended structure is:

Spoiler :

for iUnitClass in range(gc.getNumUnitClassInfos()):
{
	if gc.getUnitClassInfo(iUnitClass).getMaxPlayerInstances() > 0:
	{
		if pCivilization.getCivilizationUnits(iUnitClass) < 0:
		{
			continue
		}
		kUnit = gc.getUnitInfo(pCivilization.getCivilizationUnits(iUnitClass))
		if kUnit.getPrereqReligion() == iReligion:
		{
			...

(But Python doesn't allow curly braces to convey that; has to be done through careful indentation.)

There's the OC_TRAIN_ONLY_STATE_RELIGION_MISSIONARY XML setting for disabling the missionary part of the mod. If you do want to block missionaries to the extent that they exist, you could add return None to the end of getReligionMissionary. (With a single tab for indentation.) Currently, it'll probably crash (Python error, not a crash to the desktop) when it doesn't find any missionary unit for a given religion. And cannotTrain will need code for ignoring the None case:

if LimitedReligions.getReligionMissionary(iOwner, iReligionLoop) is None:
	continue

After if iReligionLoop != iStateReligion: and indented one tab farther than that line.

 

[globosud]

so do you think it could work?
nb:

missionaries are not a problem since they exist for all religions

 

[f1rpo]

The #if... doesn't matter because the line is commented out, i.e. ignored by the Python interpreter. But the next line needs another tab. After a line that ends with a colon (and isn't commented out), the next line (that isn't a comment) always needs to be indented one level more. The "continue" seems to be indented with one more tab than necessary, but that shouldn't be a problem.

 

[globosud]

it crashed, maybe I did something wrong

 

[globosud]

now no errors, and it hasn't crashed, but strange because on the first try it crashed, then I tried again and everything is ok, but now I have to check what happens as soon as I discover the second religion

 

[f1rpo]

/Edit: Hadn't seen that it crashes only sometimes. I guess, in that case, let's see what else happens .../

No, looks correct. Maybe this change ...

If you do want to block missionaries to the extent that they exist, you could add return None to the end of getReligionMissionary. (With a single tab for indentation.) Currently, it'll probably crash (Python error, not a crash to the desktop) when it doesn't find any missionary unit for a given religion. And cannotTrain will need code for ignoring the None case:

if LimitedReligions.getReligionMissionary(iOwner, iReligionLoop) is None:
	continue

After if iReligionLoop != iStateReligion: and indented one tab farther than that line.

... should be made even if Realism Invictus appears to have a Missionary for each religion. And perhaps some print statements too in the code mentioned above, so that we get some output (in PythonDbg.log) even when the mod causes a crash in the DLL:

print "no missionary found"
return None

print "calling getReligionMissionary"
if LimitedReligions.getReligionMissionary(iOwner, iReligionLoop) is None:
	continue
print "missionary found"

These print statements are only temporary, for debugging purposes. If these don't produce any output, then perhaps one print statement (can be just print the line number of something like that) after every conditional (if) in getReligionMissionary.

 

[globosud]

It'is ok?

 

[globosud]

i have error
raceback (most recent call last):
File "BugConfig", line 110, in unknown_endtag
File "BugConfig", line 334, in endChild
File "BugConfig", line 337, in end
File "BugConfig", line 318, in process
File "BugConfig", line 525, in handle
File "BugUtil", line 642, in getFunction
File "BugUtil", line 629, in lookupFunction
File "BugUtil", line 621, in lookupModule
File "<string>", line 35, in load_module
File "<string>", line 13, in _get_code
IndentationError: unindent does not match any outer indentation level (LimitedReligionsHandlers, line 131)

 

[f1rpo]

Don't know if that's line 131, but the second print seems to have a space in front of it; it's not straight under the first print.

 

[globosud]

I corrected, but now other error
Traceback (most recent call last):
File "BugConfig", line 110, in unknown_endtag
File "BugConfig", line 334, in endChild
File "BugConfig", line 337, in end
File "BugConfig", line 318, in process
File "BugConfig", line 525, in handle
File "BugUtil", line 642, in getFunction
File "BugUtil", line 629, in lookupFunction
File "BugUtil", line 621, in lookupModule
File "<string>", line 35, in load_module
File "<string>", line 13, in _get_code
File "LimitedReligionsHandlers", line 133

MyNonStateRelMissionary = str(LimitedReligions.getReligionMissionary(iOwner, iReligionLoop))

^

SyntaxError: invalid syntax

 

[f1rpo]

Probably because it's indented farther than the preceding line. Indentation should increase only after a colon. Also the next line, "if eUnit...".

 

[globosud]

i not understand sorry
maybe in this mode or second

 

[f1rpo]

Attaching a screenshot with what little Italian I can manage (since you can't easily copy it into a translator). I think you ought to get a bit of a handle on Python indentation. Some of the mod components use spaces or double tabs, but this one and all the original Civ code just does one tab at the start of every block of code (i.e. after each line ending in a colon). And then the indentation stays there, meaning that the block continues, or it goes back one or multiple tabs, meaning that one or multiple blocks end.

Edit: And the "return False" is also OK, same block as the initial "if". (And all the other blocks end there.)

If you want to upload your current version of that file, I can of course also edit it and put the tabs where I think they belong.

 

[globosud]

Sorry. because I don't know if 1 tab is 4 spaces or 8 spaces. i used 1 tab 8 space i hope it is good
I'm certainly wrong in understanding, but from the graph you put, it seems that for 1 tab you mean both 4 and 8 spaces

excellent Italian . thx