Really? I find that surprising. The combat odd generations are notoriously bad. It is rare, but it happens a surprising amount of time considering. The team for Smarter Orcs are working on some potential changes to increase the reliability and realistic outcome for combat odds, not sure where they are at on that sub-project, but I'll be including it if it makes it into their Vanilla releases.
I'll update you on Smarter Orcs combat (spoiler so that anyone who want to stay on topic can easily ignore the rest):
Spoiler :
1) Smarter Orcs never had the odds generation defect that occurred somewhere during 0.23 (and is present in 0.23c). To remove said defect, use the following in getCombatOdds (note that if you want step 2, this is redundant):
Code:
iAttackerStrength = pAttacker->currCombatStr(NULL, NULL, NULL, true);
iAttackerFirepower = pAttacker->currFirepower(NULL, NULL, true);
2) If you want the defender's resistances to work almost perfectly (exception: an attacker's strength can't be reduced below 0.01 due to a defender's resistances), I did a short write-up here. This has been in since Smarter Orcs 0.11
3) There are some odds fixes which I consider to be defects, but others may not. Specifically, Smarter Orcs accounts for Stoneskin and Lifespark. I can write up how, if you desire (note, however, that to simplify this calculation, I also changed Lifesparks so that multiple could sacrifice themselves in a single combat round). This has been in since Smarter Orcs 0.08
4) There is a group of changes in Smarter Orcs (since 0.08, fixed in 0.13) allowing different combat parameters. Actually changing those parameters requires an XML change.
I should also note a few things if you're merging in Smarter Orcs code.
1) Smarter Orcs is large (at least on the C++ side). It may be easier to merge your changes into Smarter Orcs than vice versa.
2) Smarter Orcs is still slow. 0.14 is much faster than 0.01, but there's a long way to go. On the plus side, a few things are actually faster in Smarter Orcs than FfH II (or, indeed, even Vanilla).
3) There is a significant apparent defect density in Smarter Orcs. I try to squash all reported defects, but I can't believe that they're all found, yet.