CivOne - An Open Source remake of Civilization 1

[fire-eggs]

My first thought, after letting my subconscious mull on it, was to add a small delay in the 'Goto' code: pause a short while between 'moves'.

Pondering further, the 'invisible barbarians' thing might be the same problem: when a unit completes a move, there needs to be a pause so the user can see and adjust to any results. I don't recall off-hand how many "movement done" handlers there are, but that seems like an appropriate location to experiment with.

Action on the screen is definitely too fast: transition away from the current unit is large and jarring sometimes.

A well-designed game loop should take system speed into account and provide a consistent and smooth update behavior. I've been focused on bug fixes and features to-date and have not dug into the foundations yet.

 

[fire-eggs]

On the subject of A* goto, I was playing yesterday and observed that units would move "off road", even though taking the road "should" be faster. Using my crude MSPaint skills, I attempt to show an example here:

Chariot in City 2, I tell it to go to City 1. The optimal route would be to take the roads in brown to city 3 then to city 1: 1 turn to get part way to city 1, then 2 partial moves to city 1 on turn 2, with 4 partial moves remaining.

However, the chariot took the black route which happened to be through hills. So 2 turns to move through the hills at least.

I know of a bug where a terrain's movement cost is not being taken into account. Might this bug be the cause of the poor choice of A*, or something else?

 

[rehn]

On the subject of A* goto, I was playing yesterday and observed that units would move "off road", even though taking the road "should" be faster. Using my crude MSPaint skills, I attempt to show an example here:

Yes I have seen that too. It is about the estimated cost of the individual steps. I am adjusting my algorithm for that. Not released yet. Will do some more tweaking/testing.
Related questions. In CivDos: When moving on rail, manually: no cost. When using goto, cost is the same as on road. Is that something we want to keep in CivOne ?
I have found that if diplomats/(chariots?) is moving to a mountain square it sometimes fails if it has 2 steps left but always makes it if it has only one step left.(keep this "bug"?).
If sea unit is entering a city it loses all remaining movement points. I would like to change that

Btw: I have implemented "h" ( not "g": typo in github comments) for air units, Interpreted as " goto city/carrier" if outside city/carrier. Code in BaseUnitAir.cs, minor adds in BaseUnit.cs

 

[fire-eggs]

In CivDos: When moving on rail, manually: no cost. When using goto, cost is the same as on road.

Having rail behave different with goto makes no sense to me. As long as there is a stop condition to prevent a unit from moving infinitely, then rail should _always_ be zero cost...

If sea unit is entering a city it loses all remaining movement points. I would like to change that

Looking forward to it!

I have found that if diplomats/(chariots?) is moving to a mountain square it sometimes fails if it has 2 steps left but always makes it if it has only one step left.(keep this "bug"?).

I'll have to play around with it but that don't sound right to me ... CivOne has a bug in this area but I've not investigated how Microprose behaves.

 

[Volcanon]

He's right about rail not working the same with goto. I never realized it was to prevent infinite loops, but it was very annoying that you couldn't avoid having to micro the movement of armies across an empire after railroad was invented. Seems like you could avoid stopping looped movement by hitting Escape or the space bar.

Anyway I followed this ages ago and it looks fun now. Maybe like a more polished version of FreeCiv, which I could never get into because it just felt like a very rough clone of Civ 2.

 

[fire-eggs]

He's right about rail not working the same with goto. I never realized it was to prevent infinite loops,

I don't know that to be the case, but given no movement expense, I would assume the AI could easily get into a state of moving a unit back-and-forth forever.

One potential solution that occurred to me much later is to let the human have cost-free railroad goto, and not the AI. It would be a pleasant reverse-benefit!

 

[Volcanon]

I don't know that to be the case, but given no movement expense, I would assume the AI could easily get into a state of moving a unit back-and-forth forever.

One potential solution that occurred to me much later is to let the human have cost-free railroad goto, and not the AI. It would be a pleasant reverse-benefit!

I've seen AI units move in a loop so it seems plausible.

 

[FelipeCG]

Nice project, I'd like to contribute programming, but I wonder If I have the required skills... any tips for those who just got here and want to contribute, what should I do to grasp everything done so far (besides reading this thread)?

 

[fire-eggs]

Nice project, I'd like to contribute programming, but I wonder If I have the required skills... any tips for those who just got here and want to contribute, what should I do to grasp everything done so far (besides reading this thread)?

How are your Civilization skills? Playing the game and identifying discrepancies between this and the original game is important.

You can look at any post of darkpanda's to read in-depth descriptions of the original DOS code. Possibly too deep for getting started tho.

You can look at SWY's Github repository which is the base we're working from. Unfortunately, the code is not documented or described. You can look at the issues there for things that need doing.

My Github fork is the most "advanced" right now, where I've fixed a bunch of bugs. You can look at the Issues there to see stuff that I'm tracking. Or diff my code vs SWY's and try to understand the changes, what was fixed, and where.
There are over 100 TODO items in the code.

I've not yet spent any time trying to get stuff organized / documented.

There are a bunch of areas which are missing functionality or haven't been examined, in addition to listed issues:

diplomacy
fog-of-war
alternative graphics
plug-in support / testing / samples; mod support (alternate pictures)
nuclear meltdown on city disorder [City.cs, NewTurn()]
Force Democracy civilization into revolution on extended city disorder [City.cs, NewTurn()]
accumulate & show game replay
civilization rankings & announcement
land barbarian spawning [in progress?]
civilization score
powergraph
demographics (?)
difficulty levels
game save / load fully compatible with Civ DOS
fix SDL issues: "frame rate", graphics glitches
build, package, install
unit test support and actual tests
palace: drawing and update
"best civilization" report

AI:
- city production
- science advances
- movement [in progress]
- barbarian logic

Many of those are big-and-hairy items but there are smaller bits that could be teased out to tackle.

 

[hospital]

city goes into revolution

Pretty sure SWY merged my PR for that a few months ago.

 

[fire-eggs]

Pretty sure SWY merged my PR for that a few months ago.

Yup, my bad. Mis-interpreted a TODO.

Should read:
- Force Democracy civilization into revolution on extended city disorder [City.cs, NewTurn()]

Updated - thanks!

 

[FelipeCG]

Thanks for the detailed answer. I browsed the project, got familiarized and checked the links. I guess I have to understand it better before I contribute. It feels awesome.

 

[hospital]

Has anybody tried running it under dotnet 3?

 

[fire-eggs]

Has anybody tried running it under dotnet 3?

SWY changed his repo to build with DotNet 3.0 on Oct-14-2019; I've not tried it yet myself.

 

[fire-eggs]

An another problem I have had all the time is that when I use "goto" ( standard or smart ) the units moves "jumpy"
and sometimes just are "teleported" to the destination with "invisible" intermediate steps.

You might look into making a small tweak to MoveUnit.cs (in src/Tasks) and see if that makes a difference.
Namely, comment out the "[Fast]" attribute. It seems to have an effect on the game Update process.

 

[hospital]

For what it's worth I have a PR to update to dotnet core 3.1 (since 3.0 is EOL). It's only a small change and it still seems to work ok.

https://github.com/SWY1985/CivOne/pull/503

I should have some time to work on this now and I am going to look at spawning land barbarians next.

 

[axx]

SWY still MIA? Hope he's well.

 

[tupi]

I should have some time to work on this now and I am going to look at spawning land barbarians next.

We still don't know exact logic for this, there's only observation. I hope I can disassemble this part of the original game soon (but I never did such a thing before and for now I named only about 10 global variables and some functions). There's still no land barbarian spawning in my Sega Genesis port, because this event is so random and axx described it only from observation.

 

[hospital]

We still don't know exact logic for this, there's only observation. I hope I can disassemble this part of the original game soon (but I never did such a thing before and for now I named only about 5 global variables and some functions). There's still no land barbarian spawning in my Sega Genesis port, because this event is so random and axx described it only from observation.

I was going to go with this description as you noted from axx:

https://forums.civfanatics.com/threads/barbarians-spawn-logic.630389/#post-15096489

But it can always be changed later if the exact behaviour becomes available.

 

[SWY]

Hello everyone. First of all... I am so sorry for disappearing without a trace.
I've had a pretty unpleasant couple of months at my old job, at the end of 2018; been close to being completely burned out. Then I found a job which was good, but not that good, and in May last year I've started my current job, which is amazing: Building an entirely new IoT platform for automated buildings, from the ground up. Another plus of this job is that I've mostly been working from home. But that's probably also what went wrong with my presence here and working on CivOne: My job has been so intensive and fulfilling, that I haven't found the time or the motivation to do any more programming in my free time. I've spend most of my free time with my family.

I wish I could say I've resolved this problem, and that I've found a way to enjoy programming in my free time again... but I'm not sure yet. I want to try picking up where I left over the coming weeks. I'll start reading up on everything I've missed in this thread. Hopefully, I will be able to plan a couple of hours a week for working on CivOne again, eventually. I really want to and I will try my best. Talk to you all soon!