Has anyone noticed reduced Flood yields with Egypt? It seems like Iteru's bonus is the exact same as that provided by a Dam - it prevents damage but also reduces the bonus yields.
I think its not supposed to reduce the flood yields. In the data, Iteru gained the following 3 modifiers:
<Row>
<TraitType>TRAIT_CIVILIZATION_ITERU</TraitType>
<ModifierId>TRAIT_AVOID_MODERATE_FLOOD</ModifierId>
</Row>
<Row>
<TraitType>TRAIT_CIVILIZATION_ITERU</TraitType>
<ModifierId>TRAIT_AVOID_MAJOR_FLOOD</ModifierId>
</Row>
<Row>
<TraitType>TRAIT_CIVILIZATION_ITERU</TraitType>
<ModifierId>TRAIT_AVOID_THOUSAND_FLOOD</ModifierId>
</Row>
All 3 of these are of the type
<ModifierType>MODIFIER_PLAYER_ADJUST_AVOID_RANDOM_EVENT</ModifierType>
I'm not sure at what stage dams prevent yields, but, the terminology for "avoid_random_event" is present in things like Liang's reinforced materials promotion modifier, russia's ability to avoid blizzard damage, etc., none of which affect disaster yields. Whereas Dams and the Great bath have the flag "preventsfloods." My guess is it is "prevents floods" that causes reduced yields, not the "avoids damage" modifier since dams don't actually have those as a modifier. Or any modifier at all that I can see.
It's possible it's not coded correctly, though. There was a stream where they discussed the change, but i cannot recall if they talked about the yields. Only that they said egypt would still want to build dams for the hydro plant but they otherwise didn't do anything. That's just my guesswork based on what's in the code we can see. There's a lot we cannot see.