First of all:
Enable logging. This will help you tremendously.
After that, you'll get an error message telling you about the fact you haven't closed the function (there is a few 'end' statements missing).
After solving this syntax error, we come back to the second line of code:
Code:
function Happinessfromwheat([U]iplayer[/U])
[COLOR="Red"] local pplayer = Players[[U]player[/U]][/COLOR]
[...]
You will never have the right player, because '
player' isn't defined anywhere. This should be '
iplayer'.
Right after that, we have another problem:
Code:
if [B]pplayer[/B]:IsAlive() and [B]pPlayer[/B]:GetCivilizationType() == GameInfoTypes["CIVILIZATION_HERO"] then
for pCity in [B]pPlayer[/B]:Cities() do
Lua is case-sensitive, which means
pplayer was indeed defined before, while
pPlayer wasn't, so the code will never go past the second check (it will return 'pPlayer isn't defined anywhere').
We see this same issue a bit later with
pCity.
After a bit, in the near end of the code, we see this:
Code:
if pPlot:GetOwner() [U]==player[/U] [B]a[/B] pPlot:GetResourceType() == GameInfoTypes.RESOURCE_WHEAT then
pPlot:GetOwner() returns the owner's ID, so what you're looking for here is iPlayer. Also, you need to get a space between those == and the variable.
Also, that 'a' should be 'and'.
Lastly, this:
Code:
[B]local[/B] NumberCultureBuildings = NumberCultureBuildings + 1
You're creating a whole new NumberCultureBuildings with that 'local', different from the one in the beginning of the code. Drop this off. For more about local variables, take a look at the tutorial at the end of this post.
In the end, your code will look like this:
Code:
function Happinessfromwheat(iPlayer)
local pPlayer = Players[iPlayer]
if pPlayer:IsAlive() and pPlayer:GetCivilizationType() == GameInfoTypes["CIVILIZATION_HERO"] then
for pCity in pPlayer:Cities() do
local NumberCultureBuildings = 0
for i = 0, pCity:GetNumCityPlots() -1, 1 do
local pPlot = pCity:GetCityIndexPlot(i)
if pPlot:GetOwner() == iPlayer and pPlot:GetResourceType() == GameInfoTypes["RESOURCE_WHEAT"] then
NumberCultureBuildings = NumberCultureBuildings + 1
end
end
pCity:SetNumRealBuilding(GameInfoTypes["BUILDING_UDON"], NumberCultureBuildings)
end
end
end
[COLOR="Blue"]GameEvents.PlayerDoTurn.Add(Happinessfromwheat)[/COLOR]
The blue line is assuming you have posted your whole code, which means it wasn't being hooked to anything so no way it would work anyway.
Here is a
beginner's guide for Lua. It is just the initial steps, but it might help you with your coding career.
EDIT: Beaten by 8 whole minutes.
