HasMet Worst Enemy check

[phungus420]

In Legends of Revolution I've added a couple of lines of code (thanks to Sephi), that checks if a civilization knows another civilization before a "You have traded with our worst enemy" penalty function is run. This makes it so that when you first meet a new civ you don't have a -4 diplo penalty right off the bat. This applies to AI-AI relations as well. I haven't noticed any real gameplay effects of this change, I just like not meeting some new civ and having them hate me for no reason I could have foreseen.

This code is pretty simple and I've been thinking of adding it to RevDCM. However it's the type of gameplay change I need to check with people to make sure if it's a wanted thing or not. So do people want to see this applied, or do people want things to stay as is?

For the record this is the code:

						//phungus Has Met Worst Enemy Trade Penalty check
							//make sure that if A trades with B and A is C's worst enemy, C is only mad at B if C has met B before
							//A = this
							//B = eIndex
							//C = (TeamTypes)iI
							[B]if (GET_TEAM((TeamTypes)iI).isHasMet(GET_PLAYER(eIndex).getTeam()))[/B]
							{
								GET_TEAM((TeamTypes)iI).AI_changeEnemyPeacetimeTradeValue(GET_PLAYER(eIndex).getTeam(), iChange);
							}
						//phungus end

 

[Zeiter]

This is a MUCH needed change. For gameplay reasons, obviously, but also for realism reasons. A human would not hold another human so arbitrarily accountable for doing something that the other human never could have been aware of.

 

[Snofru1]

I like it, go for it !

 

[Duuk]

Yes please.

Is there any way to remove the "non-ai" catches from AI-AI diplomacy?

Things like "A first impression is a lasting one" don't seem to affect the AI.

Basically, the AI doesn't hate its neighbors enough, which leads to stagnation, which leads to the human player always winning.

 

[phungus420]

OK. Since it seems to be supported, and there were no objections, I have updated the SVN with this change.