Zechnophobe
Strategy Lich
In an attempt to make new Scenario's easier to make, I have changed my local files to split apart the code for each, and I'd like you to use this implementation for the live version. The way I have it set up now works thusly:
A new scenario uses the name SCENARIO_NAME.py, and defines each of the functions currently in Scenario Functions. Whereas Scenario Functions now acts simply as a pass through that checks to see what scenario is active. For instance, this would use this function:
Which would be called like:
Generate a new SCENARIO.PY from a template (Which I have and can provide).
Lastly, I removed all 'extra' function from ScenarioFunctions, and placed them in CustomScenarioFunctions (Such as the getHeroXP) since these break the design paradigm (You should only have functions in the scope of loading or working with scenarios, not grab bag functions):
The benefits which this reap (considerable!) Are that all the effects of a scenario are now in their own area. For Example, the Splintered Court:
Assuming you agree this is a good idea, how would you like me to get my files to you? (You don't want to have to duplicate what I've done). Note that this is up through patch 'd', so you'd have to merge it with 'e' before working on 'f'. I have not created a SCENARIO file for Wages of Sin since it didn't look anywhere near completion.
Do you have a version-ing system I could just check these files into or something? Let me know.
A new scenario uses the name SCENARIO_NAME.py, and defines each of the functions currently in Scenario Functions. Whereas Scenario Functions now acts simply as a pass through that checks to see what scenario is active. For instance, this would use this function:
Code:
def getScenario(self):
if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_WB_AGAINST_THE_WALL):
return SCENARIO_AGAINST_THE_WALL.SCENARIO_AGAINST_THE_WALL()
if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_WB_AGAINST_THE_GREY):
return SCENARIO_AGAINST_THE_GREY.SCENARIO_AGAINST_THE_GREY()
if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_WB_INTO_THE_DESERT):
return SCENARIO_INTO_THE_DESERT.SCENARIO_INTO_THE_DESERT()
if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_WB_FALL_OF_CUANTINE):
return SCENARIO_FALL_OF_CUANTINE.SCENARIO_FALL_OF_CUANTINE()
if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_WB_GIFT_OF_KYLORIN):
return SCENARIO_GIFT_OF_KYLORIN.SCENARIO_GIFT_OF_KYLORIN()
if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_WB_GRAND_MENAGERIE):
return SCENARIO_GRAND_MENAGERIE.SCENARIO_GRAND_MENAGERIE()
if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_WB_THE_BLACK_TOWER):
return SCENARIO_THE_BLACK_TOWER.SCENARIO_THE_BLACK_TOWER()
if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_WB_THE_RADIANT_GUARD):
return SCENARIO_THE_RADIANT_GUARD.SCENARIO_THE_RADIANT_GUARD()
if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_WB_BARBARIAN_ASSAULT):
return SCENARIO_BARBARIAN_ASSAULT.SCENARIO_BARBARIAN_ASSAULT()
if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_WB_BENEATH_THE_HEEL):
return SCENARIO_BENEATH_THE_HEEL.SCENARIO_BENEATH_THE_HEEL()
if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_WB_BLOOD_OF_ANGELS):
return SCENARIO_BLOOD_OF_ANGELS.SCENARIO_BLOOD_OF_ANGELS()
if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_WB_LORD_OF_THE_BALORS):
return SCENARIO_LORD_OF_THE_BALORS.SCENARIO_LORD_OF_THE_BALORS()
if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_WB_MULCARN_REBORN):
return SCENARIO_MULCARN_REBORN.SCENARIO_MULCARN_REBORN()
if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_WB_RETURN_OF_WINTER):
return SCENARIO_RETURN_OF_WINTER.SCENARIO_RETURN_OF_WINTER()
if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_WB_THE_CULT):
return SCENARIO_THE_CULT.SCENARIO_THE_CULT()
if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_WB_THE_MOMUS):
return SCENARIO_THE_MOMUS.SCENARIO_THE_MOMUS()
if gc.getGame().isOption(GameOptionTypes.GAMEOPTION_WB_THE_SPLINTERED_COURT):
return SCENARIO_THE_SPLINTERED_COURT.SCENARIO_THE_SPLINTERED_COURT()Which would be called like:
Code:
def doTurn(self):
myScenario = self.getScenario()
myScenario.doTurn()Generate a new SCENARIO.PY from a template (Which I have and can provide).
Lastly, I removed all 'extra' function from ScenarioFunctions, and placed them in CustomScenarioFunctions (Such as the getHeroXP) since these break the design paradigm (You should only have functions in the scope of loading or working with scenarios, not grab bag functions):
Code:
class CustomScenarioFunctions:
def addPopupWB(self, szText, sDDS):
szTitle = CyGameTextMgr().getTimeStr(CyGame().getGameTurn(), false)
screen = CyGInterfaceScreen( "MainInterface", CvScreenEnums.MAIN_INTERFACE )
xRes = screen.getXResolution()
yRes = screen.getYResolution()
popup = PyPopup.PyPopup(-1)
popup.addDDS(sDDS, 0, 0, 500, 800)
popup.addSeparator()
popup.setHeaderString(szTitle)
popup.setBodyString(szText)
popup.setPosition((xRes - 840) / 2,(yRes - 640) / 2)
popup.setSize(840, 640)
popup.launch(true, PopupStates.POPUPSTATE_IMMEDIATE)
def getHeroXP(self, iPlayer, iUnit):
"""returns the amount of XP that the given unit has, owned by a player. If iUnit is not unique
then it will return the xp of the last unit found. If no units are found, returns -1"""
apUnitList = PyPlayer(iPlayer).getUnitList()
iXP = -1
for pLoopUnit in apUnitList:
if pLoopUnit.getUnitType() == iUnit:
if pLoopUnit.getExperience() > iXP:
iXP = pLoopUnit.getExperience()
return iXP
def giftHeroXP(self, iPlayer, iUnit, iXP):
"""Finds all units of type 'iUnit' owned by iPlayer, and gives them 'iXP' experience."""
apUnitList = PyPlayer(iPlayer).getUnitList()
for pLoopUnit in apUnitList:
if pLoopUnit.getUnitType() == iUnit:
pLoopUnit.changeExperience(iXP, -1, False, False, False)The benefits which this reap (considerable!) Are that all the effects of a scenario are now in their own area. For Example, the Splintered Court:
Spoiler :
Assuming you agree this is a good idea, how would you like me to get my files to you? (You don't want to have to duplicate what I've done). Note that this is up through patch 'd', so you'd have to merge it with 'e' before working on 'f'. I have not created a SCENARIO file for Wages of Sin since it didn't look anywhere near completion.
Do you have a version-ing system I could just check these files into or something? Let me know.
. Anyhow, I don't want to beat a dead horse, but the thing my version fixes IS the buggy programmer. Readable, maintainable code goes along way to make a programmer look like a master 
. (Note that 'GAMEOPTION_WB_' appears 106 times).
