Meeting a City-State

bane_ · Sep 7, 2015

I've tried with the args being Player ID and Team ID, yet nothing works.
There is no error, it just doesn't go on.

From experience derived from earlier versions of this code, the problem seems to be IsMinorCiv, but I have no idea why and research proved fruitless.

Code:

function PlagueMet(iPlayer, iPlayerMet)
	--local pTeam = Teams[iTeam]
	--local pTeamMet = Teams[iTeamMet]
	local pPlayer = Players[iPlayer]
	local pPlayerMet = Players[iPlayerMet]
	if pPlayer:GetCivilizationType() == ePlagueLords then
		print("[PlagueMet] Started.")
		print("[PlagueMet] Player met is a City-State? " ..tostring(pPlayerMet:IsMinorCiv()))
		if pPlayerMet:IsMinorCiv() then
			print("[PlagueMet] Plaguelords met a Minor Civ.")
			if WBCTable.iTimesMetCS > 0 then
				print("[PlagueMet] Number of times met a Minor Civ is below 3.")
				local iModifier = WBCCheckMultiplierGS()
				pPlayerMet:ChangeMinorCivFriendshipWithMajor(iPlayer, (105 * iModifier))
				WBCTable.iTimesMetCS = WBCTable.iTimesMetCS - 1
			else
				print("[PlagueMet] First part of UA is DONE.")
				GameEvents.TeamMeet.Remove(PlagueMet)
			end
		end
		print("[PlagueMet] Ended.")
	end
end

AW Arcaeca · Sep 7, 2015

Is this the whole code? I don't see an event hook or anywhere else where the function is called...

EDIT: Woah! I just noticed this is post #2500! That's a nice round number.

bane_ · Sep 8, 2015

The whole code has 3922 lines, it is easier to just paste the problematic part. :lol:

I'm using the TeamMeet hook, as I believe - even with howard's modded DLL - is the only proper one.

Nutty · Sep 8, 2015

The parameters are indeed teams, not players. How were you getting player IDs from teams? Were you assuming they were the leader with GetLeaderID() or were you looping through the players and doing Player.GetTeam?

bane_ · Sep 8, 2015

I was using GetLeaderID(). Is it a bad idea?

LeeS · Sep 8, 2015

Firaxis used nearly an identical method to the blue highlight in one of their scenario "TurnsRemaining.lua" to translate between TeamID and PlayerID

Spoiler :

I threw the "break" into that basic structure, which would probably make the whole thing, er, "break", when someone is using actual teams.
Yes I know I need to de-hard-code and optimize the sorting for the era a bit, especially as this is the bit of my Era Buildings mod which will likely make it incompatible with Pouakai's new Enlightenment Era mod
The Firaxis method may also be a bit too brute-force and non-optimum, but it does seem to be working properly. And no, I haven't decided what I am going to do about the whole "there can actually be teams" issue.

bane_ · Sep 9, 2015

I tried the loop.

Spoiler :

The log:

Spoiler :

I looked at some other codes, JFD uses at least twice - Switzerland and Belgium - the method I was using (with GetLeaderID()) and it works.
What am I doing wrong, Lord, what? :cry:

EDIT: It seems to me that the issue is with the Team check, but why? Both are integers, so I'm not comparing apples to oranges; at least ONE was supposed to click and go on, but none? That's weird.

whoward69 · Sep 9, 2015

22 "checking ..."s should be a hint that the code is incompatible with the subject line "Meeting a City-State"

22 is the default max number of civs in the game. All city states start above this number ...

... ummmm ...

... perhaps

Code:

for iPlayer = 0, [B][COLOR="Red"]GameDefines.MAX_MAJOR_CIVS[/COLOR][/B] - 1, 1 do

is the cause of the problem

bane_ · Sep 9, 2015

One of the Teams meeting is a Major Civ, shouldn't it recognize that at least?

I mean, it loops through all Major Civs one of them must be me, and when it finds 'me' in the loop, that Civ's team ID should be iTeam, right?

LastSword · Sep 9, 2015

GetLeaderID would probably not work with some scenarios (Teams).

Anyway, you have incorrectly assumed that major player's team will be always a first value. Loop for 22 is correct (since you are looking for certain major civ type), but OR statement (equal to second team) is needed. Second function (you will be calling either (iPlayer, team1) or (iPlayer, team2)) and it is done.

For future, learn to use prints... seriously, the initial values are something you should print at once.

Good luck.

bane_ · Sep 9, 2015

LastSword said:
Anyway, you have incorrectly assumed that major player's team will be always a first value.

That was it.

Thanks everyone!

LeeS · Sep 9, 2015

oh. Sorry, Bane_. I just figured you would naturally see the MAX_MAJOR_CIVS and change that part to the MAX_CIV_PLAYERS for your needs.

I didn't need to let my version of the loop go through city-states because city-states never get to have the buildings I am interested in within my mod.

LastSword said:
For future, learn to use prints... seriously, the initial values are something you should print at once.

Has saved me endless hours of hair-pulling and :wallbash:

.

Especially when you are expecting a method or function to be passing you an integer (for example), and you instead are being given "Horseradish" by that method or function for a variable you have called iTeam.

bane_ · Sep 9, 2015

LeeS said:
oh. Sorry, Bane_. I just figured you would naturally see the MAX_MAJOR_CIVS and change that part to the MAX_CIV_PLAYERS for your needs.

No need to apologize, it's not your fault. And I did not need to change it anyway, just add another check for the second argument.

I put a LOT of prints, but not the most fundamentals ones, apparently. :lol:

Meeting a City-State

bane_

Howardianism High-Priest

AW Arcaeca

Deus Vult

bane_

Howardianism High-Priest

Nutty

Deity

bane_

Howardianism High-Priest

LeeS

Imperator

bane_

Howardianism High-Priest

whoward69

DLL Minion

bane_

Howardianism High-Priest

LastSword

Prince

bane_

Howardianism High-Priest

LeeS

Imperator

bane_

Howardianism High-Priest

Similar threads