Please revisit your lens mods!

[Craimasjien]

Hey all,

As explained in the Additive UI Elements post in the tutorials section, we have found a way to non-desctructively (e.g. without overiding the panel-mini-map.js file) create lenses. I'm hoping mods from -- amongst others -- @wltk , @BlobRoss and @moxl can get updated to follow the same approach so they work together out of the box. I found that @DanielD1909 did great work consolidating our mods but with these changes it should not be necessary anymore!

Let me know if you need help or want more information on this approach!

 

[wltk]

Just an update here that I did the compatibility update to my mod. Thanks for the finding. I also found a way to avoid overriding "interface-mode-unit-selected.js" in my mod, by listening to interface mode change events. https://github.com/hanweizhang/Civ7...lens/modules/ui/dl/unit-selection-listener.js

 

[BlobRoss]

Thanks for the info. I'll take a look at updating.

 

[BlobRoss]

Updated my trade lens mod, worked very nicely.

 

[Craimasjien]

Just an update here that I did the compatibility update to my mod. Thanks for the finding. I also found a way to avoid overriding "interface-mode-unit-selected.js" in my mod, by listening to interface mode change events. https://github.com/hanweizhang/Civ7...lens/modules/ui/dl/unit-selection-listener.js

Oh perfect, I need to do this too for the missionary unit! Don't mind me if I take a look at how you solved that!

 

[wltk]

I realized the interface-mode-change event won't trigger if you select unit immediately after selecting another. So I changed to listen to UnitSelectionChanged event and resolve the racing issue with setTimeout to delay my listener execution to the end of the queue. https://github.com/hanweizhang/Civ7...scovery-lens/ui/dl/unit-selection-listener.js