Problem with EVENT_BETTER_COAL_2, drydock upgrade

[Husyor]

I got the event name after searching around the forums and it is the event that gives you a choice of +4 for coal plant, i think theres another option here, or your drydock to have + 2 and +1 . My problem is that not all my drydocks are getting the +2 , yet they all get the +1 I am playing on 3.17 . Anyone else have this problem or can help a brother out?

 

[ori]

could you post a savegame?

 

[Husyor]

Like I said, some of the cities have it, others dont. I was thinking it had to do with cities I had when I got the event, but then why would they all get the health bonus, and then also I seen that the city of Larso would get it when I build the drydock, yet I didnt have that city at the time.

 

[ori]

this is indeed buggy - some cities don't receive the +2 (e.g. Yaroslavl in the save)
this is tested on 3.17.

 

[Husyor]

So what happens to bugs, do they get added to a list for Firaxis to fix or what exactly?

 

[ori]

1) firaxians are known to frequent this forum - especially the bug sections - but don't count on any further official patches...
2) there are people here who try ironing out the few remaining bugs - so if this is fixable within the files that are public this might get fixed by people here

 

[Husyor]

I think this is the same thing with not receiving the hammer bonus with the apostolic palace. I could be wrong though.

 

[Dresden]

Well, they do both work the same way, eventually calling CvCity::changeBuildingYieldChange() so they could be related.

Husyor, do you have any other saves from that game? Particularly interesting would be a save from just before the event (approx 1830 looking at the log) and a save from just before you captured Larsa (approx 1985)

 

[Husyor]

I have a file for right before I take Larsa, and I have a save of a game 12 turns before the event, but I force end turn until 1830 and did not get the event.

Let me know if you need anything else.

 

[Dresden]

I should be able to manually trigger the event through the Python Console; the important thing is to have the game in the pre-event situation so that save should do. Thanks! I'll poke around and see if I can find anything.

 

[Dresden]

After examining your saves and running some tests, I'd say it's almost definitely an issue with cities being acquired after you get the event.

Here's the timeline I've pieced together from the turn log and replay.

1820 - Rome captures Khabarovsk from Russians.
1831 - Rome gets the Better Coal Fuel event, all current Roman cities 
       (including Khabarovsk) get the drydock production & health bonus
1832 - Rome captures Yaroslavl from Russians; as this came after the event
       it only gets the drydock health bonus.
.... - As with Yaroslavl, all other captured cities in this time-frame are 
       missing the production bonus.
1978 - Rome captures Nicomedia from Aztecs; this is the last coastal capture 
       without the drydock production bonus.
1980 - (July) Aztecs get the Better Coal Fuel event and also pick the drydock
       option; all current Aztec cities (including, for example, Larsa) get
       the drydock production & health bonus
1986 - Rome captures Larsa from Aztecs. Because this city had the drydock
       production bonus from the Aztecs, it retains it after capture.
.... - Future cities captured from the Aztecs retain the production bonus too.

Note that the last (inland) city captured from the Aztecs prior to them getting the Better Coal event was Tula and the first one captured after was Atzcapatloco (or something like that ). If you go into the worldbuilder and give both of them a drydock, you'll notice that the former does not get the production bonus, while the latter does. This is inline with the theory.

So the summary is that the health bonus applies to all your future cities but the production bonus only applies to those that you had at the time of the event or those which had a previously-existing bonus from someone else's event. This also means (confirmed in a quick test) that if you found a new city after the event it will also only get the health bonus; it's the same situation as the post-event captured ex-Russian cities.

This does seem to be buggy behavior so the next step is to track down the differences between how the health and production bonuses are handled and see if the production bonus can be made to "stick" for future cities.

 

[Husyor]

Sounds like good work. Hopefully this type of thing along with the hammers from the apostolic palace can be fixed in the unofficial patch at least, not that I'm running it at the moment, but I have in the past. Thanks for your work in trying to solve this.