Promotion conversion broken

[DarkLizener]

Hi
I just played a game as England and noticed that when I upgrade my Longbowmen to Riflemen they keep their archer promotions like accuracy etc. (which of course are useless for riflemen).
Is this a problem with the UU or a general bug (didn't test that)?
I used the beta 4.31, no other mods enabled.

 

[Thalassicus]

Thank you for bringing this up! I found the bug: when a unit's upgraded I was checking the classification of the old type instead of what it's upgrading to. In this case it meant it was checking to see if Longbowmen can have archer promotions, so it didn't do anything.

There were also separate, unrelated bugs in 4.31 preventing the file this code is in from loading, which mean the promotions weren't converted at the end of the turn either. Those particular bugs were fixed in 4.32, and combined with this fix everything should be working properly in 4.33.