EmperorFool
Deity
No worries, I did that a year or so ago while playing a game. 
trying to use a minimalist mod to do big things
- Thread starter antaine
- Start date
hmmmmmmm....I've tried to get this to work from Baldyr's tutorial but it keeps rejecting it.
of course, once I can get that to properly display, i need to add a YES and a NO button and tie the big spawn to YES and the little spawn to NO. Then I need to run a search of the area first and only display the popup if the human player has a city in the flipzone.
I'm finding the API a little confusing on this.
Code:
#testpopup, remove when done
modPopup = PyPopup()
if isDate(-3990):
modPopup.setHeaderString("A new civilization is born!")
modPopup.setBodyString("The Latin citizens of Rome have declared their independence. They lay claim to all of Italy. Will you recognize their sovereignty? Refusal will mean war.")
modPopup.launch()of course, once I can get that to properly display, i need to add a YES and a NO button and tie the big spawn to YES and the little spawn to NO. Then I need to run a search of the area first and only display the popup if the human player has a city in the flipzone.
I'm finding the API a little confusing on this.
alright, forget that...I'm going to test something I made after reading Kael's tutorial. There's still more I have to do with it first, but here's where I'm at now. I'm going to define one of these for each spawn, so they're easier to call for the actual spawn codes. Basically, "yes" will lead to a full flip and no war, and no will lead to a limited flip and war on start.
Code:
def romePopup(self, argsList):
iPlayerNum = 0
for iPlayer in range(gc.getMAX_PLAYERS()):
player = gc.getPlayer(iPlayer)
if player.isAlive():
iPlayerNum = iPlayerNum + 1
if player.isHuman():
popupInfo = CyPopupInfo()
popupInfo.setButtonPopupType(ButtonPopupTypes.BUTTONPOPUP_PYTHON)
popupInfo.setText(CyTranslator().setText("The Latin citizens of Rome have declared their independence. They lay claim to all of Italy. Will you recognize their sovereignty? Refusal will mean war.",()))
popupInfo.setData1(iPlayer)
popupInfo.setOnClickedPythonCallback("classicalButtons")
popupInfo.addPythonButton(CyTranslator().setText("Yes", ()), "")
popupInfo.addPythonButton(CyTranslator().setText("No", ()), "")
popupInfo.addPopup(iPlayer)and this is what I'd put in CvScreensInterface.py
the spawns as I've scripted them (basically...they will need tweaking) will be the result of a "yes" answer. I'll still have to script the "no" answer
am I cruising for something that works here, or am I totally off base?
the spawns as I've scripted them (basically...they will need tweaking) will be the result of a "yes" answer. I'll still have to script the "no" answer
Spoiler :
am I cruising for something that works here, or am I totally off base?
Did you import the Popup module?
This doesn't make a whole lot of sense:
def romePopup(self, argsList):
Code:
iPlayerNum = 0
for iPlayer in range(gc.getMAX_PLAYERS()):
player = gc.getPlayer(iPlayer)
if player.isAlive():
iPlayerNum = iPlayerNum + 1
if player.isHuman():
...
popupInfo.setData1(iPlayer)
Code:
def romePopup(self, ePlayer):
pPlayer = gc.getPlayer(ePlayer)
if pPlayer.isHuman():
...I don't know what you're doing with CvScreensInterface.py but all these assignment statements aren't really needed as you don't use any of the variables:
Code:
def classicalButtons(argsList):
iButtonId = argsList[0]
[COLOR="Red"] iData1 = argsList[1]
iData2 = argsList[2]
iData3 = argsList[3]
iData4 = argsList[4]
szText = argsList[5]
bOption1 = argsList[6]
bOption2 = argsList[7][/COLOR]
Code:
if iButtonId == 0:
DawnOfTime.classicalSpawn()
else:
DawnOfTime.classicalWar()Wasn't the importing of the popup module
from Popup import PyPopup ?
If so, I've got that up top. Perhaps my mistake is that it should have been
from Popup import PyPopup() ?
Well, I found other threads directing me here:
http://forums.civfanatics.com/showthread.php?t=183126&highlight=kael+popup
for a good tutorial on popups with buttons that do things. You can see his explanation for the part you've questioned is the only part that he doesn't explain line by line...he just lumps them all together and says they're for ensuring that only the human player gets the popup (something I definitely want to do, as I'd like the game to continue after the first spawn, lol).
I am sort of confused with the whole button-popup thing as Kael's tutorial seems to be the most extensive but still leaves me in the dark a bit. I even tried looking for things that were simple yes/no dialogues but was a bit confused even then (Kael's tutorial made more sense...just not enough sense).
alright, so it should look more like this:
on an unrelated note...this "the server is busy" is driving me crazy. I know it's because of Civ V, but still...don't they know I'm trying to get a mod done here!?
On the upside...your time and patience will not be for naught. After looking at it, I do intend to eventually acquire Civ V and start modding all over again! So this is a good project on which to cut my teeth (so to speak).
Traditionally, I'm a late adopter, so it won't be in the near future, but what you're teaching me will be tremendously valuable.
now...back to the related stuff...once I get the popup working I'm going to need to change the spawn coding so that it reads whether or not the human player(s) (multiplayer, remember) will lose cities and only presents the dialogue if they are. I also need for the answer to only affect that human.
As an example, imagine the following: The Celtic human player settles northern Italy and the Greek human player settles Sicily. They both stand to lose a city. The Celtic player allows the flip, while the Greek player refuses. I need the Celts to lose their city and get no war while the Greeks keep their city and go to war.
Right now, the setOwner type flip works by fiat...a civ will even lose its capital if it is in the zone (which is fine), so I don't know how to have one player permit the flip (thus triggering the zone flip) while respecting the other player's right to refuse and keep their city.
But first...let's get this working. I"m going to test what I have posted above. Hopefully, this will function by the end of the day [/wishful thinking]
from Popup import PyPopup ?
If so, I've got that up top. Perhaps my mistake is that it should have been
from Popup import PyPopup() ?
Well, I found other threads directing me here:
http://forums.civfanatics.com/showthread.php?t=183126&highlight=kael+popup
for a good tutorial on popups with buttons that do things. You can see his explanation for the part you've questioned is the only part that he doesn't explain line by line...he just lumps them all together and says they're for ensuring that only the human player gets the popup (something I definitely want to do, as I'd like the game to continue after the first spawn, lol).
I am sort of confused with the whole button-popup thing as Kael's tutorial seems to be the most extensive but still leaves me in the dark a bit. I even tried looking for things that were simple yes/no dialogues but was a bit confused even then (Kael's tutorial made more sense...just not enough sense).
alright, so it should look more like this:
Spoiler :
on an unrelated note...this "the server is busy" is driving me crazy. I know it's because of Civ V, but still...don't they know I'm trying to get a mod done here!?
On the upside...your time and patience will not be for naught. After looking at it, I do intend to eventually acquire Civ V and start modding all over again! So this is a good project on which to cut my teeth (so to speak).
Traditionally, I'm a late adopter, so it won't be in the near future, but what you're teaching me will be tremendously valuable.
now...back to the related stuff...once I get the popup working I'm going to need to change the spawn coding so that it reads whether or not the human player(s) (multiplayer, remember) will lose cities and only presents the dialogue if they are. I also need for the answer to only affect that human.
As an example, imagine the following: The Celtic human player settles northern Italy and the Greek human player settles Sicily. They both stand to lose a city. The Celtic player allows the flip, while the Greek player refuses. I need the Celts to lose their city and get no war while the Greeks keep their city and go to war.
Right now, the setOwner type flip works by fiat...a civ will even lose its capital if it is in the zone (which is fine), so I don't know how to have one player permit the flip (thus triggering the zone flip) while respecting the other player's right to refuse and keep their city.
But first...let's get this working. I"m going to test what I have posted above. Hopefully, this will function by the end of the day [/wishful thinking]
No, the first import statement should do it. (The second one is invalid.) What was the exception when you copy-pasted from my tutorial?
If at all possible, I think we should still go with the Popup module (PyPopup class) as its designed to be easier to use. But I'll have to take a closer look at what is there before I advice for or against anything. This is new territory for me also, but we should be able to figure this out anyway. If not, someone with previous experience from this stuff will surely come to the rescue.
(Once they are done with playing CivV, that is.)Aha, I though you totally misunderstood how the built-n range() function works.
But looking at the code again, I now realize that it actually has a built in counter for active players. Why I'm not sure, but I don't think you need one.Sure, except that ePlayer isn't defined anywhere. If you insist on keeping argsList as the argument for the romePopup() function you need to extract the PlayerType value and either assign it to ePlayer - or use it directly in getPlayer() to get the CyPlayer instance.
Can you post the method where you're calling on romePopup from the Event Manager? (Becauce I assume this is where you're getting the argsList from.) Do you understand what the argsList is and how it works, at all?
Yeah, do you have a Google account? Because we could use the chat function to cover more topics in less time, if you like... (Or I suppose I could get an MSN account...on an unrelated note...this "the server is busy" is driving me crazy. I know it's because of Civ V, but still...don't they know I'm trying to get a mod done here!?
)Nooo... And I was actually counting you being around these parts for the long haul, while "everybody" else is abandoning ship. Not you too!
On a more serious note, I might join the CivV community once Rhye does a rise and fall type mod for the game. I guess I'll see you there then. But I intend to mod - and play - RFC in the immediate future.
Well, I think we're a bit like in that sense. I just started modding CivIV - and now the game gets "canceled"...
I'll get back to you with some ideas/pointers for the popup business as soon as I get the time.
What about this (cutting out the need for a popup)?
I think this should tell it to check the happiness level of any cities it finds and only flip it if the number of unhappy citizens x3 is greater than the number of total citizens (meaning that if the city is more than 1/3 unhappy).
Unless I'm totally wrong.
This way, both the human and the AI will have a chance to keep their cities if they can keep them happy enough.
Of course, class is going to start and I'm no longer home, so it'll be about four or five hours until I can test it...
Spoiler :
I think this should tell it to check the happiness level of any cities it finds and only flip it if the number of unhappy citizens x3 is greater than the number of total citizens (meaning that if the city is more than 1/3 unhappy).
Unless I'm totally wrong.
This way, both the human and the AI will have a chance to keep their cities if they can keep them happy enough.
Of course, class is going to start and I'm no longer home, so it'll be about four or five hours until I can test it...
By them I'm sound asleep, and will only be online for some 15 minutes when I get up for work - which is usually about the same time you close shop for the day.Lets just pick this up over then weekend then?
By the way, I looked at the various classes in the API and quickly came to the conclusion that CyPopupInfo indeed is exactly what you need. (PyPopup is just a wrapper for CyPopup, and we don't need that for this particular task. You could still use either one for a welcome screen though.)
And the tutorial is also pretty straight forward, so there should be no problems. So just holler once you get stuck and I'll try to explain what's happening. Remember to include all your code and any exceptions that you get.
Some pointers:
Move the variable assignments down to the actual code dealing with the cities. Because you need a CyCity instance to use the methods that are return the actual values (I'm not sure how to get the number of unhappy citizens in a city though...) so you basically do this:
So you almost got it right - you had the right idea. I changed the first if statement around a bit, since you need to get a CyCity instance eventually. But the other way (with CyPlot.isCity() to check if there is a city first) is probably more proper. So you could use either one or experiment with this some more if you like.
Another idea could be to use CyCity.happyLevel() and build a condition around whatever it returns. My guess is that its a integer value - positive for a happy city and negative for an unhappy one - but that's only a guess. You could simply require the level to be whatever you think is sufficient:
As an example.
Code:
def classicalSpawn():
...
iUnhappy = getAngry()
iPopulation = getPopulation()
#Romans
if isDate(-770):
...
for tCoords in getPlotList((60, 43), (63, 48)):
x, y = tCoords
pCurrentPlot = cyMap.plot(x,y)
if pCurrentPlot.isCity():
if "(iUnhappy * 3) => iPopulation":
pCurrentPlot.setOwner(7)
else:
return
Code:
for tCoords in getPlotList((60, 43), (63, 48)):
x, y = tCoords
pCurrentPlot = cyMap.plot(x,y)
pPotentialCity = pCurrentPlot.getPlotCity()
if pPotentialCity != None:
iUnhappy = pPotentialCity.getAngry() # or whatever you need to do to get the value
iPopulation = pPotentialCity.getPopulation()
if iUnhappy * 3 >= iPopulation:
pCurrentPlot.setOwner(7)Another idea could be to use CyCity.happyLevel() and build a condition around whatever it returns. My guess is that its a integer value - positive for a happy city and negative for an unhappy one - but that's only a guess. You could simply require the level to be whatever you think is sufficient:
Code:
if pPotentialCity.happyLevel() < 0:Regarding the Popups, I just now realized what the CyTranslator class does: It fetches text from the various language tags in the XML. So unless you're defining your strings in the XML - and supplying actual translations for them - you don't need to use the CyTranslator.setText() method - at all. Just use a simple string as a argument. This will make things appear much simpler over-all.
Also, don't forget the argsList/iPlayer/ePlayer thing. You have to decide what you wanna use to identify the player.
I deleted the self argument from the function also. Or have you started defining your own classes?
Code:
def romePopup([COLOR="Red"]ePlayer[/COLOR]):
pPlayer = gc.getPlayer(ePlayer)
if [COLOR="Red"]pPlayer[/COLOR].isHuman():
popupInfo = CyPopupInfo()
popupInfo.setButtonPopupType(ButtonPopupTypes.BUTTONPOPUP_PYTHON)
popupInfo.setText("The Latin citizens of Rome have declared their independence. They lay claim to all of Italy. Will you recognize their sovereignty? Refusal will mean war.")
popupInfo.setData1([COLOR="Red"]ePlayer[/COLOR])
popupInfo.setOnClickedPythonCallback("classicalButtons")
popupInfo.addPythonButton("Yes", "")
popupInfo.addPythonButton("No", "")
popupInfo.addPopup([COLOR="Red"]ePlayer[/COLOR])I deleted the self argument from the function also. Or have you started defining your own classes?
I "cheated" and looked up the method for fetching the value for iUnhappy in PyHelpers:
These 3 CyCity methods should give you all the values you'd possible need for you condition. The current setup would then be:
The argument seems to be some sort of modifier and should probably be zero by default...
Code:
def getAngryPopulation(self):
"int - Angry Population"
return self.city.[B]angryPopulation(0)[/B]
def getHappyPopulation(self):
"int - Happy Population"
return self.city.[B]happyLevel()[/B]
def getUnhappyPopulation(self):
"int - Unhappy Population"
return self.city.[B]unhappyLevel(0)[/B]
Code:
iUnhappy = pPotentialCity.unhappyLevel(0)alright, this works perfectly. Now I've got to get the holy city thing working. I'll play with that after dinner.
Also, I may swap out the koreans for another early african civ. As it is, the Egyptians really have little competition. I'm thinking perhaps Nubia early on (as early as is practicable, perhaps right from the start) and agressive spawns of zulu barbarian units (perhaps 9 units every fifty years) in the south.
Also, I may swap out the koreans for another early african civ. As it is, the Egyptians really have little competition. I'm thinking perhaps Nubia early on (as early as is practicable, perhaps right from the start) and agressive spawns of zulu barbarian units (perhaps 9 units every fifty years) in the south.
I'd also like to put in a timed respawn chance for certain civs. Basically, it's designed to spawn a single unit for a dead civ and then attempt a zone flip based on happiness (like the original zone flips).
The code below is supposed to spawn a nonsense unit on a mountain or water tile and then attempt the flip. I intend the flip to "take" only if there are any cities in the zone with greater than 1/3 unhappiness. If no cities meet the requirements, the old civ won't respawn. I also want to give them reasonable techs for their era and set peace between them and everyone else.
Do you see any problems with the following code?
The code below is supposed to spawn a nonsense unit on a mountain or water tile and then attempt the flip. I intend the flip to "take" only if there are any cities in the zone with greater than 1/3 unhappiness. If no cities meet the requirements, the old civ won't respawn. I also want to give them reasonable techs for their era and set peace between them and everyone else.
Do you see any problems with the following code?
