I'm actually giving this some thought...since there's no "stability" like in RFC, might it make sense to simply make the spawns happen without giving a choice to the human player (basically saying, "here's a historical event your civ had to deal with...can you do better?"), or would that be an egregious breach of modding etiquette? The old civ would get to keep their units from the area and would be free to attempt recapture of the rebel territory...
trying to use a minimalist mod to do big things
- Thread starter antaine
- Start date
You're only working on Rome now, for starters?
Post your code once you're satisfied with your implementation. Because you should probably generalize as much of it as possible before moving on to the other Civs. This way the code is basically done and you can move on to designing the rest of the mod.
Post your code once you're satisfied with your implementation. Because you should probably generalize as much of it as possible before moving on to the other Civs. This way the code is basically done and you can move on to designing the rest of the mod.
Well, this is what I've got for now. I commented out the announcement line because the game doesn't like it. I'm looking to read up on why. I was just going to cut and paste the code into the other civs, changing the odd name or coord as needed.
The part I've been working with is the classicalSpawn, about 3/4 the way down.
The part I've been working with is the classicalSpawn, about 3/4 the way down.
Spoiler :
You mention stability... Once you're done and feel like adding a new feature to the mod, perhaps it would be possible to implement some sort of a rudimentary stability system? It could be based on the number of happy faces contra unhappy ones in all player cities. That way it could be easy enough to adjust the balance by making happiness more or less easy to get hold of. No instability from tile ownership or such, in other words.
Just a thought...
Just a thought...
possibly, but I don't intend at this point to mimic that particular feature from RFC.
My immediate focus right now is to get the announcement and the war declaration working properly, then the spawn code is "done" (unless I decide to complicate it later). Then it's just a matter of modifying it for the other civs and I can get working on the holy-city-mover (I think I found a way to simplify my original intention, but I'll broach that when we get that far).
My immediate focus right now is to get the announcement and the war declaration working properly, then the spawn code is "done" (unless I decide to complicate it later). Then it's just a matter of modifying it for the other civs and I can get working on the holy-city-mover (I think I found a way to simplify my original intention, but I'll broach that when we get that far).
would this work for the holy city business? This should check to see if the religion's founding year is less than the current year, and if it is, make Jerusalem the holy city of that religion.
First, I'd like to know if I've written it properly (I wasn't sure what to do with the NewValue and bAnnounce in the last line). I'm not sure what will happen if Jerusalem doesn't exist when this runs
Second, I'd like to improve it...I want to search the 3x3 using AdjacentSquare and assign the religion to any city named "Jerusalem" in that box. (since I bumped the city distance down to 1, a 3x3 box could conceivably hold up to four cities, but only one will be named "Jerusalem"). right now, I'm not sure if finding two cities would cause an exception or simply move the holycity twice, leaving it on the last one in the plotlist which may or may not be Jerusalem.
First, I'd like to know if I've written it properly (I wasn't sure what to do with the NewValue and bAnnounce in the last line). I'm not sure what will happen if Jerusalem doesn't exist when this runs
Second, I'd like to improve it...I want to search the 3x3 using AdjacentSquare and assign the religion to any city named "Jerusalem" in that box. (since I bumped the city distance down to 1, a 3x3 box could conceivably hold up to four cities, but only one will be named "Jerusalem"). right now, I'm not sure if finding two cities would cause an exception or simply move the holycity twice, leaving it on the last one in the plotlist which may or may not be Jerusalem.
Code:
def holyCityNorm():
if getReligionGameTurnFounded(0) < isDate():
for tCoords in getAdjacentList((73, 40)):
x, y = tCoords
pCurrentPlot = cyMap.plot(x, y)
if pCurrentPlot.isCity():
pCity = pCurrentPlot.getPlotCity()
pCity.setHolyCity(0)I don't get to tell you what to do 
, but here is my suggestion: Define a generic spawnCiv() function that takes a PlayerTypes value as an argument (ePlayer). The spawn message, the spawn tile coordinates and the rest of the spawn area would be fetched from data structures (of some sort), so those would have to be defined for use with this. Because then there would be no need to copy-paste any code at all.
The gain would be that once you realize you wanna change something you only have to implement the change in one single place - not 10 or 20 or 30. Also, applying this approach to your entire mod is the difference between having maybe 50 lines of code (not counting the 50-100 lines of data structures that would have to be defined) or maybe 1000 lines of code.
But since this is your first venture into programming you could of course keep it "simple" (well, not really, but...) and save the more refined approach for your next programming project. So make your mind up before starting to copy-paste any code. (Help is available if you need it.)
With that said, before I start to generalize your code for you I thought I'd point a few thing out with the current setup:
PyHelpers isn't actually helping you this time... 
If you use the CyPlayer.initCity() method directly it will yield the newly created CyCity instance as the return value. So you can just go:
Then you don't need to go the extra mile to fetch the CyCity instance:
And you don't need the pRome variable for anything anymore.
This is also a good candidate for a helper function, as you probably wanna spawn cities in several different setups:
This allows you to get rid of a lot of repetition by simply calling on the helper function for all your city spawning needs:
But since the last two arguments are optional (they have default values) you could also get away with just this:
The result would be exactly the same, and if you wanna spawn a city with another size - or with more/less preset culture - you can simply add arguments to those function calls.
Use it if you like and if you feel that it adds to your module instead of just adding to your confusion.
This method invocation really only changes plot ownership:
But you're actually using to change city ownership? 
I've always used CyPlayer.acquireCity() myself... But if it works, then it works (but I can't promise its as reliable). In that case you don't really need this condition either:
As you'd probably wanna change all the plots to Roman, right?
Could the two areas defined as "getAdjacentList((61, 46))" and "getPlotList((60, 43), (63, 48))" respectively be concatenated into one single area? In that case you'd only have to loop the tile coordinates once - instead of first looping tiles to kill cities, and then looping tiles to change plot ownership (and flipping cities as a consequence).
The indentation for this code isn't showing up correctly in my browser:
It could just be the forum acting up, but are you using one or two tabs for each level of indentation? I'm getting this as if you were alternating between one and two tabs, which isn't kosher and might cause exceptions (if not for you, then perhaps for others).
, but here is my suggestion: Define a generic spawnCiv() function that takes a PlayerTypes value as an argument (ePlayer). The spawn message, the spawn tile coordinates and the rest of the spawn area would be fetched from data structures (of some sort), so those would have to be defined for use with this. Because then there would be no need to copy-paste any code at all. The gain would be that once you realize you wanna change something you only have to implement the change in one single place - not 10 or 20 or 30. Also, applying this approach to your entire mod is the difference between having maybe 50 lines of code (not counting the 50-100 lines of data structures that would have to be defined) or maybe 1000 lines of code.
But since this is your first venture into programming you could of course keep it "simple" (well, not really, but...) and save the more refined approach for your next programming project. So make your mind up before starting to copy-paste any code. (Help is available if you need it.)
With that said, before I start to generalize your code for you
I thought I'd point a few thing out with the current setup:
Code:
pRome = cyMap.plot(61, 46)
...
PyPlayer(7).initCity(61, 46)
pRome.getPlotCity().setPopulation(3)
pRome.getPlotCity().setCulture(7, 500, True)
Code:
pPlayer = gc.getPlayer(7)
pCity = pPlayer.initCity(61, 46)
Code:
pCity.setPopulation(3)
pCity.setCulture(7, 500, True)This is also a good candidate for a helper function, as you probably wanna spawn cities in several different setups:
Code:
def spawnCity(ePlayer, iX, iY, iSize=3, iCulture=500):
pPlayer = gc.getPlayer(ePlayer)
pCity = pPlayer.initCity(iX, iY)
pCity.setPopulation(iSize)
pCity.setCulture(ePlayer, iCulture, True)
Code:
spawnCity(7, 61, 46, 3, 500)
Code:
spawnCity(7, 61, 46)Use it if you like and if you feel that it adds to your module instead of just adding to your confusion.
This method invocation really only changes plot ownership:
Code:
pCurrentPlot.setOwner(7)
Code:
if pCurrentPlot.isCity():Could the two areas defined as "getAdjacentList((61, 46))" and "getPlotList((60, 43), (63, 48))" respectively be concatenated into one single area? In that case you'd only have to loop the tile coordinates once - instead of first looping tiles to kill cities, and then looping tiles to change plot ownership (and flipping cities as a consequence).
The indentation for this code isn't showing up correctly in my browser:
Code:
for tCoords in getAdjacentList((61, 46)):
x, y = tCoords
pCurrentPlot = cyMap.plot(x, y)
if pCurrentPlot.isCity():
pCity = pCurrentPlot.getPlotCity()
pCity.kill()Your code has several problems, as you might expect from an early draft. The indentation is all over the place, for starters. (Checking the code for colons at the end of lines is a good way to get blocks of code organized. Also, don't mix types of white space for indentation. Keep to the same type of white space and the same amount for each new level.)
The isDate() function I made will only check if a specified date has passed - and make sure it only returns True once. So it must be supplied with a integer value for the date. In short, this wont work at all:
Also, you forgot about the CyGame instance for the method. 
If you instead look at the isDate() function definition you see that I'm using the CyGame.getGameTurnYear() for fetching the current game date. So you probably want something like this:
You can of course get rid of the "scaffolding" (the variable assignment) and put everything onto one single line - if you want. Why you need the check these dates escapes me however, but you're in change of the logic on this one...
If you use getPlotList() to get a four tile area you're sure to only get once city, right? Then there is no need to check the city name.
With the code you have now, nothing will of course happen if there is no city present. Because you were pro-active enough to use this check:
In short: Good job! 
The isDate() function I made will only check if a specified date has passed - and make sure it only returns True once. So it must be supplied with a integer value for the date. In short, this wont work at all:
Code:
if getReligionGameTurnFounded(0) < isDate():If you instead look at the isDate() function definition you see that I'm using the CyGame.getGameTurnYear() for fetching the current game date. So you probably want something like this:
Code:
iFoundDate = cyGame.getReligionGameTurnFounded(0)
iCurrentDate = cyGame.getGameTurnYear()
if iFoundDate < iCurrentDate:
Code:
for tCoords in getAdjacentList((73, 40)):With the code you have now, nothing will of course happen if there is no city present. Because you were pro-active enough to use this check:
Code:
if pCurrentPlot.isCity():yeah, I'm using two tabs (forum is funny, and sometimes I copy from TextEdit and sometimes from DashCode when I'm posting messages)
Well, there's is a method to my madness in what looks like a double spawn. The other AIs like to put cities on tiles adjacent to the ones for optimal placement. Rhye solved this problem by assigning desirability values to each tile, but that involved playing with the dll. This way, the game plants Rome where Rome should be, and the kill is to kill any city that would be directly adjacent to it. Other than that, I want it to simply flip Italy as it exists over to the Romans (for variation between games).
If I just did a zone-wide flip from the start, the Roman capital would always be in Sicily (since it is the first city they'd acquire in the loop) and Rome would probably be in an odd place (wherever the Greek or Celtic AI saw fit to put it). So AdjacentSquare is to kill off misplaced Romes while the larger area is for the flip. (unless, that is, I've totally misunderstood your objection here)
What did you think of the holy-city-moving code?
Well, there's is a method to my madness in what looks like a double spawn. The other AIs like to put cities on tiles adjacent to the ones for optimal placement. Rhye solved this problem by assigning desirability values to each tile, but that involved playing with the dll. This way, the game plants Rome where Rome should be, and the kill is to kill any city that would be directly adjacent to it. Other than that, I want it to simply flip Italy as it exists over to the Romans (for variation between games).
If I just did a zone-wide flip from the start, the Roman capital would always be in Sicily (since it is the first city they'd acquire in the loop) and Rome would probably be in an odd place (wherever the Greek or Celtic AI saw fit to put it). So AdjacentSquare is to kill off misplaced Romes while the larger area is for the flip. (unless, that is, I've totally misunderstood your objection here)
What did you think of the holy-city-moving code?
"why you need to use these dates"
Well, I don't really...I just need to know if the religion has been founded. Now that I'm not using the method I'd originally wrote (because it won't work), I don't really need to know the date per se.
I suppose I could just use
if isReligionFounded(0)
no?
I've not done anything with searching for cities of a particular name (just any cities existing on sets of tiles), so I'm a little lost on the whole "if "Jerusalem" is in AdjacentSquares (coord)" part of the whole process...
The thing is, I don't want it to assign Jerusalem as a holy city before the religion is founded in the game, and I don't want it to crash if no such city as Jerusalem exists.
Well, I don't really...I just need to know if the religion has been founded. Now that I'm not using the method I'd originally wrote (because it won't work), I don't really need to know the date per se.
I suppose I could just use
if isReligionFounded(0)
no?
I've not done anything with searching for cities of a particular name (just any cities existing on sets of tiles), so I'm a little lost on the whole "if "Jerusalem" is in AdjacentSquares (coord)" part of the whole process...
The thing is, I don't want it to assign Jerusalem as a holy city before the religion is founded in the game, and I don't want it to crash if no such city as Jerusalem exists.
maybe something like this:
(each of my indents is two tabs...trust me...)
Code:
def holyCityNorm():
if isReligionFounded(0):
for tCoords in getAdjacentList((73, 40)):
x, y = tCoords
pCurrentPlot = cyMap.plot(x, y)
if pCurrentPlot.isCity():
pCity = pCurrentPlot.getPlotCity()
if pCity.getName() = "Jerusalem"
pCity.setHolyCity(0)(each of my indents is two tabs...trust me...)
You can of course use two different areas for each spawning player - RFC defines 3 different areas per player as a reference point. I'm thinking about simplification here, thats all.
Ah, all you really need is a move-capital-statement (adding the Palace in the spawned city) and a helper function for making room for spawning new cities:
Code:
def killZone(iX, iY):
tFocusPoint = (iX, iY)
for x, y in getAdjacentList(tFocusPoint):
pCurrentPlot = cyMap.getPlot(x, y)
if pCurrentPlot.isCity():
pCity = pCurrentPlot.getPlotCity()
pCity.kill()
Code:
def spawnCity(ePlayer, iX, iY, iSize=3, iCulture=500[B], bKill=False[/B]):
[B] if bKill:
killZone(iX, iY)[/B]
pPlayer = gc.getPlayer(ePlayer)
pCity = pPlayer.initCity(iX, iY)
pCity.setPopulation(iSize)
pCity.setCulture(ePlayer, iCulture, True)I think I need to add an "else" to there.
Basically, I want to to check each turn to see if the religion is founded, if it is, move the holy city to jerusalem (I should probably start with a check to see if it is already). If jerusalem is razed and later refounded, i want it to be made the holy city again...
Basically, I want to to check each turn to see if the religion is founded, if it is, move the holy city to jerusalem (I should probably start with a check to see if it is already). If jerusalem is razed and later refounded, i want it to be made the holy city again...
You need a class instance for the isReligionFounded() method.
The last if statement is missing the colon at the end - and the subsequent line isn't intended.
And I still get double the indentation for your code, but I guess its not an issue then.
Did you understand what I meant by only checking a 2x2 area instead of a 3x3 area? Because checking for city names is unreliable at best - as it firstly requires your city naming code to be 100% functional - and secondly it can be circumvented by the human player renaming the city.
I'm happy to note that you're catching on with this Python thing.
All you'll need is more practice and getting used to thinking in terms of functions. You'll make a programmer yet! No, you should use the ReligionFounded callup from the SDK. If its not already in the Event Manager you should add it. From there you call on your function once Judaism is founded.
Give it a try!
What if I defined a list of tiles to check in reverse order or preference? This way, it'll check what needs to be checked while ending with the most favored tile (theoretically leaving the holycity on the last one it finds with a city on it). I could define pJerusalem, pRoma, pMecca, etc.
I've skimmed back two pages...what was the 2x2 suggestion?
also...I can't seem to find the command that sets two civs at war. I've looked in the api and in eventmanager. I need to set war between the spawning civ and some neighbors...
I've skimmed back two pages...what was the 2x2 suggestion?
also...I can't seem to find the command that sets two civs at war. I've looked in the api and in eventmanager. I need to set war between the spawning civ and some neighbors...
