trying to use a minimalist mod to do big things
- Thread starter antaine
- Start date
Good to hear about your progress, but looking at the code there is of course enormous potential for improvement. Not necessarily for functionality, but rather on the technical and practical side of things... Like make functions for making peace with everyone (with iteration instead of manually calling on the same method repeatedly) and then calling that instead. Or making a general function that assigns all techs per era. And so on.
Of course just about everything could be generalized so that the whole thing would be so much easier to modify, but you already know this. Its actually about the worst example of repeating code I've yet to see, but as long as its working, I guess...
Just to show you what I mean:
Now, all you have to repeat is:
And if you generalize the function calling on makePeace() you wont need to repeat anything!
But I am very impressed with you solving you problems yourself - and how fast you're learning.
You should probably be starting to think about the state of your code instead of only getting results. Because if you push yourself you'll learn that much more!
Of course just about everything could be generalized so that the whole thing would be so much easier to modify, but you already know this. Its actually about the worst example of repeating code I've yet to see, but as long as its working, I guess...
Just to show you what I mean:
Code:
def makePeace(eTeam):
pTeam = gc.getTeam(eTeam)
for eRival in range(18): # creates a list with integers from 0 to 17
pRivalPlayer = gc.getPlayer(ePlayer)
if pRivalPlayer.isAlive():
eRivalTeam = pRivalTeam.getTeam()
pTeam.makePeace(eRivalTeam)
Code:
makePeace(eTeam)But I am very impressed with you solving you problems yourself - and how fast you're learning.
You should probably be starting to think about the state of your code instead of only getting results. Because if you push yourself you'll learn that much more!Just wait until you see the rest! I've literally just this moment gotten through doing all the peace and all the techs for all the spawns (I discovered that I can't start the workboat civs with their techs because then the religions will spawn immediately upon the first barbarian city founding).
So, yeah...literally just got through with that...up to 2107 lines right now
also went in and started civs capitals with buildings and greater population/numbers (needed for balance)...will have to start certain civs with better units as well...
but other than that, I just need to do the tech related colony thing and the tech related holycity thing and I'm done.
So riddle me this...what is the best way to see if a particular tech has been discovered by anybody? I think that's what I'm going to use to determine whether or not a religion has been founded. I'm going to have the code run onCityBuilt and use an if statement regarding the tech. If both are satisfied, I'll use the loop to assign the holycity status.
I think I'm just going to use adjacentSquare...the worst thing that'll happen is that it'll move twice in the same turn, but honestly, the AI doesn't like taking advantage of the minimum city distance (I guess it crunches the resources too much), so I don't think it would happen but rarely.
Use the onTechAcquired call in the Event Manager and fire the code once anyone discovers the required Tech. But then you need a way to stop the code from being run ever again, and you can use a global variable for this. Firstly you set the default value at module level (= outside of any function):
Code:
bNotTriggered = True
Code:
if bNotTriggered:
bNotTriggered = FalseLets see if you can figure out how to put together the rest...
I actually have no idea... Why do you need the Wworkboat thing, again? Can't the Civs just be dead until they spawn?
I'm thinking about doing that...but I'm not sure if I really want to include ten wbs files. Meh...I'm sure I'll do a few of them, maybe not one for every single civ.
I'm thinking of splitting up that holycity thing into two functions. One that runs on tech acquired and changes the value of bNotTriggered (do I need one of them for each religious tech? I'd think so...) and a second function that runs on city found and moves the city if that religion's bNotTriggered == False
no?
I'm thinking of splitting up that holycity thing into two functions. One that runs on tech acquired and changes the value of bNotTriggered (do I need one of them for each religious tech? I'd think so...) and a second function that runs on city found and moves the city if that religion's bNotTriggered == False
no?
This is actually where it gets interesting. If I'm reading you correctly you're definitely on to something.
Run with it and see where it gets you!I would personally, of course, create one single general function for each task that can handle all religions. Then the data would be read - and set - from data structures. As an example I would have a tReligions tuple:
Code:
tReligions = (False,) * 7
Code:
(False, False, False, False, False, False, False)
Code:
MyModule.religionFounded(eReligion)
Code:
if not tReligions[eReligion]:
tReligions[eReligion] = TrueBut still, you probably need to get Judaism working first. Then, if you want to, we can generalize the setup and you'd have all the other religions already done. All that is needed is to populate the various data structures with values. And those would be very convenient to edit later also, once you realize something needs to be tweaked.
I'm not twisting your arm here. Just almost.
I don't know what that method checks actually, so you'd just have to test it.
This code works well. The religion is founded wherever it would be according to the regular rules of the game, and it then checks every time someone builds a city to see if there are any cities on the "right" plots - if there is, it moves them. The religion's presence is left in its original location, but it is no longer the holy city.
I'm cool with that.
Alright...so...now for tech-related colony spawns, as well as code to kill the workboat and conceal the tiles on new civ spawn, and I can then call it done and start playing around with advanced start wbs files (maybe)
I'm cool with that.
Alright...so...now for tech-related colony spawns, as well as code to kill the workboat and conceal the tiles on new civ spawn, and I can then call it done and start playing around with advanced start wbs files (maybe)
Spoiler :
About killing the Workboat and covering the revealed tiles, I have this in PyScenario for a similar purpose:
Note that this is a class method and not a regular function, but you should be able to see what I've done. getPlot() and getPlayers() are helper functions that return a CyPlot and a CyPlayer instance respectively, so there is no real mystery there. The name self.Context.player refers to a PlayerTypes (player ID) reference (integer).
This is basically the same code from the RiseAndFall module in RFC:
I guess I don't have to point out why I prefer my own instead of using Rhye's code directly? 
(By the way, what are those semi-colons doing at the end of each setRevealed() invocation? 
)
If you have several Workboast on the same tile you can use:
Once again, you could (should) only define one function that takes the target plot as a argument for all your killing and covering purposes - not copy-paste some code over and over again... But its your program.
Code:
def hideSpawn(self):
getPlot((0, 0)).getUnit(0).kill(False, self.Context.player)
for tCoords in getSquareList((0, 0), 2):
getPlot(tCoords).setRevealed(getPlayer(self.Context.player).getTeam(), False, True, -1)This is basically the same code from the RiseAndFall module in RFC:
Code:
plotZero = gc.getMap().plot( 0, 0 )
if (plotZero.getNumUnits()):
catapult = plotZero.getUnit(0)
catapult.kill(False, iCiv)
gc.getMap().plot(0, 0).setRevealed(iCiv, False, True, -1);
gc.getMap().plot(0, 1).setRevealed(iCiv, False, True, -1);
gc.getMap().plot(1, 1).setRevealed(iCiv, False, True, -1);
gc.getMap().plot(1, 0).setRevealed(iCiv, False, True, -1);
gc.getMap().plot(123, 0).setRevealed(iCiv, False, True, -1);
gc.getMap().plot(123, 1).setRevealed(iCiv, False, True, -1);
gc.getMap().plot(2, 0).setRevealed(iCiv, False, True, -1);
gc.getMap().plot(2, 1).setRevealed(iCiv, False, True, -1);
gc.getMap().plot(2, 2).setRevealed(iCiv, False, True, -1);
gc.getMap().plot(1, 2).setRevealed(iCiv, False, True, -1);
gc.getMap().plot(0, 2).setRevealed(iCiv, False, True, -1);
gc.getMap().plot(122, 0).setRevealed(iCiv, False, True, -1);
gc.getMap().plot(122, 1).setRevealed(iCiv, False, True, -1);
gc.getMap().plot(122, 2).setRevealed(iCiv, False, True, -1);
gc.getMap().plot(123, 2).setRevealed(iCiv, False, True, -1);If you have several Workboast on the same tile you can use:
Code:
pPlot = cyMap.plot(x, y)
iNumUnits = pPlot.getNumUnits()
for i in range(iNumUnits):
pCurrentUnit = pPlot.getUnit(i)
eOwner = pCurrentUnit.getOwner()
pCurrentUnit.kill(False, eOwner)no, they're all on separate plots so the civs don't make contact with each other while waiting.
I need to go back after I do the colony spawns and see if it's even necessary. I just remembered that later civs start with partially revealed maps (each one custom), and their boat locations are designed to be in or near to that, so it may not be necessary at all...
but I'll definitely take a cruise thru the code when I get back from my trip to Connecticut this weekend.
Next week is going to be a busy week for me...not much time to play around with civ. If I can get the colonies done on Sunday when I get back, that might be just they way to have it done this week!
I need to go back after I do the colony spawns and see if it's even necessary. I just remembered that later civs start with partially revealed maps (each one custom), and their boat locations are designed to be in or near to that, so it may not be necessary at all...
but I'll definitely take a cruise thru the code when I get back from my trip to Connecticut this weekend.
Next week is going to be a busy week for me...not much time to play around with civ. If I can get the colonies done on Sunday when I get back, that might be just they way to have it done this week!
also, I would not be averse to including "signs" to mark the future spawn points of later civs, provided there was a way within python to remove those signs after the spawn. I'll be looking into that, too, but if anyone knows how offhand and wants to give some hints it'd be appreciated.
oh, one more thing...as I spawn the colonies, I'd like to spawn a missionary of whatever the civ's religion is. I think I can reasonably predict what they'd be, but I'd rather allow for a human player to pick something wildly different. How can I determine a player's religion and then spawn the appropriate unit? I have an idea, but (as ususal) it won't be pretty...
alright, I've defined these with the mod constants:
#triggers for colony spawns tied to Astronomy
bArabiaTriggered = True
bEnglandTriggered = True
bFranceTriggered = True
bSpainTriggered = True
bRussiaTriggered = True
but it complains that bEnglandTriggered is referenced before assignment. I need to make sure that each of these only triggers for each of these civs once. What am I doing wrong?
#triggers for colony spawns tied to Astronomy
bArabiaTriggered = True
bEnglandTriggered = True
bFranceTriggered = True
bSpainTriggered = True
bRussiaTriggered = True
but it complains that bEnglandTriggered is referenced before assignment. I need to make sure that each of these only triggers for each of these civs once. What am I doing wrong?
Spoiler :
hm...none of this is working. I think I have the wrong idea with looking to see if they have the tech as well. I just can't figure out how to get the game to look and see onTechAcquired which tech was acquired. I mean, if I could get it to look onTechAcquired and see if tech=astronomy AND activeplayer=england that would do it, and it could only be done once per game per named civ.
But I don't see anything like that in the api
But I don't see anything like that in the api
