Unofficial BTS 3.13 patch

[Refar]

Interesting.

I find the Partisans Event most annoying myself, i was assumig however, that it is working as intended... Now if this is a bug it mght actually get fixed at some point

 

[Jaybe]

Another way to "fix" the partisans event is to make it NOT require Emancipation!
Then there is no problem with it.

 

[Bhruic]

I've modified the necessary Python file to fix that bug, but I haven't had the opportunity to test it yet - it's been a busy December.

Bh

 

[DrJambo]

One other thing - I noticed I haven't had any quest events for several games. Has this unofficial patch accidentally affected quests at all?

Bhruic, your tweak for the demographics screen doesn't work properly, even with the extra part you noted. I think it will need some proper testing by those who're knowledgeable in python.

 

[jkp1187]

One other thing - I noticed I haven't had any quest events for several games. Has this unofficial patch accidentally affected quests at all?

No, it hasn't. I've seen them plenty of times in game, and have no trouble forcing events to trigger using the Python console.

 

[smacfan]

Well, you'll note that the original was:

fGroupImpExpRatio = 1 / (1.0 * iTempExports)

That's functionally equivalent to:

fGroupImpExpRatio = 1 / iTempExports

I assume they added the "1.0" part because otherwise the result would return an integer instead of a floating point. So you might need to change the line to:

fGroupImpExpRatio = iTempExports / 1.0

for it to work correctly.

Bh

Hi there, first post for me here on Civfanatics, though I've been a lurker for quite a while.

I think the code change you provided misses one more needed change in that section of code. May I suggest it be changed to this:

# Post-3.13 Patch fix - Reverse ratio to Exports/Imports               
if (iTempExports > 0):                                                 
	if (iTempImports == 0):                                        
		fGroupImpExpRatio = 1.0 * iTempExports                 
		afGroupImpExpRatio.append(fGroupImpExpRatio)           
	else:                                                          
		fGroupImpExpRatio = iTempExports / (1.0 * iTempImports)
		afGroupImpExpRatio.append(fGroupImpExpRatio)           
else:                                                                  
	# Make ratio 1 when both imports and exports are 0             
	if (iTempImports == 0):                                        
		fGroupImpExpRatio = 1.0                                
		afGroupImpExpRatio.append(fGroupImpExpRatio)           
	else:                                                          
		fGroupImpExpRatio = 1 / (1.0 * iTempImports)           
		afGroupImpExpRatio.append(fGroupImpExpRatio)

I suggest an additional change in the final else to reverse the ratio when exports are zero and the "1.0 *" in the first change to force a floating-point result.

Note: Untested, I have just installed BtS+3.13+Unofficial-3.13 and don't have a game with trade routes active in which to test it.

HTH

smacfan

 

[Seven05]

Instead of doing things like ... * 1.0 or 1.0 * ... to be propper you should consider using something like:

((float) iTempExports)

That way you leave no doubt as to what your intentions are

 

[mamba]

Well, you'll note that the original was:

fGroupImpExpRatio = 1 / (1.0 * iTempExports)

That's functionally equivalent to:

fGroupImpExpRatio = 1 / iTempExports

I assume they added the "1.0" part because otherwise the result would return an integer instead of a floating point. So you might need to change the line to:

fGroupImpExpRatio = iTempExports / 1.0

for it to work correctly.

Bh

1 / x is not the same as x / 1.0 (unless x = 1 ), so your last formula is not returning the same results as the first two (1.0 / x would).

 

[Todd Hawks]

1 / x is not the same as x / 1.0 (unless x = 1 ), so your last formula is not returning the same results as the first two (1.0 / x would).

... which is the point of the modification. I suggest you read the discussion again.

 

[DrJambo]

smacfan,

I tried yours and the demographics screen is still returning a rank of 0 for my civ.

 

[Aro]

How should I install this on my steam version of BtS?

 

[plesniak]

For some reason I am unable to attack Mansa. It puzzles me.

Check out the save...on second thought don't bother!!

Too much Pre-New Years cheer.



http://forums.civfanatics.com/uploads/102845/Worterror_AD-1828_cant_attack.CivBeyondSwordSave

 

[ggganz]

Wow. O_O That looks like a bug to me. He refuses to talk to you, and so you should have no deals with him, which you don't, but it acts like you have Open Borders with him.

Okay, now I attacked a rifleman in one of Mansa's cities (Awlil) and you're still not at war with him. MAJOR bug.

EDIT: Wait a minute, it says "This war spoils our relationship" which means you ARE at war... by any chance do you also have BUG installed? Because apparently BUG doesn't show the civs you are at war with. I'll bring that up in BUG Forum for ya!

 

[Woody1]

I don't see anything wrong with that game you show in your savefile. You're at war with Mansa. I moved up some of your units and attacked him just fine. What's the problem?

 

[Todd Hawks]

Uhm, hate to play Captain Obvious here again, but evidently he noticed himself that nothing was wrong (hence the edit about "not bothering on second thought" and "I am mistaken"). Doesn't anyone read anymore around here?

 

[ggganz]

Please point me to where it says "I am mistaken".

 

[mamba]

Please point me to where it says "I am mistaken".

I guess he spelled it like this

Too much Pre-New Years cheer.

 

[ggganz]

Okay, we get it. Plesniak wasn't paying attention and didn't know he was at war with Mansa already.
E
N
D

O
F

D
I
S
C
U
S
S
I
O
N
!!!!!!!!!!!!
!

 

[Todd Hawks]

He said "I am mistaken" right where it says "Last edited by blah.... Reason: I am mistaken". The fine print. Right at the bottom.

Now I'd rather discuss the new version that Bhruic has been working on for two months now but as long as it's not out it's no wonder this thread mostly consists of irrelevant ramblings and "oh, I don't know how to install it even though it has been explained a dozen times already in this thread (not to mention the readme), help me!!!!!1111"

 

[ggganz]

Jeez, no support for the newbies. There's 77 pages, the search button is not really noticable unless you're looking for it. You're being a little harsh.
And you used wrong.