UP: DoubleWorkSpeed Promotion

[Mentos]

Can you move the PROMOTION_DOUBLE_WORK_SPEED promotion from CiVUP to the TBC part, please?

The promotion definition is in CiVUP while the text is in TBC/Leaders/Text. Spits out unnecessary invalid reference errors in database.log if you use CiVUP without TBC.

 

[Thalassicus]

Thanks for pointing this out.

I organize things like this:

• CiVUP defines how new effects work.
• TBC alters gameplay by giving the effect to units/leaders/etc.

In this case the definition was split in two places, so I've moved it entirely to CiVUP.

In computer programming it's like writing a class to accomplish a task, including the class in a library of useful stuff, then using classes from that library.

 

[Mentos]

Yeah, okay, I get it with your core stuff in CiVUP where you create new tables and such.

However, what has this gameplay-change "Double Work Speed" to do with core library or vanilla fixing? It’s basically only an icon showing your balance change of TBC. It only wastes one available promotion slot for those who like to use CiVUP together with own mods but not TBC. Oh well, no big deal so far.

 

[Thalassicus]

The problem there is a vanilla game bug, and doesn't affect this mod directly, so I prioritize keeping things organized.