9.18 Courthouse bug

[Txurce]

One of my puppet cities built a courthouse while puppeted, but the city still says it is puppeted (and I can't build another one).

Edit: it took one turn for a courthouse that I bought to register.

 

[Thalassicus]

1) That's very puzzling. Was your puppet previously the puppet of another leader, or was it a normal city when you captured it? I looked over my code for courthouses and haven't spotted the logic mistake yet, though obviously there is one somewhere. There are three things working together:

• Courthouses require a hidden AI_GOVERNOR building.
• I place this building in the puppet cities of non-human players. The building is destroyed on city capture.
• Humans can always build courthouses in occupied cities.

2) I manually do the courthouse effect (to fix the vanilla +3 for courthouses bug). It currently updates at the end of the turn. It's difficult to get it to update immediately when the player purchases, and the two methods have similar effects on gameplay (exception: very unhappy combat penalty), so that's currently a low priority. I do plan on finishing it before releasing the beta to the public.

 

[Txurce]

1. That's very puzzling. Was your puppet previously the puppet of another leader, or was it a normal city when you captured it?
   .
2. I manually do the courthouse effect, so currently it updates at the end of the turn. It's difficult to get it to update immediately when the player purchases, and the two methods have similar effects on gameplay (exception: very unhappy combat penalty), so that's currently a low priority. I do plan on finishing it before releasing the beta to the public.

I looked over my code for courthouses and haven't spotted the logic mistake yet. There are three things working together:

• Courthouses require a hidden AI_GOVERNOR building.
• I place this building in the puppet cities of non-human players.
• Humans can always build courthouses in occupied cities.

That makes sense regarding the second city.

The first city was owned by the original builder, and had never been captured before. On the next city I take, I'll give the puppet a chance to build the courthouse again before occupying. It may well be just a freak thing, because....

I just checked and it's normal now. Maybe my morning reload did it.

 

[Thalassicus]

The strange thing is it should be impossible for human-owned puppets to even attempt to build a courthouse - our cities should never have the GOVERNOR_AI building. If you have an autosave of a turn shortly before your puppet built the courthouse, that would help! Attach it in a zip with your mods, cache, and moduserdata folders.

 

[Txurce]

The strange thing is it should be impossible for human-owned puppets to even attempt to build a courthouse. If you have an autosave of a turn shortly before your puppet built the courthouse, that would help! Attach it in a zip with your mods, cache, and moduserdata folders.

Unfortunately, it's history - I didn't think fast enough. If it happens again, I will.

 

[Tids]

I seem to have had a similar problem. After trying to get my happiness down by annexing cities and then purchasing courthouses, i found that courthouses were built in most of all of my puppet cities after i had annexed them (not sure about before). Once annexed, even with the courthouse, the was still present. Didn't help that i was at war with everyone at the same time...

 

[Thalassicus]

A savegame is the easiest way to track down this particular problem, so I can figure out how the puppets are building courthouses.

 

[Tids]

Ok, a courthouse is about to undergo construction in Almaty on the next turn (on the island bit)

Only playing with info addict and VE

 

[Thalassicus]

I believe I've found and fixed the problem for beta .14

 

[Beelzibub]

The problem still isn't 100%fixed.I'm only a little way into a new game with .14 beta and in the first city I took, I occupied it and rush bought a courthouse and the city is still classed as occupied until the following turn. This shouldn't be a major problem but I just thought I'd mention it.

Also I'd like to complain about the amount of hours this mod has stolen from me in the last couple of weeks

 

[Thalassicus]

I meant to say I fixed the puppet problem. That one was easy - immediately recognizing new courthouses will be harder, but on my todo list.

 

[Beelzibub]

good stuff. Also good work in releasing about 5 new versions in as many days

 

[Thalassicus]

When doing beta testing I just release any stable version I have, as a work in progress, since helps catch unknown bugs quicker.