Archids Slavery Mod

Archid · Oct 10, 2012

You have the int CvGlobals::getDefineINT(const char *,const int) const method defined twice:

Line 1288 from Better BTS AI
Line 1382 from Slavery, which I copied from Better BTS AI

The cure is to remove line 1382 introduced by the Slavery mod:
int getDefineINT( const char * szName, const int iDefault ) const; // From Better BTS AI - jdog5000

Lib.Spi't · Oct 10, 2012

Yeah there were a few files where I struggled with the merging. Here is an example of the next problem, I have screwed something up in CvCity files and you know what they say, "Go big or go home" so with this screw up I went big :-D

I attached the city files. Again....Thanks :-D

Spoiler :

Archid · Oct 10, 2012

You are missing a block of code...

The indentation of my code is out by an extra tab which won't have helped here...I'll fix that in my next planned update

Spoiler :

Lib.Spi't · Oct 11, 2012

cool I shall try and get that found and added :-D

I am so glad you are helping me with this I never would have figured this out on my own hehe

ok fixed that :-D My failures are getting bigger with each file

that is growth right??
next up game text manager 104 errors!!!

Spoiler :

Archid · Oct 11, 2012

You are missing a closing brace in parseCivicInfo

Search for TXT_KEY_CIVIC_MILITARY_SUPPORT_COSTS to jump there

Spoiler :

In general when you get a local function definitions are illegal error it means you have problems with the braces in the file. To identify where in VC++ 2008 look for the first of the methods mentioned in the error log, which in you case was:

Code:

1>CvGameTextMgr.cpp(7823) : error C2601: 'CvGameTextMgr::setTechHelp' : local function definitions are illegal

The format of an output error message can be interpreted as:
<Filename> (<line number>) : <error code>: <error details>

The error for you was therefore on line 7823, which is the CvGameTextMgr::setTechHelp method.

As local function definitions are illegal errors mean that you are missing a closing brace it is something just above this line. So you need to look at the method above and work out which block is not closed properly. The outlining feature in VC++ is your friend here. I suggest you have a quick read up on how to use it as it can collapse all the blocks in a method to show you the one that isn't closed as you expect.

Lib.Spi't · Oct 11, 2012

Cool that is really helpful, I started to learn how to address some of the error messages the last time I tried a big build, but it was a few months ago and I have mostly forgotten what I was able to learn!

Lib.Spi't · Oct 11, 2012

Am I right in thinking that these issues are not with the .cpp file but with the .h file as this is an undeclared identifier?

Spoiler :

Lib.Spi't · Oct 11, 2012

This is the code that the first error is refering to:

Code:

												case UNITAI_SLAVE:
													iUnitValue += 400;
													break;

												// Slavers have value in both peace and war
												case UNITAI_SLAVER:
													iMilitaryValue += ((bWarPlan) ? 600 : 300);
													iMilitaryValue += (AI_isDoStrategy(AI_STRATEGY_DAGGER ) ? 800 : 0);
													iUnitValue += ((!bCapitalAlone) ? 400 : 100);
													break;
/**
 ** End: Slavery
 **/
				case UNITAI_ATTACK:
					iOffenceValue = std::max(iOffenceValue, (bWarPlan ? 7 : 4)*iWeight + (AI_isDoStrategy(AI_STRATEGY_DAGGER) ? 5*iWeight : 0));
					iTotalUnitValue += 1*iWeight;
					break;

could it be the extra indentations that are causing the issue?

I located the second set of errors too, I am just not sure what the errors mean and what exactly to do to fix them, I don't want to go back to random changing in case I make it worse :-D

Sorry for being a pain I really do appreciate your help on this :-D This mod comp will be great for my mod! :-D

Archid · Oct 11, 2012

Sometimes...

Most of the variables that are defined in the .h files will begin with m_ to indicate that they have modular scope, which means they can be referenced anywhere in the cpp file. The compiler doesn't care though so its not a hard and fast rule, but most, not all, of the code that I have seen floating around for Civ IV follows the convention. If the prefix is not there I tend to look in the method that the error occurs first.

Looking at the names of the variables: iUnitValue & iMilitaryValue I would supect are temporary variables to keep track of a number before it is used so would be defined in the method. The pLoopUnit I wouls say is very highly likely to be defined in the method in the cpp file as loop variables tend to be very temporary in scope and this should probably be defined right above where it is set.

Archid · Oct 11, 2012

Lib.Spi't said:
could it be the extra indentations that are causing the issue?

Whitespace (tabs, spaces, carriage returns, etc) are totally ignored by the compiler and are only used to make it easier for us mere mortals to read the code.

Your line numbers don't match up with my code and the place where I have that piece of code doesn't look to be the same place. I would need to see your source files again to try and work out what is wrong, but I suspect that the whole Slavery block of code is in the wrong place in the file.

Lib.Spi't · Oct 11, 2012

Yeah there were a few files where the code just seemed completely different and winmerger could not handle it so I was mostly using guess work to try and find where it might need to go..

Archid · Oct 11, 2012

I see the problem, the K mod totally changes the AI routines and weighting strategy.
You had put the code in the right places, it just needed adjusting to match the variable names used by the K mod. I have updated the AI values as well so the weighting used should be balanced with the surrounding code.

The first block of code around line 6457 should be changed to this:

Spoiler :

The second block of code around line 23258 should be:

Spoiler :

This code may need tweaking, but I think it should compile and is pretty much inline with the AI values around it.

Lib.Spi't · Oct 11, 2012

Spoiler :

Oh man I thought we had it that time, I think this is another code compatibility issue..

I can't thankyou enough for your help on this mate, other wise it would just be another fail on a long list.

If you ever need any custom voice work for your mod, say the word and I am on it!

Archid · Oct 11, 2012

There are a few changes that need to be made in this file so instead of listing them I have attached the updated file. You can use WinDiff to see what I have done.

Its not easy merging SDK mods when the target has been extensively modified from the core. It is good to see that the mod is getting some use and it would require a lot more helping others before I come close to giving back what I have taken from this forum.

Lib.Spi't · Oct 11, 2012

Me Again! :-D
Only 4 errors this time! and I got through 2! Whole files without there being an issue! WOW!!

Spoiler :

Yeah I really wanted to have BUG in my mod, just because it is awesome

and I miss it in all the mods that I play without it now hehe

I know what you mean about the community here, everyone I have talked to is really helpful, and I think I have had only one troll since joining

I really think this slave mod is going to be a real stand out piece of my fallout mod though, I was going to make slaves much more basic, and just have them as a specialist, but this really makes it more involved and interesting and opens up some more interesting choices and play.

Especially since an entire faction is called the raiders and slavers! Will be nice to have some actual slavers running around

Archid · Oct 11, 2012

The first error here indicates the AI_getOurPlotStrength method is missing from CvPlayerAI which is odd as this method is in the base BTS 3.19 code and not anything I have added. Is this something else that the K mod has changed?

Lib.Spi't · Oct 11, 2012

it could well be yeah, K-mod deals mostly with AI improvements, so any thing AI files have probably changed in one way or another, I did a quick skim trhough searching AI_get, but it didn't seem to turn much up, the only 'plot' related one I found was getplotdanger which was to do with keeping workers off the front lines.

I've attached the playerAI files, just in case you have a better idea of what/where you are looking for it.

Yeah that section of code seems to have been removed, but as yet I cannot figure out what replaced it, the code above and below it is still there, but there is nothing 'in between' them now? I am still looking..

I will see if I can contact karadoc as well to see if he can help us unravel the mystery!

Lib.Spi't · Oct 20, 2012

Hi, here is the file for you to have a look at, I can't see anything wrong with it, but you may see something I missed.

Archids Slavery Mod

Warlord

Overlord of the Wasteland

Attachments

Warlord

Overlord of the Wasteland

Attachments

Warlord

Overlord of the Wasteland

Overlord of the Wasteland

Overlord of the Wasteland

Warlord

Warlord

Overlord of the Wasteland

Attachments

Warlord

Overlord of the Wasteland

Attachments

Warlord

Attachments

Overlord of the Wasteland

Attachments

Warlord

Overlord of the Wasteland

Attachments

Overlord of the Wasteland

Attachments

Similar threads