[GS] Basilikoi does not grant +25% XP

[Litcube]

Basilikoi XP function is broken (bug). It does not grant additional XP earned when units are made there, despite the description and the attempt in the xml data.

I tested it, same experience for both units (one built in Basilikoi).

I then tried a Barracks, and the Barracks works as expected.

Can someone take a look and help me fix it?

 

[Litcube]

Fairly certain I fixed it. The Macedonian ability modifier is thusly in Macedonia_Persia_GameplayData.xml:

<ModifierType>MODIFIER_CITY_TRAINED_UNITS_ADJUST_XP_BONUS</ModifierType>

It should be:


<ModifierType>MODIFIER_PLAYER_UNIT_ADJUST_UNIT_EXPERIENCE_MODIFIER</ModifierType>

I think! It seems to work.

 

[Myomoto]

I imagine this has been a bug since the release of the DLC, like what, 4 years ago?

Boy... this game

 

[Linklite]

Has this been reported as a bug? It's not going to be fixed otherwise.

 

[AntSou]

I imagine this has been a bug since the release of the DLC, like what, 4 years ago?

Boy... this game

You're saying that a bug in a basic feature of one of the Civs has existed since its release and nobody ever noticed?

I've played Alexander once.

I tested it, same experience for both units (one built in Basilikoi).

I then tried a Barracks, and the Barracks works as expected.

Can someone take a look and help me fix it?

Can you be more specific? How exactly did you try the Barracks if it is made unavailable when playing Alexander?

Are you certain mods aren't involved?

I'll check it and post here in a bit.
---

Edit: Weird. I just checked with Firetuner on. The Basilikoi didn't seem to make a difference.

Not only that, when I switched to a different Civ using Firetuner, the Barracks did not seem to have any impact on EXP.

I'm now testing Barracks as Human Player.

 

[AntSou]

Here's the result I got (sorry it looks a bit rough):

Spoiler :

1st - None of the units trained in the Basilikoi gained any extra EXP
2nd - AI units didn't seem to gain any extra EXP from Barracks (8XP from Deity. Could it be Firetuner shenanigans though?)
3rd - Barracks seemed to work fine when playing as Human Player.


----
Also, spearman gets the Basilikoi text in the UI even though the building reads:

I'm assuming this was already known? It's a bit too obvious not to. The fandom page includes anti-cav.

 

[AntSou]

I checked again in Standard Speed. Basilikoi makes no difference:

----

There's something else though. The October Update Patch Notes read:

But Quick granted me 4XP, Standard 5XP.

What am I misunderstanding here? Total EXP needed does not scale but EXP gained does?

 

[Litcube]

<Row Type="ABILITY_BASILIKOI_TRAINED_UNIT_XP" Tag="CLASS_ANTI_CAVALRY"/>

Yup, it's in there for spearmen.

 

[Myomoto]

Sorry to go off topic, but I just managed to seemingly get 100 gold with the Public Transportation policy slotted when replacing a farm with a neighborhood. You know, the policy that was specifically just changed NOT to do that anymore?

You're saying that a bug in a basic feature of one of the Civs has existed since its release and nobody ever noticed?

I've played Alexander once.

I've personally never finished a game with Alex. I'm not surprised this kind of thing can go unnoticed in a game with 40+ odd civs, and an average game takes 10+ hours to finish playing one of them.

 

[Laurana Kanan]

Fairly certain I fixed it. The Macedonian ability modifier is thusly in Macedonia_Persia_GameplayData.xml:

<ModifierType>MODIFIER_CITY_TRAINED_UNITS_ADJUST_XP_BONUS</ModifierType>

It should be:


<ModifierType>MODIFIER_PLAYER_UNIT_ADJUST_UNIT_EXPERIENCE_MODIFIER</ModifierType>

I think! It seems to work.

The only difference between those two Mod Types is the Collection Type used. The former uses "COLLECTION_CITY_TRAINED_UNITS" and the latter "COLLECTION_OWNER" - the Effect Type is the same on both, however. The only other modifier that uses the City Trained Mod Type is the one used for the Ordu. Makes me wonder if it's bugged as well, if someone wants to test it. I know I had some issues utilizing "COLLECTION_CITY_TRAINED_UNITS" in one of my mods recently so there may be an issue there. Now why FXS decided to define a new Mod Type when there was one that already worked perfectly well is anyone's guess.