BNW APIi?

[Mewr11]

Looking through the civ 5 modiki, I can't find anything that looks to have been added with BNW. Is there anywhere where I can find whatever new lua functions/events that have to do with tourism, if they exist?

 

[DJSHenninger]

1. http://forums.civfanatics.com/showthread.php?t=500747

2. http://forums.civfanatics.com/showthread.php?t=537056

Don't know if there's more. Would like to know as well.

 

[LeeS]

So far as I'm aware that covers everything changed/added.

 

[Mewr11]

Do either of you know what JONS culture is? I've seen it a few times, but can't figure out what it represents.

 

[LeeS]

It refers to culture.

JONS = Jon Sheaffer (not sure I spelled it right), the original lead developer of CIV5. When Firaxis released the original version of the game, they never went back through the code to remove all the JONSThis and JONSThat from the code.

Whenever you see JONSThis or JONSThat in the API, just mentally remove the 'JONS' part to figure out to what it is referring. In order to actually use those methods in your code, though, you have to remember to repeat the name in the API exactly as shown. So, we don't state pPlayer:ChangeCulture(14) in our lua programs, we state pPlayer:ChangeJONSCulture(14)

 

[ThorHammerz]

It refers to culture.

JONS = Jon Shafer (not sure I spelled it right)

Fix'ed .

But what is truly, truly, astounding is why they wouldn't just hook up the damn existing "yieldfrombuildings"/"yieldfromterrain"/etc functions that were already being used by the original 4 yields (science/food/production/gold).

They even went so far as to create new columns in the Buildings table for % yield modifiers for culture (and did not bother to implement any equivalent functionality for Faith... i.e. %Faith bonus for the empire, or %Faith bonus for the city).

 

[Nutty]

But the modders did what Firaxis couldn't be bothered to do! See the Community Patch DLL for its unified yields (note the Community Balance Patch is independent from the DLL; the DLL on its own does nothing but some bugfixes until you activate the feature(s) you need).

 

[bouncymischa]

But what is truly, truly, astounding is why they wouldn't just hook up the damn existing "yieldfrombuildings"/"yieldfromterrain"/etc functions that were already being used by the original 4 yields (science/food/production/gold).

They even went so far as to create new columns in the Buildings table for % yield modifiers for culture (and did not bother to implement any equivalent functionality for Faith... i.e. %Faith bonus for the empire, or %Faith bonus for the city).

I always get flashbacks to an assignment I did back in my Computer Science days. It was a pretty straightforwards assignment -- create a UI for a digital alarm clock, I think -- and I completed about 90% of the functionality of the code using a set of standardized functions. However, as I was running out of the time at the end and trying to get the last 10% of functionality implemented, I kept running into problems trying to properly deprecate my functions. In the end, I distinctly recall writing spaghetti code that did things like have two separate functions that did the exact same things, but took different arguments, and so on.

The implementation of culture reeks of the same sort of spaghetti code, for me. I'm not sure if they were running out of time, or what, but I'm guessing that some aspect about the implementation of culture in the DLL meant that they couldn't make the standard functions used to modify science/production/whatever work with it in time, so instead made a bunch of separate (but working) functions instead.