city:ChangeBaseYieldRateFromBuildings() changes persist?

[Pazyryk]

I could have sworn that changes using this (and similar) methods did not persist, i.e., went away on save/exit/reload. But some testing I just did shows that this one is persisting. Did something change or was I wrong in my previous understanding?

 

[Hambil]

AFAIK all game data should persist without any effort on your part. It's only your variables you have to account for. After all, otherwise no game would ever be reloadable without huge amounts of save and restore code.

 

[Pazyryk]

Perhaps I'm confusing this with other changes that don't persist (unit:SetBaseCombatStrength???). I agree these all should persist, but I'm pretty sure that's not the case. I can work with it either way, but only if I know.

 

[whoward69]

All of the BaseYieldRates for a city are persisted - see CvCity.cpp - and apart from religion, all that code has been there since day/version 1 of the save format

	kStream << m_aiBaseYieldRateFromTerrain;
	kStream << m_aiBaseYieldRateFromBuildings;
	kStream << m_aiBaseYieldRateFromSpecialists;
	kStream << m_aiBaseYieldRateFromMisc;
	kStream << m_aiBaseYieldRateFromReligion;

 

[Pazyryk]

Thanks for the clarification. I think maybe I was remembering some issue from Civ4.