Diplomacy and Trade Logging

[EmperorFool]

So far I like the first version with all sections aligned into columns. It's only slightly difficult to see which items belong to which sections when looking at the right items.

Can you put a horizontal dividing line between each section? I think it might be too much and cause more scrolling than is necessary otherwise, but see how it looks.

 

[The Doc]

So far I like the first version with all sections aligned into columns. It's only slightly difficult to see which items belong to which sections when looking at the right items.

Can you put a horizontal dividing line between each section? I think it might be too much and cause more scrolling than is necessary otherwise, but see how it looks.

That's a good idea.
Here is a layout with 5 columns with a table for each section:

 

[EmperorFool]

The five column version definitely makes it easier to spot the separation between sections (long row, short row, long row, short row), but it works negatively as the last two sections look like a single section.

I think I'm still a fan of having all sections aligned into columns, though.

 

[The Doc]

5 column layout with dividing lines on the right:



Unfortunately, the labels don't align because the separators are only present at the right side of the table.

 

[EmperorFool]

Two problems with the dividing line due directly to the inability for a box to span columns: the labels no longer line up with the checkboxes (kills it for me) and the checkboxes cannot line up vertically across sections (not fatal).

I recommend to drop the dividing line and choose whether or not to line up the checkboxes across sections. Pick what you think looks best.

 

[The Doc]

Two problems with the dividing line due directly to the inability for a box to span columns: the labels no longer line up with the checkboxes (kills it for me) and the checkboxes cannot line up vertically across sections (not fatal).

I recommend to drop the dividing line and choose whether or not to line up the checkboxes across sections. Pick what you think looks best.

Is it possible to have a separator that doesn't display a dividing line? At least with tables the lines can be disabled.

 

[EmperorFool]

What would the separator do? I don't understand your question entirely. Do you mean just add a blank line? If so, use addSpacer(). You can see it used in most of the tabs for an example.

 

[The Doc]

What would the separator do? I don't understand your question entirely. Do you mean just add a blank line? If so, use addSpacer(). You can see it used in most of the tabs for an example.

I was thinking that I could add different separators on the left and right side of the table while one displays a dividing line and the other one doesn't. That way the labels could align with the items on the right without having to use a separator that is drawn across the whole screen.

 

[EmperorFool]

Ahh, good idea. However I don't know of such a beast. You could try a line on both sides and see if that's okay.

 

[Cammagno]

Layout with 4 columns over all items:

This is my favourite (even if I stll prefer a column layout with a compressed top part).

 

[The Doc]

This is my favourite (even if I stll prefer a column layout with a compressed top part).

It's the most compact layout but it's also a bit hard to recognize which option belongs to which label, IMHO.

Here's the last layout with separators on the left:

 

[EmperorFool]

I think that works fine.

Last suggestion from me (promise ): move the fourth items from the first three sections to the second row (make them 3 columns excluding the label column). It just looks a little weird to have a lone straggler (and two in the 2nd section), plus it leaves more room for long translations.

 

[The Doc]

No problem. I always appreciate your feedback and that of everyone else.

Take a look:

 

[EmperorFool]

I'm sold.

 

[Dresden]

Two bugs fixed regarding Vassal States. Note that a Vassalage offer generates a standard one-sided trade offer so it's parsed as a gift. I'd like to try and pick this out and give it special logging text but that should probably wait until after the release as it seems kinda tricky, especially since I don't have a "normal" gift offer to test it against.

Note: Names have been changed to protect the innocent

[u][b]Turn 209/750 (535 AD) [10-Oct-2008 18:10:12][/b][/u]
[color="Navy"]Diplomacy: Little Guy (TinyCiv) offers to become a vassal of Mr. Big (Superpower)[/color]
[color="Green"]Diplomacy: Mr. Big (Superpower) accepts gift of Vassal State (??? Turn) from Little Guy (TinyCiv)[/color]
[color="Red"]Little Guy (TinyCiv) declares war on Some Other Guy (Otherlandia)[/color]
[color="Red"]Little Guy becomes a Vassal State of Mr. Big[/color]

[u][b]Turn 209/750 (535 AD) [10-Oct-2008 18:18:12][/b][/u]
[color="Navy"]Diplomacy: Little Guy (TinyCiv) offers to become a vassal of Mr. Big (Superpower)[/color]
[color="Red"]Diplomacy: Mr. Big (Superpower) rejects gift of Vassal State (??? Turn) from Little Guy (TinyCiv)[/color]

 

[ruff_hi]

nice work - and nice substitution. I couldn't believe it when these two dialed me up and offered to become my vassal.

 

[Cammagno]

No problem. I always appreciate your feedback and that of everyone else.

Take a look:

I like it

But about the upper part, I'm still not satisfied about it's look, so I propose a new layout for it (less weird that my previous one ^_-)

IMHO it has a more rational division of options and, even more important, it uses 2 lines less

 

[Cammagno]

I like it

But about the upper part, I'm still not satisfied about it's look, so I propose a new layout for it (less weird that my previous one ^_-)

IMHO it has a more rational division of options and, even more important, it uses 2 lines less

Or maybe like this:

 

[The Doc]

I committed the new layout and did some minor changes on the upper half of the screen. Since there is a scroll bar anyway there is no need to squish everything together into three lines, IMHO.

 

[Dresden]

Another one bites the dust. Too bad we didn't have one of these before the release because it exposed not one, but two bugs. SVN commit soon to fix them.

Note this comes from the Noble's Club IV Saladin game and the image/text are a slight spoiler as they expose AI players.

AI offers me a free city after I dropped a nearby culture bomb:

Spoiler :

Autolog (denied):

Spoiler :

Turn 235/750 (900 AD) [25-Oct-2008 18:40:44]
Diplomacy: Suleiman (Ottomans) offers to give the city Kayseri to NCIV Saladin (Arabia)
Diplomacy: NCIV Saladin (Arabia) rejects gift of Kayseri from Suleiman (Ottomans)

Autolog (accepted):

Spoiler :

Turn 235/750 (900 AD) [25-Oct-2008 18:47:19]
Diplomacy: Suleiman (Ottomans) offers to give the city Kayseri to NCIV Saladin (Arabia)
Diplomacy: NCIV Saladin (Arabia) accepts gift of Kayseri from Suleiman (Ottomans)