Module depedency issuess

[raxo2222]

I ran debug DLL to check dependency issues.
I had to filter out dependencies, that were fine.

It appears 118 dependencies are wrongly defined.

Spoiler :

AND - Dependency not found, TYPE: PROMOTION_HEROIC2
TYPE: PROMOTION_HEROIC2, NOT LOADED

AND - Dependency not found, TYPE: PROMOTION_RAD_SHELLS
TYPE: PROMOTION_RAD_SHELLS, NOT LOADED

AND - Dependency not found, TYPE: PROMOTION_SNEAK
TYPE: PROMOTION_SNEAK, NOT LOADED

AND - Dependency not found, TYPE: PROMOTION_AN
TYPE: PROMOTION_AN, NOT LOADED

AND - Dependency not found, TYPE: PROMOTION_ENKI
TYPE: PROMOTION_ENKI, NOT LOADED

AND - Dependency not found, TYPE: PROMOTION_ENLIL
TYPE: PROMOTION_ENLIL, NOT LOADED

AND - Dependency not found, TYPE: PROMOTION_INANNA
TYPE: PROMOTION_INANNA, NOT LOADED

AND - Dependency not found, TYPE: PROMOTION_BUSHIDO
TYPE: PROMOTION_BUSHIDO, NOT LOADED

AND - Dependency not found, TYPE: PROMOTION_BUSHIDO1
TYPE: PROMOTION_BUSHIDO1, NOT LOADED

AND - Dependency not found, TYPE: PROMOTION_BUSHIDO2
TYPE: PROMOTION_BUSHIDO2, NOT LOADED

AND - Dependency not found, TYPE: PROMOTION_BUSHIDO3
TYPE: PROMOTION_BUSHIDO3, NOT LOADED

AND - Dependency not found, TYPE: PROMOTION_WIND_HORSE
TYPE: PROMOTION_WIND_HORSE, NOT LOADED

AND - Dependency not found, TYPE: PROMOTION_WIND_HORSE2
TYPE: PROMOTION_WIND_HORSE2, NOT LOADED

AND - Dependency not found, TYPE: PROMOTION_SLAVE
TYPE: PROMOTION_SLAVE, NOT LOADED

AND - Dependency not found, TYPE: PROMOTION_MARAUDER
TYPE: PROMOTION_MARAUDER, NOT LOADED

AND - Dependency not found, TYPE: PROMOTION_ONE_SHOT
TYPE: PROMOTION_ONE_SHOT, NOT LOADED

OR - Dependency not found, TYPE: UNITCOMBAT_BEHEMOTH_TANK
TYPE: PROMOTION_FUSION_CANNON, NOT LOADED

OR - Dependency not found, TYPE: UNITCOMBAT_BEHEMOTH_TANK
TYPE: PROMOTION_RAD_SHELLS, NOT LOADED

OR - Dependency not found, TYPE: UNITCOMBAT_BEHEMOTH_TANK
TYPE: PROMOTION_FUSION_SHELLS, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_NEMO_ACADEMY
TYPE: TRAIT_SEAFARING, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_NEMO_ACADEMY
TYPE: TRAIT_SEAFARING1, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_NEMO_ACADEMY
TYPE: TRAIT_SEAFARING, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_NEMO_ACADEMY
TYPE: TRAIT_SEAFARING1, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_CAVES
TYPE: BUILDING_CAVES, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_NARA
TYPE: BUILDING_NARA, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_SAN_MARCOS_CATHEDRAL
TYPE: BUILDING_SAN_MARCOS_CATHEDRAL, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_VATICAN_LIBRARY
TYPE: BUILDING_VATICAN_LIBRARY, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_CONFUCIAN_SCHOOL
TYPE: BUILDING_CONFUCIAN_SCHOOL, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_SOLOMON
TYPE: BUILDING_SOLOMON, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_AKSHARDHAM
TYPE: BUILDING_AKSHARDHAM, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_MEENAKSHI
TYPE: BUILDING_MEENAKSHI, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_BLUE_MOSQUE
TYPE: BUILDING_BLUE_MOSQUE, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_DESERT
TYPE: BUILDING_DESERT, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_SULTAN
TYPE: BUILDING_SULTAN, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_QUANZHEN
TYPE: BUILDING_QUANZHEN, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_WUDANG
TYPE: BUILDING_WUDANG, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_PTAH
TYPE: BUILDING_PTAH, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_TOTH
TYPE: BUILDING_TOTH, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_ERECTION
TYPE: BUILDING_ERECTION, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_FIDIAS
TYPE: BUILDING_FIDIAS, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_NECROMANTEION
TYPE: BUILDING_NECROMANTEION, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_PYRAMID_OF_THE_MOON
TYPE: BUILDING_PYRAMID_OF_THE_MOON, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_PYRAMID_OF_THE_SUN
TYPE: BUILDING_PYRAMID_OF_THE_SUN, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_NIMRUD_PALACE
TYPE: BUILDING_NIMRUD_PALACE, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_BEHISTUN_INSCRIPTION
TYPE: BUILDING_BEHISTUN_INSCRIPTION, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_PIR_E_NARAKI
TYPE: BUILDING_PIR_E_NARAKI, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_SETI_PIR
TYPE: BUILDING_SETI_PIR, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_AACHENCATHEDRAL
TYPE: BUILDING_AACHENCATHEDRAL, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_ALAMO
TYPE: BUILDING_ALAMO, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_ALAMUT
TYPE: BUILDING_ALAMUT, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_BAKER_STREET
TYPE: BUILDING_BAKER_STREET, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_BANK_OF_CHINA
TYPE: BUILDING_BANK_OF_CHINA, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_BAUHAUS
TYPE: BUILDING_BAUHAUS, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_BAYREUTH
TYPE: BUILDING_BAYREUTH, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_BERLIN_WALL
TYPE: BUILDING_BERLIN_WALL, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_BLARNEY
TYPE: BUILDING_BLARNEY, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_BURNINGMAN
TYPE: BUILDING_BURNINGMAN, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_CABARET_VOLTAIRE
TYPE: BUILDING_CABARET_VOLTAIRE, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_CAHOKIA
TYPE: BUILDING_CAHOKIA, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_COIT_TOWER
TYPE: BUILDING_COIT_TOWER, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_CRYSTAL_PALACE
TYPE: BUILDING_CRYSTAL_PALACE, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_DINO_PARK
TYPE: BUILDING_DINO_PARK, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_DISNEYLAND
TYPE: BUILDING_DISNEYLAND, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_ELCAMINODESANTIAGO
TYPE: BUILDING_ELCAMINODESANTIAGO, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_ELLIS_ISLAND
TYPE: BUILDING_ELLIS_ISLAND, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_ESCORIAL
TYPE: BUILDING_ESCORIAL, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_GIVERNY
TYPE: BUILDING_GIVERNY, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_GOLDEN_SPIKE
TYPE: BUILDING_GOLDEN_SPIKE, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_HILLTARA
TYPE: BUILDING_HILLTARA, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_HOUSE_OF_WISDOM
TYPE: BUILDING_HOUSE_OF_WISDOM, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_KENTUCKY_DERBY
TYPE: BUILDING_KENTUCKY_DERBY, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_KRAK_DES_CHEVS
TYPE: BUILDING_KRAK_DES_CHEVS, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_LAS_VEGAS_STRIP
TYPE: BUILDING_LAS_VEGAS_STRIP, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_LONDONEYE
TYPE: BUILDING_LONDONEYE, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_MADISON_AVENUE
TYPE: BUILDING_MADISON_AVENUE, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_MONTE_CARLO
TYPE: BUILDING_MONTE_CARLO, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_PALACE_SOV
TYPE: BUILDING_PALACE_SOV, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_PEARL_HARBOR
TYPE: BUILDING_PEARL_HARBOR, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_PERE_LACHAISE
TYPE: BUILDING_PERE_LACHAISE, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_PLEISTO_PARK
TYPE: BUILDING_PLEISTO_PARK, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_SCAPA_FLOW
TYPE: BUILDING_SCAPA_FLOW, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_SCARBOROUGH_FAIR
TYPE: BUILDING_SCARBOROUGH_FAIR, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_SERPENT_MOUND
TYPE: BUILDING_SERPENT_MOUND, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_SHAOLIN
TYPE: BUILDING_SHAOLIN, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_TROYES_FAIR
TYPE: BUILDING_TROYES_FAIR, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_WALK_OF_FAME
TYPE: BUILDING_WALK_OF_FAME, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_WARHOL_FACTORY
TYPE: BUILDING_WARHOL_FACTORY, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_WESTMINSTER
TYPE: BUILDING_WESTMINSTER, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_WOODSTOCK
TYPE: BUILDING_WOODSTOCK, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_YASNAYA_POLYANA
TYPE: BUILDING_YASNAYA_POLYANA, NOT LOADED

AND - Dependency not found, TYPE: BUILDINGCLASS_RHINO_MYTH
TYPE: BUILDING_RHINO_TRAINER, NOT LOADED

AND - Dependency not found, TYPE: LEADER_HIRAM
TYPE: LEADER_HIRAM, NOT LOADED

AND - Dependency not found, TYPE: LEADER_EARP
TYPE: LEADER_EARP, NOT LOADED

AND - Dependency not found, TYPE: LEADER_HIRAM
TYPE: LEADER_HIRAM, NOT LOADED

AND - Dependency not found, TYPE: LEADER_HOLLIDAY
TYPE: LEADER_HOLLIDAY, NOT LOADED

AND - Dependency not found, TYPE: LEADER_JAMES
TYPE: LEADER_JAMES, NOT LOADED

AND - Dependency not found, TYPE: LEADER_KELLY
TYPE: LEADER_KELLY, NOT LOADED

AND - Dependency not found, TYPE: LEADER_LEE
TYPE: LEADER_LEE, NOT LOADED

AND - Dependency not found, TYPE: LEADER_LONGSTREET
TYPE: LEADER_LONGSTREET, NOT LOADED

AND - Dependency not found, TYPE: LEADER_LOPEZ
TYPE: LEADER_LOPEZ, NOT LOADED

AND - Dependency not found, TYPE: LEADER_SA
TYPE: LEADER_SA, NOT LOADED

AND - Dependency not found, TYPE: LEADER_VARGAS
TYPE: LEADER_VARGAS, NOT LOADED

AND - Dependency not found, TYPE: LEADER_THUNDERBRD
TYPE: LEADER_THUNDERBRD, NOT LOADED

AND - Dependency not found, TYPE: LEADER_STRATEGYONLY
TYPE: LEADER_STRATEGYONLY, NOT LOADED

AND - Dependency not found, TYPE: LEADER_MR_AZURE
TYPE: LEADER_MR_AZURE, NOT LOADED

AND - Dependency not found, TYPE: LEADER_KOSHLING
TYPE: LEADER_KOSHLING, NOT LOADED

AND - Dependency not found, TYPE: LEADER_HYDROMANCERX
TYPE: LEADER_HYDROMANCERX, NOT LOADED

AND - Dependency not found, TYPE: LEADER_DANCING_HOSKULD
TYPE: LEADER_DANCING_HOSKULD, NOT LOADED

AND - Dependency not found, TYPE: LEADER_ALBERTS2
TYPE: LEADER_ALBERTS2, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_MALAYIAN_TAPIR_STORY
TYPE: UNIT_BARD, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_MALAYIAN_TAPIR_STORY
AND - Dependency not found, TYPE: BUILDING_MALAYIAN_TAPIR_STORY
TYPE: UNIT_ENTERTAINER, NOT LOADED

AND - Dependency not found, TYPE: BUILDING_MALAYIAN_TAPIR_STORY
AND - Dependency not found, TYPE: BUILDING_MALAYIAN_TAPIR_STORIES
TYPE: UNIT_CELEBRITY, NOT LOADED

AND - Dependency not found, TYPE: UNIT_SUBDUED_RHINO
TYPE: UNIT_SUBDUED_RHINO, NOT LOADED

For example Nara's Giant Buddha is meant to get Tourism:

 <BuildingInfo>
            <Type>BUILDING_NARA</Type>
            <AndDependencyTypes>
                <DependencyType>BUILDING_NARA</DependencyType>
            </AndDependencyTypes>
            <PropertyManipulators>
                <PropertySource>
                    <PropertySourceType>PROPERTYSOURCE_CONSTANT</PropertySourceType>
                    <PropertyType>PROPERTY_TOURISM</PropertyType>
                    <iAmountPerTurn>8</iAmountPerTurn>
                </PropertySource>
            </PropertyManipulators>
        </BuildingInfo>

But it isn't.

Spoiler :

Easy way to fix these would be moving out these defined dependencies, so they would be always loaded last.
Depedency is override, so in those cases entries weren't overridden.

 

[KaTiON_PT]

Go ahead and move the tourist property to the building define, they are no different that disease or crime properties.

 

[raxo2222]

Well these load before module stuff, I'm moving these to depedencies module, so they would always load after thing, that they try to override.

Some stuff could be safely integrated, other would need to remain in module, since thing could be overriding something in other module.

So I just move these problematic depedencies to module, that is designed to load last or almost last.

 

[Thunderbrd]

           <Type>BUILDING_NARA</Type>
            <AndDependencyTypes>
                <DependencyType>BUILDING_NARA</DependencyType>

It's wanting to make sure that it's already in the game before it allows itself to be in the game. This is where Building Class does not translate the same as Building type.

 

[raxo2222]

           <Type>BUILDING_NARA</Type>
            <AndDependencyTypes>
                <DependencyType>BUILDING_NARA</DependencyType>

It's wanting to make sure that it's already in the game before it allows itself to be in the game. This is where Building Class does not translate the same as Building type.

I know.
But either it tried to override thing before thing itself was here, that thing didn't exist anymore, or thing was disabled/unused.

For example tourism properties (they exist as and dependency override) never inserted themselves on buildings in modules.
Or there were promotion/combat class modifications, that didn't exist at all.

Also dependency override of seafaring trait on Nemo Academmy (module building) wasn't working no matter what I did.

There were depedencyType>Era_.... which were extremely useless to have.
Nara building now has tourism.

Spoiler :

 

[Thunderbrd]

I know.
But either it tried to override thing before thing itself was here, that thing didn't exist anymore, or thing was disabled/unused.

For example tourism properties (they exist as and dependency override) never inserted themselves on buildings in modules.
Or there were promotion/combat class modifications, that didn't exist at all.

Also dependency override of seafaring trait on Nemo Academmy (module building) wasn't working no matter what I did.

There were depedencyType>Era_.... which were extremely useless to have.
Nara building now has tourism.

Spoiler :

View attachment 530905

Am I understanding that what you're saying is you're just removing these dependancy XML tags?

 

[Toffer90]

I've seen some strange uses of the dependency tags, I always ignored it as it didn't seem to cause serious issues and because I'm not a big fan of modules in general.

Am I understanding that what you're saying is you're just removing these dependancy XML tags?

He moved them to a file that is loaded after what they depend on is loaded.

I presume he removed some that were nonsensical too, like depending on an era existing in the game, no eras are modularized so one should assume they exist. ^^

 

[raxo2222]

Am I understanding that what you're saying is you're just removing these dependancy XML tags?

Nope, I moved entries with dependency tags inside to module, so those depedencies would be loaded last, if there was depedency not found error in XmlDependencyTypes.xml

So it meant some promotions were moved, and I simply moved whole tourism building infos to module.
That's because some promotions and buildings couldn't be overridden from core.

 

[raxo2222]

I presume he removed some that were nonsensical too, like depending on an era existing in the game, no eras are modularized so one should assume they exist. ^^

I could remove all bonus depedencies, and merge property/capture dependencies with buildings/promotions too.

 

[Thunderbrd]

I presume he removed some that were nonsensical too, like depending on an era existing in the game, no eras are modularized so one should assume they exist. ^^

I think there were some efforts to make some modding efforts compatible with more than C2C taking place in some of these cases. Not saying I'm worried about that myself. Just sayin' that might be why an era might have been a dependency.

So it meant some promotions, and I simply moved whole tourism building infos to module.

Some of this was probably best to just merge onto the core object instead of keeping fractured. This would've been a relic of when tourism was a modularized option. I don't think it is anymore, is it? If people want it to be optional then we COULD modularize the whole thing, but I'd urge us to make a choice and stick to it.

Out of curiosity, how modularized IS Tourism throughout the whole mod? Is it possible that we could just turn it off with an MLM bool as it stands now and how close would we be to being able to make that possible?

Many of these items may be presenting the same question of whether to just adapt it fully or modularize fully but is useless to keep in this status that benefits neither.

 

[raxo2222]

I think there were some efforts to make some modding efforts compatible with more than C2C taking place in some of these cases. Not saying I'm worried about that myself. Just sayin' that might be why an era might have been a dependency.

Some of this was probably best to just merge onto the core object instead of keeping fractured. This would've been a relic of when tourism was a modularized option. I don't think it is anymore, is it? If people want it to be optional then we COULD modularize the whole thing, but I'd urge us to make a choice and stick to it.

Out of curiosity, how modularized IS Tourism throughout the whole mod? Is it possible that we could just turn it off with an MLM bool as it stands now and how close would we be to being able to make that possible?

Many of these items may be presenting the same question of whether to just adapt it fully or modularize fully but is useless to keep in this status that benefits neither.

Era/tech dependencies were extremely arbitrary.
I merged all promotion related dependencies (mostly capture tag, few of them did other stuff too).

Now I'm merging tourism property depedencies into buildings.

 

[Anq]

/************************************************************************************************/
/* MODULAR_LOADING_CONTROL 02/20/08 MRGENIE */
/* */
/* If a Type is dependent on it's existence(i.e. a modder adds something to an existing */
/* Type but doesn't want to actual initialize it in case the Type didn't exist previously) */
/* this check here makes sure that the file will be skipped then and not used to create the */
/* object */
/************************************************************************************************/

I suppose the dependency tags are meant to withhold an object from being loaded if the respective module has been inactivated.
This means self-dependencies are pointless. A Big Cat module should never declare dependency on itself. Inter-dependencies like mammoth workers dependent on Andean religion to build Machu Picchu are what this system is for, isn't it?

Dependency on a core definition is also unnecessary.

 

[Toffer90]

I suppose the dependency tags are meant to withhold an object from being loaded if the respective module has been inactivated.
This means self-dependencies are pointless. A Big Cat module should never declare dependency on itself. Inter-dependencies like mammoth workers dependent on Andean religion to build Machu Picchu are what this system is for, isn't it?

Yeah, it's meant to tie different modules together, since one of them may be disabled the other needs to use dependency tags to tie it to the other.

If the depndancy entry between two modules are in a third module, then it may actually be nessesarry for it to have dependency upon itself in some cases, just incase the module that contains the base entry of itself has been disabled but not the other module that it's supposed to tie it together with.

Module A, B and C.
C only add A references into entries in B.
If C and A is active then the stuff that should be added to entries in B must then depend on itself to exist as well as the entries it reference in A to exist.
C would of course need to be loaded last.

 

[raxo2222]

I suppose the dependency tags are meant to withhold an object from being loaded if the respective module has been inactivated.
This means self-dependencies are pointless. A Big Cat module should never declare dependency on itself. Inter-dependencies like mammoth workers dependent on Andean religion to build Machu Picchu are what this system is for, isn't it?

Dependency on a core definition is also unnecessary.

Yeah, I'm cleaning out dependencies within module and dependencies in core.
Only intermodular dependencies will remain.

 

[Anq]

Module A, B and C.
C only add A references into entries in B.
If C and A is active then the stuff that should be added to entries in B must then depend on itself to exist as well as the stuff it reference from A to exist in case A is not active.

What I mean by "depend on itself" is C declares a dependency on a C entry for a C entry, which will always be loaded, not when C re-defines an entry from B (which should also depend on B as well as A)

 

[Toffer90]

What I mean by "depend on itself" is C declares a dependency on a C entry for a C entry, which will always be loaded, not when C re-defines an entry from B (which should also depend on B as well as A)

Sure, your previous post was a bit unclear, and could be interpreted to that this is pointless:
<LeaderHeadInfo>

<Type>LEADER_KELLY</Type>
<AndDependencyTypes>

<DependencyType>LEADER_KELLY</DependencyType>
<DependencyType>RELIGION_SHAMAN</DependencyType>​

</AndDependencyTypes>
<FavoriteReligion>RELIGION_SHAMAN</FavoriteReligion>​

</LeaderHeadInfo>

Which it is not, as both the leader and the religion are in modules where one or both may be disabled.

 

[Anq]

Sure, your previous post was a bit unclear, and could mean that this is always pointless:
<BuildingInfo>

<Type>BUILDINGCLASS_ALAMO</Type>
<AndDependencyTypes>

<DependencyType>BUILDINGCLASS_ALAMO</DependencyType>
<DependencyType>SOMETHING_ANYTHING</DependencyType>​

</AndDependencyTypes>​

Which is not always the case.

Where is that? I can't find it to prove that this is some module other than Vokarya Wonders redefining BUILDINGCLASS_ALAMO
Oh, it's a fiction definition

 

[Toffer90]

Where is that? I can't find it to prove that this is another module redefining BUILDINGCLASS_ALAMO
Oh, it's a fiction definition

It was a generic hypothetical example, I edited the post to something specific to C2C now.

 

[Anq]

It was a generic hypothetical example, I edited the post to something specific to C2C now.

Alright, thanks for pointing to the real case for me. So it's the module that this file belongs to that matters in this cleanup search.
Although LEADER_ALEXANDER has been moved into the core but not RELIGION_HELLENISM. It should delete that first dependency then, and leave the custom religion dependency in place.

 

[Toffer90]

Alright, thanks for pointing to the real case for me. So it's the module that this file belongs to that matters in this cleanup search.
Although LEADER_ALEXANDER has been moved into the core but not RELIGION_HELLENISM. It should delete that first dependency then, and leave the custom religion dependency in place.

Didn't notice that Alexander was in core, assumed he was in the custom leader module.
Yeah, no need for it to depend on itself then, damn it's not easy finding a case where self dependency is necessary, but if Alexander had been in a module that would have been the case. ^^

Edited the post again to the leader Basil.