MPMPM - Multiplayer Mod DLC-hack (Updated!)

[Chagui2222]

Hello, I have tried making the modpack for Community Patch and Community Balance Patch.

I tested the pack and i have issues with the interface (see attached picture, see city).

Any ideas on what could be wrong?

 

[Chagui2222]

Well it seems that the files on MP_MODSPACK\Mods\Community Balance Patch (v 13) were not the same files that are in MODS\Community Balance Patch (v 13)\

I repleaced some of them and now the UI display error is fixed. So maybe there is some error on the file copying algorithm?

 

[cicero225]

Sukritact's Events and Decisions had an issue while building in Firetuner. It simply said "failed". Disabled it and the pack was created seemingly fine.

Sorry I've been a bit awol. There's only one place in the lua it gives Failed as a message, and that's when the folder name doesn't match what it expects. It's actually simple to possibly fix: See #11 in the opening post (http://forums.civfanatics.com/showpost.php?p=13429988&postcount=1)

(If you're even still paying attention...)

Regarding the anime pack, it's possible Haken Browning borked the pack making due to the constant changes, but it will be difficult to check easily.

 

[cicero225]

Well it seems that the files on MP_MODSPACK\Mods\Community Balance Patch (v 13) were not the same files that are in MODS\Community Balance Patch (v 13)\

I repleaced some of them and now the UI display error is fixed. So maybe there is some error on the file copying algorithm?

Hmm, that's interesting. The current version of the MPMPM does have a problem with files that have the same name in different folders in the same mod; this is because it doesn't copy the files recursively. I've been meaning to fix it, but I'm simply time-deprived at the moment. This is the issue that's been borking the community balance patch. It'll be great if it works even sort of. Have you found it to work?

 

[Bonci]

I was wondering: if I download 2 packs here, is there a way to use them both?

I tried to simply put them in the dlc folder but only one of the 2 is loaded each time :\

 

[cicero225]

I was wondering: if I download 2 packs here, is there a way to use them both?

I tried to simply put them in the dlc folder but only one of the 2 is loaded each time :\

There is not, unfortunately. A special combined pack would have to be made.

 

[Dreamsicle]

Would it be possible to reupload Cicero225's Anime Pack by any chance? I'm fairly certain the reason there weren't any luxuries on the map is because it bugged or errored in the middle of downloading but I somehow still finished it and got the file.

 

[Chagui2222]

Hmm, that's interesting. The current version of the MPMPM does have a problem with files that have the same name in different folders in the same mod; this is because it doesn't copy the files recursively. I've been meaning to fix it, but I'm simply time-deprived at the moment. This is the issue that's been borking the community balance patch. It'll be great if it works even sort of. Have you found it to work?

I can't test it multiplayer because nobody wants to test it with me xD

Yes, this mod has repeated files in different folders. I could fix the issue in the code, but i don't know anything about modding civ5. I need to know how the mod knows which file to use.

I did take a look into the .modinfo file, and I found that the correct files to use were marked with import="1". I don't know what that means, but maybe we have to copy just the files with import="1" ?

 

[Chagui2222]

Hello again, I just implemented this line from the MPMP_Maker.lua:
-- to do: pass modID and version, parse the Mods folder in C++ for .modinfo files to find the correct folder even if it was not conventionnaly named...

So now is searches in the mod folder and finds the correct mod, doesn't matter the folder name

 

[Chagui2222]

I can't test it multiplayer because nobody wants to test it with me xD

Yes, this mod has repeated files in different folders. I could fix the issue in the code, but i don't know anything about modding civ5. I need to know how the mod knows which file to use.

I did take a look into the .modinfo file, and I found that the correct files to use were marked with import="1". I don't know what that means, but maybe we have to copy just the files with import="1" ?

First test today, resync on turn 2. Map didn't load correctly.

 

[DoctorMcGann]

I got events and decisions to pack, but it resulted in file not found errors when I started a game.

 

[cicero225]

Hello again, I just implemented this line from the MPMP_Maker.lua:
-- to do: pass modID and version, parse the Mods folder in C++ for .modinfo files to find the correct folder even if it was not conventionnaly named...

So now is searches in the mod folder and finds the correct mod, doesn't matter the folder name

Well that's definitely useful. Do you have the code on-hand?

Also, regarding the Import=1, that just indicates whether or not the game includes files in the Virtual File System (VFS) when loaded as a mod. This is necessary for sql, lua, art, music files, etc. but not xml, which are loaded regardless of this import line.

For the DLC pack though, this information is not even checked. The game loads all files, regardless.

In any case, I'm sure a lot of the problems with the balance patch are due to files with the same name in different folders being mashed together into the same folder and overwriting each other. I intend to try and make the folder copying recursive later tonight, so hopefully that should resolve it.

Doctor McGann, does the Events & Decisions mod come with files of the same name in multiple folders? If so, it's probably a victim to same problem as above, which I'm going to try and deal with later...

 

[DoctorMcGann]

I'll check. It's certainly possible that's the case.

 

[Chagui2222]

Well that's definitely useful. Do you have the code on-hand?

Also, regarding the Import=1, that just indicates whether or not the game includes files in the Virtual File System (VFS) when loaded as a mod. This is necessary for sql, lua, art, music files, etc. but not xml, which are loaded regardless of this import line.

For the DLC pack though, this information is not even checked. The game loads all files, regardless.

In any case, I'm sure a lot of the problems with the balance patch are due to files with the same name in different folders being mashed together into the same folder and overwriting each other. I intend to try and make the folder copying recursive later tonight, so hopefully that should resolve it.

Doctor McGann, does the Events & Decisions mod come with files of the same name in multiple folders? If so, it's probably a victim to same problem as above, which I'm going to try and deal with later...

Yes, i made a pull request in your github repository (MPMPMaker-Things). I already merged it with what you had (the banned list thingy).

What do you mean by recursively? You mean copy with folders? Because the algorithm is already recursive, and it overwrites the files with same names.

About the import thing: So if i have a lua file that has import = 0, what does it mean? because thats what i see in the modinf of that mod in particular: Lua files used -> import=1, lua files not used-> import = 0.

 

[cicero225]

Yes, i made a pull request in your github repository (MPMPMaker-Things). I already merged it with what you had (the banned list thingy).

What do you mean by recursively? You mean copy with folders? Because the algorithm is already recursive, and it overwrites the files with same names.

About the import thing: So if i have a lua file that has import = 0, what does it mean? because thats what i see in the modinf of that mod in particular: Lua files used -> import=1, lua files not used-> import = 0.

Yeah I just meant copy with folders. Internally, the folder copying function I inherited from Gedemon just goes through the list of files and copies all of them without preserving directory structure. This is obviously problematic if a mod contains two folders both with name "example.xml" and intends to use both.

I wouldn't assume a lua file is unused in a mod just because it has import=0. (http://modiki.civfanatics.com/index.php/VFS_(Civ5) ). Lua files that are explicitly tagged by the mod to be loaded for particular aspects of the game often do not necessarily have to be loaded in by VFS. I understand the balance patch is a large project, but if a lua file is in a mod at all, the chances are overwhelming that it's used by the mod for something.

 

[cicero225]

Yes, i made a pull request in your github repository (MPMPMaker-Things). I already merged it with what you had (the banned list thingy).

What do you mean by recursively? You mean copy with folders? Because the algorithm is already recursive, and it overwrites the files with same names.

About the import thing: So if i have a lua file that has import = 0, what does it mean? because thats what i see in the modinf of that mod in particular: Lua files used -> import=1, lua files not used-> import = 0.

Ah, so I underestimated you. You actually modified the C++ source as well and presumably recompiled for your testing. (Sorry, hadn't actually looked at pull request until now). I had somewhat not expected that. Well that does explain how you got access to the modinfo (which I don't believe is actually possible from the lua). I'll look into the file-copying then.

 

[cicero225]

Would it be possible to reupload Cicero225's Anime Pack by any chance? I'm fairly certain the reason there weren't any luxuries on the map is because it bugged or errored in the middle of downloading but I somehow still finished it and got the file.

Okay, I will try to when I have the time. It's surprising you could start downloading at all, considering the link doesn't actually work (unless you downloaded long ago).

Anyway, I updated the modspack maker (see attachment in first post). This incorporates the changes made by Chagui2222, which look fine and seem to work fine, and should resolve issues with mods with unusual folder names (such as Colonialist Legacy civs).

It also makes file copying into the dlc pack now preserve directory structure, which may fix events and decisions and community balance, and fixes some issues with Names by Policies. It turns out that changing this was almost laughably trivial, once I finally went and looked. Thanks to Gedemon for coding things in a well thought-out manner...

 

[Chagui2222]

It turns out that changing this was almost laughably trivial, once I finally went and looked. Thanks to Gedemon for coding things in a well thought-out manner...

Yes, i saw the changes. It was just 2 lines of code hahaha.

btw, problem 11 in first post should now say:
error ("Failed! Couldn't find folder for mod: " .. name)
instead of error ("Failed! Check Folder Names!")

 

[cicero225]

Yes, i saw the changes. It was just 2 lines of code hahaha.

btw, problem 11 in first post should now say:
error ("Failed! Couldn't find folder for mod: " .. name)
instead of error ("Failed! Check Folder Names!")

Okay, it is changed.

 

[Chagui2222]

It also makes file copying into the dlc pack now preserve directory structure, which may fix events and decisions and community balance, and fixes some issues with Names by Policies.

I've tested it and it still doesn't work. It's loading the incorrect lua files. This is what firetuner says:

Runtime Error: Assets\DLC\MP_MODSPACK\Mods\Community Balance Patch (v 13)\LUA\Inactive\HealthandPlague + CSD\CityBannerManager.lua:360: attempt to call global 'IsPlagued' (a nil value)

It shouldn't be loading anything from the "Inactive" folder.
if I delete the "Inactive" folder it works fine.