UI - Trade Opportunities

[whoward69]

C:\Users\{USERNAME}\Documents\My Games\Sid Meier's Civilization 5\Mods\UI - Trade Opportunities (v 11)\UI\InGame\Popups\DiploTradesStatus.lua

Open with Notepad

function InitPlayer()
  GetCivControl(gPlayerIM, [B][COLOR="Red"]Game.GetActivePlayer()[/COLOR][/B], false)
end

I can't see any problems with the City States panel

Tell me if it fixes the problem and I'll upload a new version to Steam Workshop

W

 

[AndreP]

Yes, it´s works, thank you.

But not for "DiploCityStatesStatus.lua" (show Screenshot)

I´m Germany and Player 2, Player 1 is Arabia.

 

[Txurce]

My English ist not so good, do you speak German?

Andre, your English is very good.

 

[AndreP]

Thank you.

 

[whoward69]

Now I see the problem

C:\Users\{USERNAME}\Documents\My Games\Sid Meier's Civilization 5\Mods\UI - Trade Opportunities (v 11)\UI\InGame\Popups\DiploCityStatesStatus.lua

Open with Notepad

function getAlly(pCs, pPlayer)
  [B][COLOR="Red"]local iPlayer = pPlayer:GetID()[/COLOR][/B]
  local sAlly, sAllyText

function getQuests(pCs, pPlayer, bForcePeace)
  local sQuestText = ""
  [B][COLOR="red"]local iPlayer = pPlayer:GetID()[/COLOR][/B]
  local pCsTeam = Teams[pCs:GetTeam()]

 

[AndreP]

Thank you, it´s works fine.

Now i have a new Problem.

When i clicked on " Trade Opportunities or City States" and then on

"Deal History etc" then... (show Screen).

Edit:
Sorry, my Mistake.

I've forgotten a few lines in "DiploOverview.lua"

 

[whoward69]

Version 12 uploaded, includes changes outlined aboved.

 

[AndreP]

The Error in V11...

"ToolTip"
TXT_KEY_RESOURCE_WHALE, TXT_KEY_RESOURCE_FUR, TXT_KEY_RESOURCE_DYE
must change to
TXT_KEY_RESOURCE_WHALES, TXT_KEY_RESOURCE_FURS, TXT_KEY_RESOURCE_DYES

...is still present in V12.

 

[whoward69]

Thanks.

I also need to update the quest list to include the new quests, so I'll wait until I've done that before posting a new version

 

[skodkim]

Now I see the problem

C:\Users\{USERNAME}\Documents\My Games\Sid Meier's Civilization 5\Mods\UI - Trade Opportunities (v 11)\UI\InGame\Popups\DiploCityStatesStatus.lua

Open with Notepad

function getAlly(pCs, pPlayer)
  [B][COLOR="Red"]local iPlayer = pPlayer:GetID()[/COLOR][/B]
  local sAlly, sAllyText

function getQuests(pCs, pPlayer, bForcePeace)
  local sQuestText = ""
  [B][COLOR="red"]local iPlayer = pPlayer:GetID()[/COLOR][/B]
  local pCsTeam = Teams[pCs:GetTeam()]

I really don't understand this. Are we supposed to change anything in the file?


Think I get the same error using v12:

Spoiler :

[3128.225] Runtime Error: [string "C:\Users\hollenbo\Documents\My Games\Sid Me..."]:28: attempt to index local 'pPlayer' (a nil value)
[3135.620] Runtime Error: [string "C:\Users\hollenbo\Documents\My Games\Sid Me..."]:28: attempt to index local 'pPlayer' (a nil value)

\Skodkim

 

[whoward69]

The bug only affected people trying to use this mod with HotSeat. The changes are now in V12, so no you shouldn't need to edit anything.

If you can confirm if those messages are in V12 (and not V11 - which they look like) I'll add them to the list of things to investigate.

 

[dbconfession]

i can't download from the workshop. Do you have a post for your latest updates here in the forums?

 

[skodkim]

The bug only affected people trying to use this mod with HotSeat. The changes are now in V12, so no you shouldn't need to edit anything.

If you can confirm if those messages are in V12 (and not V11 - which they look like) I'll add them to the list of things to investigate.

I downloaded v12 from the workshop and the mod itself says v12 so...

To make sure I included the mod (and the log file) in the post. Its not exactly the same as the one from the workshop as I made changes to DiploTradesStatus.xml because of the error from post 28 (concerning TXT_KEY_RESOURCE_###).

\Skodkim

 

[whoward69]

Do you have a post for your latest updates here in the forums?

Sorry, but no, and never will. With over 110 mods it's not practical to maintain two upload areas.

 

[whoward69]

I fix one bug and create another

In DiploCityStatesStatus.lua

function ShowHideHandler(bIsHide, bIsInit)
  if (not bIsInit and not bIsHide) then
    [B][COLOR="Red"]InitCsList()[/COLOR][/B]
  end
end
ContextPtr:SetShowHideHandler(ShowHideHandler)

[B][COLOR="red"]function InitCsList()
  local iPlayer = Game.GetActivePlayer()[/COLOR][/B]
  local pPlayer = Players[iPlayer]

This one is bad enough that I'll post a new version (v13) in a bit

 

[skodkim]

Hi Whoward69

Using v14 and enyoying it. It's a shame however that strategic resources aren't displayed. Any chance you could squeeze them in somewhere?

\Skodkim

 

[whoward69]

I think 6 more columns would definately break it's usabilty IMHO, so probably not.

 

[dbconfession]

can't u just add a separate "tab" in diplomacy for start resources instead of squeezing it into "Trade Opps"

Or put it in Trade Opps, but just make ONE column at the end for strat resources, which blows pinto another similar pop-up screen when moused over, much like when mousing over culture, happiness out in the map screen.

 

[Martock]

For some reason this mod doesn't want to work now. Where I should be seeing Trade Opportunities, I get TXT_KEY_DO_TRADE_STATUS. Now I applied a fix you recommened to me the other day with regards to the Enhanced Rankings. I moved the Civ5ModsDatabase.db to a backup dir and then restarted, letting the mods update again. Trade Ops shows a check and shows up as loaded in my mods but for some reason doesn't work. Any ideas? Anything I can post to help?

 

[whoward69]

Enable logging and see what's in database.log (and possibly xml.log and lua.log)