[NFP] 1.0.1.501. symmetric alliance benefit

[cholsy]

[Rule]
Asymmetric.
Benefit of Science, Culture, Faith, Gold is asymmetric between sender and receiver of a trade route.

[Actual result]
Symmetric.
Sender and receiver get same amount.

[Save file]
Ready to ally with Brazil or Maya.
Trade routes are already built with both.

EDIT) Their benefit was captured as well.

 

[Infixo]

I believe the vanilla screen shows only your benefits. So... how did you check what benefits has your alliance partner?

 

[Laurana Kanan]

I believe the vanilla screen shows only your benefits. So... how did you check what benefits has your alliance partner?

Unless I'm seeing it wrong, they're looking at trade routes TO their cities from an ally, which should only be +1 science instead of +2. But looking at it now, couldn't one of the two science received be from the Maya cities having Observatories there? The code itself for alliance trade routes looks OK as far as I can tell.

 

[cholsy]

But looking at it now, couldn't one of the two science received be from the Maya cities having Observatories there? The code itself for alliance trade routes looks OK as far as I can tell.

Before alliance, there was no science from the route. The 2 science pops up right after alliance.
I checked with culture and gold as well.
+2 culture, +4 gold for same case, which should be +1, +2 each.
Same with Brazil.
Can be tested with the save file.

 

[cholsy]

I believe the vanilla screen shows only your benefits. So... how did you check what benefits has your alliance partner?

I attached a capture of the partner's benefit next to mine. They have +2.

 

[Infixo]

BTS shows +2 science for both origin civ and destination civ, in both cases i.e. route from maya to canada and the one from canada to maya.
However, in my recent games I am pretty sure I always see a difference, it is easy to spot with BTS since it shows yields for both sides. I don’t think the alliances are bugged, there must be some other effect in place that adds an extra yield to the sender. Edit: to receiver.

 

[cholsy]

there must be some other effect in place that adds an extra yield to the sender.

The benefit to a sender works normally.
Problem is the benefit to a receiver.
It should be +1 but always +2 in every check I did.
I checked if there is any other modifier for receiver... wonder, policy, city state, great person, technology, civic, etc... but failed unfortunately, so far.

 

[Infixo]

@cholsy You are right, I meant receiver, my mistake.
My point is that BTS shows 2 lines with benefits, the upper one for a sender, and a bottom one for the receiver. I meant the bottom one is usually smaller.
BUT: since this topic I am paying a bit more attention to those yields and yes, there are also cases where they are the same. So, it is possible that there is some hidden bug and I’d rather like Firaxis to have a look at your report. You provided pretty simple case with a save file, so it should be really easy for them to check if there is anything wrong.

 

[cholsy]

<ModifierId>ALLIANCE_ADD_GOLD_TO_DESTINATION_TRADE_ROUTE</ModifierId>
<Name>Amount</Name>
<Value>2</Value>

I changed this value from 2 to 1.
Created a new game to find no change. (still 4)
My impression is that the final yield is decoupled from this value, rather than miscalculated.

 

[cholsy]

Checked what happens if "GOLD_TO_ORIGIN_TRADE_ROUTE" is reduced from 4 to 2.
Found that both origin and destination yield were changed from 4 to 2.
The problem is that DESTINATION copies ORIGIN value, instead of using its own value.
@firaxis, plz check this.