3UC/4UC for VP: Project Coordination Thread

[pineappledan]

There's a SV in this mod. It's late so I'll put that together tomorrow

 

[adan_eslavo]

I can put sv today.
I can rework monitor with my code. I know it so it will be easier for me. I would check also rest of arabians and assyrias codes.
Ok I will revert ranch change then.

 

[Hinin]

Second test session : I tested all UM until the Renaissance era, and then the Corsair, when spawned, made the game crash again (so there is an issue here).
Only a few things to say (most things worked fine) :
- The Iron Chariot, as we said, doesn't have a 3D model yet, but I tested it in strategic view, and the "Fury of Nergal" promotion works fine.
- The Great Turkish Bombard should simply be renamed "Great Bombard", since, in game, the current result is that I have an "Ottoman Great Turkish Bombard"...
+ When attacking, there are two popups (one saying "-20 hp" and one saying "Sahi Topu -20 hp")
- The Legion and the Ballista benefited from no bonus even if there was a GG within two tiles (because I was using Morocco, since I remember that the Roman GGs have additionnal promotions compared to the normal ones) : I think the units should benefit from GGenerals from all civs, and not only Roman ones (or else, the description of the units need to be tweaked a bit).

If we go for an anglicized version we could call it the Crouching Tiger cannon instead, or just Seir Morb in both cases

I think Crouching Tiger would be better.

I have abandoned the idea of Pr/Go on the lumber camps. It's too many yields on the same tiles for 1 building (4 total)

Ok, but why suppressing the bonus from the base building ? The Elephant Camp should still have the +1 Pr/+1 Go to forests bonus.

If I am reading the code correctly, Harbour gives 15% for all naval military units
Tersane gives 30% for naval MELEE units, but not ranged
WRT runestone, combines with harbor, the runestone gives 40% to melee and 15% to ranged. The runestone is far stronger in this regard.

I agree.

 

[adan_eslavo]

• Moved sql texts to TextChanges.sql file. Added few new update text to fill.
• Checked Wat. Values with culture yields on features are deleted from table. I don't know why you had it. It's impossible?
• I added sv icon for monitor.
• Fixed Druidic Lore. Ty @IcyAngel
• Sachem has 3 paper, there's 3 paper in main post. It was suggested to be changed earlier? I reduced other things already.
• Hashemite Icon - it is done such way. @pineappledan can you modify it a bit?
• deleted text files of BG,
• added default Iron Chariot model from vanilla,
  

@Hinin

• we have promotion named crouching tiger.
• -20 Sahi Topu is one of many popups that style. It is one more info but detailed. First -20 is from vanilla game about your damage. Second is mine about what caused damage because it is not natural (unit is not attacked), so info is needed (like Pilum). The only difference is that Pilum somehow disabled default one.
• Add unique roman promotions to all generals? No problem, but why other nations could benefit for having Praefectus Castrorum and Legatus Legionis?

 

[pineappledan]

• Sachem has 3 paper, there's 3 paper in main post. It was suggested to be changed earlier? I reduced other things already.

I think thats good as is.

• Hashemite Icon - it is done such way. @pineappledan can you modify it a bit?

I don't know what you want me to do with it. Modify it how?

-20 Sahi Topu is one of many popups that style. It is one more info but detailed. First -20 is from vanilla game about your damage. Second is mine about what caused damage because it is not natural (unit is not attacked), so info is needed (like Pilum). The only difference is that Pilum somehow disabled default one.

I think if we are more clear in the help and strategy text that this unit hurts itsefl when it fires that no popup would be necessary. At the very elast the popup should be "Sahi Topu" not -20 Sahi Topu

• Add unique roman promotions to all generals? No problem, but why other nations could benefit for having Praefectus Castrorum and Legatus Legionis?

It's all about those CS gifts. We stated that the unit gets unique promotions near GGs; that does not imply they have to still be Roman GGs

 

[adan_eslavo]

• I know, I know. The only thing is, if we want it to work for everyone? It is based on 2 unique dummy promotions put on General. It will be starnge if I put Legatus on Polish GG. Right?
• You could make this purple background instead of black left side. This could help.
• I can rework popups to not show damage when they are not necessary. Do it?
• Flax 22px icon still needs contrast. Rest seems to be ok. But again white background like in figs... :]

• I fixed Monitor texts. Made links to existing ones, and added update functions in text sql.
• Fixed links to few units and buildings, especially Hashemite.
• Renamed to Seir Morb and Great Bombard

 

[pineappledan]

I know, I know. The only thing is, if we want it to work for everyone? It is based on 2 unique dummy promotions put on General. It will be starnge if I put Legatus on Polish GG. Right?

The only thing that would give me pause if it is too computationally intensive. Otherwise it will be there, but if they have no legions or ballistae it will never come up. I think it should be put on all GGs

You could make this purple background instead of black left side. This could help.

So we are talking about the unit icon? this one?

Spoiler :

So you want the colour balance adjusted on the back "sky" of the icon?

 

[adan_eslavo]

• Stretch sky to this black frame on the left. exactly.
• That will be lots of code. I will just add it for now and then think of implementing appearing and disappearing promotions.

• Changed few unit promotion texts.
• Changed promotion icons.

Pushed new beta branch. Better sync with it if you can. Many changes. Rest later today.

 

[Hinin]

Third test session :

Spoiler Lots of things :

Persia :
- Qizilbash : When buying the Qizilbash with faith, this happen

Spoiler Qizilbash :

Carthage :
- Sophet : When embarking/disembarking the UC, there is still the "+2 military supply" effect : I think we should put the file allowing this to not happen in the front page beside the mod.
+ The unit has no visible promotion saying "units beginning their turn on the same tile or next to the Sophet ignore ZOC until end of turn", only the "This unit ignores ZOC until the end of the turn" (which, I assume, is the promotion created by the previous one, like Massacre)
- Tophet : There is no popup when purchasing a unit telling you you gain culture (like for the E-Temenanki for example)
+ The resulting units have 1 less xp compared to produced units : it is surely the result of the calculation of the xp (base xp / 2 (because unit is purchased ; rounded to the inferior) x 2 (effect of the Tophet) => with a Barrack and an Armory, the purchased unit has 34 xp (35 / 2 = 17.5 => rounded to 17 => 34 xp thks to Tophet)
=> Should we make the effect of the Tophet "2x +1" instead of "2x", or is it too complex to implement ?

Egypt :
- Kopesh : No visible effect for the "Skillful" promotion (I did multiple tests, and there was no result)
+ Does "Mercy" only work when attacking (I attacked a barbarian Kopesh with a one with less than 50 hp, and the bb Kopesh had
no bonus) ?
- Nilometer : The Game Info of the UB needs to be redone (the rest of the presentation is good) to better present the effects of the UB

Greece :
- Klepht : So, the effect of the "Philhellenism" promotion is "+4 Go/Pr when attacking +4 Go/Pr per allied CS" (so no yield when defending, even though the unit is fighting, and there is still some yield with no allied CS) : the description of the promotion needs to be redone
+ The unit, when selected, does the same sound as the GGun : we should use the one of the Musketman
+ The formation of the unit needs to become the one of the Scout (a few scattered humans), since it is a Guerilla unit
+ The model of the unit is still the one of the Janissary (it could trigger the Greek players )

Portugal :
- Cacadores : The "Cacador" promotion doesn't have an effect it seems (or is it linked to a dummy building proper to Portugal ?)
- University of Coimbra : There is no "Age of discovery" promotion on naval units after the building is created

France :
- SPAD S.VII : There is no mention of the fact that the unit is significantly cheaper than the Triplane and doesn't require Oil in the Game Info

Sweden :
- Sauna : the bonus of the Baths aren't mentionned in the Game Info ("In addition to the bonus of the Baths")

Austria :
- Standschützen : the building should be named Schützenstand (rifle guild) and not Standschützen (member of that guild)
+ The picture is nice, but it's quite pixelated
- Landwehr : The +2 culture per turn when the unit finishes the turn in owned territory is simply added to the total culture (there is no popup)

Morocco :
- Riad : There is no mention of the bonus of the Garden in the Game Info ("In addition of providing stronger bonus than the Garden it replaces, the Riad...")

Iroquois :
- The Game Info needs to be tweaked to say "gives 3 Papers instead of 1"

Arabia :
- Hashemite Raider : The flag of the unit is very complex and cannot be seen correctly with the scale of the flags in the game (so I think maybe only the scripture at the center could be kept).

Aztec :
- Huey Teocalli : The building gives the same bonus to Temples (+1 Fa/Cu) as the previous version of the Great Temple (which now gives +2 Fa/Cu to Temples). This should be corrected.

I'll do the test for the popups of each civ with has a building/improvement providing some (the Shoshones/Egypt/Rome).

Have a good day !

 

[adan_eslavo]

Third test session :

Spoiler Lots of things :

Persia :
- Qizilbash : When buying the Qizilbash with faith, this happen

Spoiler Qizilbash :

View attachment 485464

Carthage :
- Sophet : When embarking/disembarking the UC, there is still the "+2 military supply" effect : I think we should put the file allowing this to not happen in the front page beside the mod.
+ The unit has no visible promotion saying "units beginning their turn on the same tile or next to the Sophet ignore ZOC until end of turn", only the "This unit ignores ZOC until the end of the turn" (which, I assume, is the promotion created by the previous one, like Massacre)
- Tophet : There is no popup when purchasing a unit telling you you gain culture (like for the E-Temenanki for example)
+ The resulting units have 1 less xp compared to produced units : it is surely the result of the calculation of the xp (base xp / 2 (because unit is purchased ; rounded to the inferior) x 2 (effect of the Tophet) => with a Barrack and an Armory, the purchased unit has 34 xp (35 / 2 = 17.5 => rounded to 17 => 34 xp thks to Tophet)
=> Should we make the effect of the Tophet "2x +1" instead of "2x", or is it too complex to implement ?

Egypt :
- Kopesh : No visible effect for the "Skillful" promotion (I did multiple tests, and there was no result)
+ Does "Mercy" only work when attacking (I attacked a barbarian Kopesh with a one with less than 50 hp, and the bb Kopesh had
no bonus) ?
- Nilometer : The Game Info of the UB needs to be redone (the rest of the presentation is good) to better present the effects of the UB

Greece :
- Klepht : So, the effect of the "Philhellenism" promotion is "+4 Go/Pr when attacking +4 Go/Pr per allied CS" (so no yield when defending, even though the unit is fighting, and there is still some yield with no allied CS) : the description of the promotion needs to be redone
+ The unit, when selected, does the same sound as the GGun : we should use the one of the Musketman
+ The formation of the unit needs to become the one of the Scout (a few scattered humans), since it is a Guerilla unit
+ The model of the unit is still the one of the Janissary (it could trigger the Greek players )

Portugal :
- Cacadores : The "Cacador" promotion doesn't have an effect it seems (or is it linked to a dummy building proper to Portugal ?)
- University of Coimbra : There is no "Age of discovery" promotion on naval units after the building is created

France :
- SPAD S.VII : There is no mention of the fact that the unit is significantly cheaper than the Triplane and doesn't require Oil in the Game Info

Sweden :
- Sauna : the bonus of the Baths aren't mentionned in the Game Info ("In addition to the bonus of the Baths")

Austria :
- Standschützen : the building should be named Schützenstand (rifle guild) and not Standschützen (member of that guild)
+ The picture is nice, but it's quite pixelated
- Landwehr : The +2 culture per turn when the unit finishes the turn in owned territory is simply added to the total culture (there is no popup)

Morocco :
- Riad : There is no mention of the bonus of the Garden in the Game Info ("In addition of providing stronger bonus than the Garden it replaces, the Riad...")

Iroquois :
- The Game Info needs to be tweaked to say "gives 3 Papers instead of 1"

Arabia :
- Hashemite Raider : The flag of the unit is very complex and cannot be seen correctly with the scale of the flags in the game (so I think maybe only the scripture at the center could be kept).

Aztec :
- Huey Teocalli : The building gives the same bonus to Temples (+1 Fa/Cu) as the previous version of the Great Temple (which now gives +2 Fa/Cu to Temples). This should be corrected.

I'll do the test for the popups of each civ with has a building/improvement providing some (the Shoshones/Egypt/Rome).

Have a good day !

• Persia: it is probably automatic info. Do this: choose the policy which gives all land units for faith, then buy one and check the info. I just made it available earlier than the rest.
• Arabia - I'm in. I will do this redone. Should be easy.
• Sweden - checking
• Klepht:
  • it always has base yields
  • should be on defend. Looking for a bug,
  • yeah I know that model is not what we want. We don't have one.
  • I will change formation and sound.
• Egypt - checking

 

[pineappledan]

The resulting units have 1 less xp compared to produced units : it is surely the result of the calculation of the xp (base xp / 2 (because unit is purchased ; rounded to the inferior) x 2 (effect of the Tophet) => with a Barrack and an Armory, the purchased unit has 34 xp (35 / 2 = 17.5 => rounded to 17 => 34 xp thks to Tophet)
=> Should we make the effect of the Tophet "2x +1" instead of "2x", or is it too complex to implement ?

I would have to only add +1 if the original XP was an odd number. If the XP is an even number then it works perfectly. I'm cool with it being 1XP off, because the info for what the original XP was supposed to be is dumped by G's calculation which removed the XP in the first place

- Sophet : When embarking/disembarking the UC, there is still the "+2 military supply" effect : I think we should put the file allowing this to not happen in the front page beside the mod.
+ The unit has no visible promotion saying "units beginning their turn on the same tile or next to the Sophet ignore ZOC until end of turn", only the "This unit ignores ZOC until the end of the turn" (which, I assume, is the promotion created by the previous one, like Massacre)

This should have been incorporated into the new mods, starting with the Jan 3 patch. are historical events not triggering? It could be that @Infixo sent G the old copy of the .dll which only had the .lua exposure for historical events silencing

+ The unit, when selected, does the same sound as the GGun : we should use the one of the Musketman

should be on defend. Looking for a bug

No I'm pretty sure we agreed only on attack. They are guerillas, so they shouldn't get rewarded for getting jumped, only rewards for being the one doing the ambushing.
Janissaries were often ethnic greeks, the clothing is very similar. Maybe we can go in and do some minor tweaks to it later though, but honestly the janissary model is really close to what we want
sound and unit placement are good ideas though. nice.

- SPAD S.VII : There is no mention of the fact that the unit is significantly cheaper than the Triplane and doesn't require Oil in the Game Info

ill fix

- Sauna : the bonus of the Baths aren't mentionned in the Game Info ("In addition to the bonus of the Baths")

i'll fix

- Landwehr : The +2 culture per turn when the unit finishes the turn in owned territory is simply added to the total culture (there is no popup)

you want a +2 culture pop up every turn? isn't that bothersome? Also, shouldnt this just be if in a garrison, not every turn they are anywhere in austrian territory? This looks crazy abusable. Like they can pump up landwehr for culture, just converting gold maintenance to culture output.

- The Game Info needs to be tweaked to say "gives 3 Papers instead of 1"

Does it? It's in the resources provided at the top of the building's description. I didn't describe how the Tophet gives 1 more culture than a base shrine, why describe how this building gives 1 more paper? It just makes for a wall of text

- Hashemite Raider : The flag of the unit is very complex and cannot be seen correctly with the scale of the flags in the game (so I think maybe only the scripture at the center could be kept).

The seven pointed star should be kept over the script. the arabian script is very complex. can you post a picture of what it looks like in game?

 

[Hinin]

This should have been incorporated into the new mods, starting with the Jan 3 patch. are historical events not triggering? It could be that @Infixo sent G the old copy of the .dll which only had the .lua exposure for historical events silencing

There were no historical event, but I hadn't meet another major civ when I was testing the unit, so I'll do another test to confirm.

No I'm pretty sure we agreed only on attack. They are guerillas, so they shouldn't get rewarded for getting jumped, only rewards for being the one doing the ambushing.
Janissaries were often ethnic greeks, the clothing is very similar. Maybe we can go in and do some minor tweaks to it later though, but honestly the janissary model is really close to what we want

For the effect of Philhellenism, I agree with you (this promotion is already very powerful when you have a full army of Klepht).
For the model, maybe only replacing the Janissary hat by the one worn by this famous Klepht ?

you want a +2 culture pop up every turn? isn't that bothersome? Also, shouldnt this just be if in a garrison, not every turn they are anywhere in austrian territory? This looks crazy abusable. Like they can pump up landwehr for culture, just converting gold maintenance to culture output.

At the beginning of each turn, you'll see a lot of +2 culture emerging from your lands... but I don't think it's that bothersome. However, I agree with your idea about giving the bonus culture only to garrisonned units (although this could be done later, as no playtests has been done with Austria).

Does it? It's in the resources provided at the top of the building's description. I didn't describe how the Tophet gives 1 more culture than a base shrine, why describe how this building gives 1 more paper? It just makes for a wall of text

The building attributes are exact, but the Game Info says that the building gives 2 Papers instead of 1.

The seven pointed star should be kept over the script. the arabian script is very complex. can you post a picture of what it looks like in game?

I'll take a picture.

 

[adan_eslavo]

I'm testing new arabian flag...

 

[Blue Ghost]

@Hinin: Can you file bug reports on Github for all the bugs you find?

Looking into the Corsair issue again, since it’s apparently still not resolved.

 

[adan_eslavo]

...and it is too coplex. Maybe I will only one part of the sign?

• Mercy was working well
• Skillful fixed (typo)
• Klepht reworked (only defend bonus, sound from musketman, formation scout, bonus values as were, so 5*(numofallyorfiriends+1)

 

[pineappledan]

On mobile. I can fix the Hashemite unit flag, but I want to at least see what it looks like now. I’ll just change it to the 7-pointed star

 

[adan_eslavo]

I'm testing version with only part of the sign. If it will be bad then I will do 7-star like you said. I will post screen.

 

[pineappledan]

Oh that looks nice. Let’s use that. Do you know what the Arabic says?

 

[Hinin]

I'm testing version with only part of the sign. If it will be bad then I will do 7-star like you said. I will post screen.

It seems complex, but quite good-looking to me.
Just an annex question : what mod do you use to change the colors of the civs ?

 

[adan_eslavo]

https://forums.civfanatics.com/resources/redesigned-colors-and-icons-rci-v.24109/

I made my own version which do not need to be loaded in mods but starts with game.