3UC/4UC for VP: Project Coordination Thread

[Hinin]

I have no idea for now how to make capturing enemy spies more frequent. I can nullyfy current value of spy rate but it would be also not so good.

Maybe something in the "Double agent" order tenet can help you.

 

[adan_eslavo]

Probably not so much because it is coded from dll to policies table. From lua I can get value of that modifier but not set it.

 

[Hinin]

Probably not so much because it is coded from dll to policies table. From lua I can get value of that modifier but not set it.

Ah sorry... My lack of knowledge can make me say stupidities sometimes.

 

[adan_eslavo]

• What about 2nd idea for Barbican? Probably too complicated.
• I would just add some yield-based bonus, because what we have for now is bonus XP, supply cap, crime reduction, bonus to units and bonus to cities.
• Or we can add BlockScienceTheft or BlockUDestrictionSpies?
• Or +XX to range and siege units.

 

[Infixo]

If I may, I would like to post a suggestion. Your project is really huge. 900+ files. It will be equally huge pain to maintain it later and keep the changes in sync with VP. My suggestion is: put it ASAP to GitHub. This will ease your work considerably and allow others to contribute. Plus some more benefits like issue management.

 

[Infixo]

• To "others" I planned put all civilian promotions (GG, GA, worker etc.). We can call it "civilian" as well
• About diplomatic: remember that there are few promotions from buildings like Wire Service or Literacy. I think there are at least 10 of them.
• I thought also about making "Siege" category" for some specific Siege promotion divided from Ranged category.

Let's give it a try. What would be new categories then? We can start with:
- PEDIA_SIEGE
- PEDIA_CIVILIAN
- PEDIA_DIPLO
Looks good.
Btw, all existing categories must stay due backward compatibility and support for other mods.

 

[adan_eslavo]

If I may, I would like to post a suggestion. Your project is really huge. 900+ files. It will be equally huge pain to maintain it later and keep the changes in sync with VP. My suggestion is: put it ASAP to GitHub. This will ease your work considerably and allow others to contribute. Plus some more benefits like issue management.

I need to learn it first. I will try to upload all files today. How it works? You just edit the files I uploaded or you make your own copy of that files and then edit them?
I will upload second project with promotion rework.

 

[Hinin]

What about 2nd idea for Barbican? Probably too complicated.

It is not me who can say that this kind of idea is too complicated to code or not unfortunately. I only find that we should choose between the existing effect of the Barbican (+33 % RCS to ranged units garrisoned in the city) and the effect proposed by pineappledan (which is a good idea, but I like the first option too, so I'm neutral here).

I would just add some yield-based bonus, because what we have for now is bonus XP, supply cap, crime reduction, bonus to units and bonus to cities.

I think the building is good enough (it will be the UB contributing the most to the defense of a city, with the Ostrog, which comes later).

• Or we can add BlockScienceTheft or BlockUDestrictionSpies?

• Or +XX to range and siege units.

Once again, I think the building is good enough (Poland already have a good UA and very good UCs).

 

[Infixo]

I need to learn it first. I will try to upload all files today. How it works? You just edit the files I uploaded or you make your own copy of that files and then edit them?
I will upload second project with promotion rework.

Yup, GitHub is overwhelming at first especially if you want to use text interface (i.e. git function from command prompt). I am not at that level yet.
As a start you can use GitHub Desktop plus Web Interface.
0. Install GitHub Destop.
1. First, somebody needs to create a repository like the main storage for entire project. You can do it in Web or locally using GitHub Desktop. For many reasons you'd better do it using Web.
2. You need then create a local copy to make changes locally. It is done via Web as well.
3. Tada - you can make changes locally and they will be tracked by GitHub.
3a. Basically just copy files into that location. They all will be tracked from now on.
4. You can see changes in Desktop and upload them into Web repository.
Once you do the above, you can start using key functions like Branches and Pull Requests.
- Any other person can also download that repository and make changes on their own. Then they issue a Pull Request and you can automatically merge them into main code (via Web).
- You can grant permissions for others to manage the main repository as well.

 

[pineappledan]

I suspected increasing % chance to catch spies would be burried. England already has a buff to spy-catching, in that their spies start 1 rank higher than other spies. That's probably good enough

A lot of buildings in VP abide by a sort of 2 effects rule; an uncomplicated bonus effect, and then a wacky, more complicated game effect
floating gardens: double scaling on yields from pop AND +1 food on rivers
Skola: extra scientist AND insane scaling per pop on both science and culture

Right now it seems like the promotion on a garrisoned unit is the crazy amazing thing for Barbican. 33% RCS wouldn't make a noticeable splash, but 2 attacks on any ranged unit in the city might. If they have logistics, all units still can only attack twice. (remember in vanilla that if you got logistics on a keshik and upgraded it to a lancer and then got blitz you still could only get 1 attack).
I figured it should be a unique promotion, however, and not just logistics, because the ability to hit twice for full RCS would be unique.

EDIT: @adan_eslavo loading things on Github would be a tremendous timesaver with regards to keeping things current for VP. Right now I have to ask you or BG to change things on my behalf even if it's a simple numbers tweak.

For example - With the new changes to university and de-emphasizing buildings, Bastu is too strong. Should be 10% culture now, and 15% science/culture on births. The University got taken down to 25% on science only and Culture on Opera houses got reduced too. Bastu stands out head and shoulders vs. more focused buildings. Maybe % food should be reduced too, i'm not sure

 

[Infixo]

@adan_eslavo

I have added all 3 from the above plus "PEDIA_CARSUB" as "Carriers and Submarines". There are 9 unique promos in this category.

Until those changes will make way into official VP, you also need to add somewhere new textes:

       <!-- Civilopedia more categories for Unit Promotions -->
        <Row Tag="TXT_KEY_PROMOTIONS_PEDIA_MELEE">
            <Text>Melee Promotions</Text>
        </Row>
        <Row Tag="TXT_KEY_PROMOTIONS_PEDIA_RANGED">
            <Text>Ranged Promotions</Text>
        </Row>
        <Row Tag="TXT_KEY_PROMOTIONS_PEDIA_NAVAL">
            <Text>Naval Promotions</Text>
        </Row>
        <Row Tag="TXT_KEY_PROMOTIONS_PEDIA_HEAL">
            <Text>Healing Promotions</Text>
        </Row>
        <Row Tag="TXT_KEY_PROMOTIONS_PEDIA_SCOUTING">
            <Text>Scouting Promotions</Text>
        </Row>
        <Row Tag="TXT_KEY_PROMOTIONS_PEDIA_AIR">
            <Text>Air Promotions</Text>
        </Row>
        <Row Tag="TXT_KEY_PROMOTIONS_PEDIA_SHARED">
            <Text>Shared Promotions</Text>
        </Row>
        <Row Tag="TXT_KEY_PROMOTIONS_PEDIA_ATTRIBUTES">
            <Text>Unit Attributes</Text>
        </Row>
        <Row Tag="TXT_KEY_PROMOTIONS_PEDIA_SIEGE">
            <Text>Siege Promotions</Text>
        </Row>
        <Row Tag="TXT_KEY_PROMOTIONS_PEDIA_DIPLO">
            <Text>Diplomacy Promotions</Text>
        </Row>
        <Row Tag="TXT_KEY_PROMOTIONS_PEDIA_CIVILIAN">
            <Text>Civilian Promotions</Text>
        </Row>
        <Row Tag="TXT_KEY_PROMOTIONS_PEDIA_CARSUB">
            <Text>Carriers and Submarines</Text>
        </Row>

 

[adan_eslavo]

I added this small Promotion Overhaul to Github. You can look there. I managed to connect ModBuddy files and Github directory somehow.

 

[Infixo]

I added this small Promotion Overhaul to Github. You can look there. I managed to connect ModBuddy files and Github directory somehow.

Seems ok. Congratulations
Remember that all you do locally, will go into master repository. You can create a temporary rep, called a Branch, to e.g. Test new things. If you are ok with them, then you merge them into main rep.
Edit. The main rule should be: main repositoryn (master) must always work. So others can take it and run.

 

[adan_eslavo]

Ok. Thank for help. Do I need to put all the Civilopedia Screen file into modpack for now?

 

[Infixo]

Ok. Thank for help. Do I need to put all the Civilopedia Screen file into modpack for now?

If you want to use the new categories then yes. Until it will appear in VP.

 

[adan_eslavo]

• How can you know when I publish something to Github?
• I just added new Branch and your files but something is wrong and it doesn;t show me new Diplo category (I changed Ambassador promotion to put it there).

 

[Infixo]

• How can you know when I publish something to Github?
• I just added new Branch and your files but something is wrong and it doesn;t show me new Diplo category (I changed Ambassador promotion to put it there).

You need to create a Pull Request and compare Beta to Master (master on the left, beta on the right). It will show you diffs. Accept them and merge into master.

 

[adan_eslavo]

Ok. Look there and help me find the cause of failure with implementing new categories, please.

Posted More Unique Components on Github for everyone.

 

[Infixo]

Oppidum: if you build Oppidum in city A, the city A will get bonus 20 HP. But the city B has the same Oppidum in its range and tae that tile from city A and starts working it. Bonus 20 HP is still tied to city A. If you now decide to remove that Oppidum 20 HP will be taken from city B(!) not A.
Reason: there's no event triggered on moving tile from one city to another.
Possible solution: make Oppidum permament.

I took a look at that code. My propositions:
1. Make it work within a specfic range, like 2 or 3 tiles. It will grant bonus HP to all cities there. No tile-change problem.
2. It still works even when it is pillaged, probably shoudn't. I suppose when iOldImpr == iNewImpr then you can use bPillage flag to distiinguish between cases.

 

[adan_eslavo]

I made a site for Promotion Overhaul so @Infixo every new post about it please post there.