3UC/4UC for VP: Project Coordination Thread

[Hinin]

Here is what the current flag looks like. The star apart, we can't see anything...

Spoiler Pictures :

I tested the Sophet again, and there is no historical event, but the military suplly bonus when embarking/disembarking.
I just realized that, in its current state, the Sophet can cause some infuriating problems : since it can only disembark in cities, but can embark anywhere, it can be embarked on a lake with no cities around it, and never be able to return to land again...

I tested the Buffalo pound : the popup works well.

 

[adan_eslavo]

I don't know what it means. Just cut part of it which could be separated and big enough.

 

[Hinin]

I don't know what it means. Just cut part of it which could be separated and big enough.

It is a part of the sentence : "In the name of God, Most Gracious, Most Merciful", which can be found in the flag of the Hashemite dynasty in Jordan.

 

[pineappledan]

Just looked it up, that’s the Arabic for Allah. I think that’s fine, just didn’t want it to be “most” or something, then someone who actually read Arabic would laugh

 

[Ziad]

*laughs*

 

[adan_eslavo]

There's still lots of lua errors from somewhere. I can see plot iterator problem.

[20760.550] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:29: attempt to index local 'owner' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:29: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:27>
[20760.597] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:164: attempt to index global 'pCity' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:164: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:127>
[20765.246] InGame: OnInterfaceModeChanged
[20765.246] InGame: oldInterfaceMode: 1
[20765.246] InGame: newInterfaceMode: 3
[20765.839] InGame: OnInterfaceModeChanged
[20765.839] InGame: oldInterfaceMode: 3
[20765.839] InGame: newInterfaceMode: 1
[20766.993] InGame: OnInterfaceModeChanged
[20766.993] InGame: oldInterfaceMode: 1
[20766.993] InGame: newInterfaceMode: 3
[20767.461] InGame: OnInterfaceModeChanged
[20767.461] InGame: oldInterfaceMode: 3
[20767.461] InGame: newInterfaceMode: 1
[20767.867] InGame: OnInterfaceModeChanged
[20767.867] InGame: oldInterfaceMode: 1
[20767.867] InGame: newInterfaceMode: 3
[20768.288] InGame: OnInterfaceModeChanged
[20768.288] InGame: oldInterfaceMode: 3
[20768.288] InGame: newInterfaceMode: 1
[20803.419] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: attempt to call global 'PlotAreaSweepIterator' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:101>
[20803.544] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: attempt to call global 'PlotAreaSweepIterator' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:101>
[20803.638] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:168: attempt to index global 'pCity' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:168: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:127>
[20803.669] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: attempt to call global 'PlotAreaSweepIterator' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:101>
[20803.918] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:168: attempt to index global 'pCity' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:168: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:127>
[20803.950] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: attempt to call global 'PlotAreaSweepIterator' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:101>
[20804.168] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:168: attempt to index global 'pCity' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:168: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:127>
[20804.199] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: attempt to call global 'PlotAreaSweepIterator' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:101>
[20804.449] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:168: attempt to index global 'pCity' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:168: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:127>
[20807.491] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: attempt to call global 'PlotAreaSweepIterator' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:101>
[20808.864] TurnProcessing: Hiding TurnProcessing
[20812.311] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: attempt to call global 'PlotAreaSweepIterator' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:101>
[20812.436] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:168: attempt to index global 'pCity' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:168: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:127>
[20813.434] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: attempt to call global 'PlotAreaSweepIterator' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:101>
[20814.698] TurnProcessing: Hiding TurnProcessing
[20815.821] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: attempt to call global 'PlotAreaSweepIterator' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:101>
[20816.695] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: attempt to call global 'PlotAreaSweepIterator' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:101>
[20817.881] TurnProcessing: Hiding TurnProcessing
[20820.221] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: attempt to call global 'PlotAreaSweepIterator' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:101>
[20821.032] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: attempt to call global 'PlotAreaSweepIterator' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:101>
[20822.264] TurnProcessing: Hiding TurnProcessing
[20825.587] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: attempt to call global 'PlotAreaSweepIterator' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:101>
[20826.851] Runtime Error: [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: attempt to call global 'PlotAreaSweepIterator' (a nil value)
stack traceback:
    [string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:111: in function <[string "C:\Users\Adam\Documents\My Games\Sid Meier's ..."]:101>

Reworked Monitor.lua.
Merged my work to master.

 

[Hinin]

I don't think anyone knowing Arabic would laugh when reading a text saying "Most Gracious, Most Merciful", since the sentence "In the name of Allah/God, Most Gracious, Most Merciful" is called the Basmala and is recited before each sura of the Coran, but I agree that knowing exactly what is said is for the best.

I tested Egypt and Rome : there is no problem related to the spawn resources/popups.

 

[adan_eslavo]

Good, because I'm done for today
There will be need of correction for every "damage" popup. I added damage to them every time.

 

[Hinin]

There will be need of correction for every "damage" popup. I added damage to them every time.

So "Bleeding !" and "Burning !" with the "Serious" and "Heavy" versions (for -20 and -30 hp respectively).

Just wanted to say that, when looking at the Flax, I observed something quite interesting.

Spoiler Picture :

There was no modification of the yield with the Harbor/Laguna/Seaport in the city, but there is still an indication here that the Flax can be considered a "Sea resource".

 

[adan_eslavo]

Hmm, nice catch. Investigating...
Maybe because I didn't defined any terrain for it. They are chosen by lua. I will add them and check what happens. Later.

 

[Ziad]

I don't think anyone knowing Arabic would laugh when reading a text saying "Most Gracious, Most Merciful", since the sentence "In the name of Allah/God, Most Gracious, Most Merciful" is called the Basmala and is recited before each sura of the Coran, but I agree that knowing exactly what is said is for the best.

Typical western imperialist transliteration.

I'm not familiar with Islamic words but I think you mean Bismallah (in the name of God). Basmalah sounds like "but noooooo". Now I'm actually laughing

 

[Ziad]

@Hinin Actually I don't think that's a bug. I mess around with IGE a bit and a lot of resources show that they can be upgraded through sea resources when it shouldn't be possible.

 

[Hinin]

Typical western imperialist transliteration

https://en.wikipedia.org/wiki/Basmala

The two versions seem to be accepted (wikipedia is far from being a reference, but still, it is the most accessible source right now... please do not generalize things that quickly...).

It appears effectively that Bismillah is the most correct and popular version, but there are still some debats about the exact origin of Basmala (it seems it is a contraction of the Islamic sentence "bi-smi llāhi r-raḥmāni r-raḥīm" while Bismillah is the first part of it).

Sorry if I used uncorrect things unknowingly... Let's go back to the project now.

 

[pineappledan]

I don't think anyone knowing Arabic would laugh when reading a text saying "Most Gracious, Most Merciful", since the sentence "In the name of Allah/God, Most Gracious, Most Merciful" is called the Basmala and is recited before each sura of the Coran, but I agree that knowing exactly what is said is for the best.

what Adan isolated was just one word though. I wanted to make sure that that word was appropriate, or at least a noun, or at least a full word. If the flag for a unit was the Arabic word for “of” or some random, meaningless word within a larger sentence.

Hell it could have been a word fragment; none of us can read Arabic. If that had said “the most splendid and serene republic”, we could have pulled “-endid” and not have known

 

[adan_eslavo]

@Hinin Actually I don't think that's a bug. I mess around with IGE a bit and a lot of resources show that they can be upgraded through sea resources when it shouldn't be possible.

Maybe post it to VP Github?

@pineappledan Look into TextChanges.sql file on github, please.
What about Wat or Waag? Anyone confirmed those bugs?

 

[Blue Ghost]

Okay, I'm stuck on the Corsair CTD. I traced the issue to the unit model part of the SQL, but beyond that, I have no idea what could be causing the crash, or how to investigate further. Can anyone help?

@pineappledan: To confirm, you're fixing all the Civilopedia issues, right? So I'll stick to fixing up the code?

And again, can all bug reports please go on Github?

 

[pineappledan]

@Blue Ghost yeah i guess I’m the text guy now. Works for me, everything will have a unified ‘voice’.

@adan_eslavo i have updated the text changes sql. I deleted entries for Spanish mission and conquistador; we didn’t change anything that warranted rewriting the texts.

Hacienda notes the +1 faith from missions, and all we changed wrt conquistador is we made their vision stay on upgrade

I miss your Old icon, it’s hard to retrain my eye to find your posts; your new icon has a colour balance too close to @Ziad’s

 

[Giza]

I just started playtesting this mod. This is a very nice addition to VP. Great job ! It's much appreciated.

I found a bug with Siam and posted on it GitHub.

 

[Infixo]

Okay, I'm stuck on the Corsair CTD. I traced the issue to the unit model part of the SQL, but beyond that, I have no idea what could be causing the crash, or how to investigate further. Can anyone help?

I ran the mod to see that CTD.
It happens within game engine, not even the DLL. Must be a model iself. Use another model to test if all sql settings are ok.

 

[adan_eslavo]

@Infixo do you know some event triggered by gifting unit from cs? I found one whe you gift them unit but it doesn't work the other way.