Assertive Assert?

[codiac]

AIUI an assert is used to check if a condition has a valid value, or is in a valid range, etc. How is this counter not being zero invalid or unusual?

It's annoying because when I'm testing stuff I use the world builder, an Assert DLL, and I restart the game a lot and this always stops the game from loading

IMO Even if I wanted to use it during a normal game it's still valid and should not be asserted to be zero.

Assert Failed
File: DLLSources\CvGameSavegame.cpp
Line: 380
Func: CvGame::read
Expression: getWorldBuilderOpeningCounter() == 0
Message: World Builder was opened 1 times
----------------------------------------------------------

 

[Nightinggale]

This assert is safe to ignore. It is purely used when loading savegames attached to bug reports to alert developers that world builder has been used. It is possible to introduce bugs with WB, which would otherwise not occur, such as giving natives ocean going ships. Yes we had a bug report because somebody did that and the natives crashed the game when arriving in Europe and the code tried to access the non-existing king.

It's possible that we should find a better way to do this because asserts are encouraged to use and it shouldn't be annoying like this. For now you can comment out/delete this specific line. The assert message is kind enough to tell precisely which line is triggering.

 

[codiac]

Yeah I did eventually comment it out

While I have your attention I noticed that if you attack a ship in a native village with a land unit you don't seem to be able to destroy it or get any XP for damaging it, is that deliberate?

 

[Nightinggale]

I noticed that if you attack a ship in a native village with a land unit you don't seem to be able to destroy it or get any XP for damaging it, is that deliberate?

That's intentional because ships are overpowered compared to land units. It's to avoid the cheat of letting a ship be the defender of a colony and then a single ship can fight off an entire army.

 

[codiac]

That's intentional because ships are overpowered compared to land units. It's to avoid the cheat of letting a ship be the defender of a colony and then a single ship can fight off an entire army.

Not sure I get this. My army unit doesn't get any XP even though the ship is damaged and driven away. You risk losing your army for no XP

 

[Nightinggale]

I added a reminder to investigate this claim later: https://github.com/We-the-People-civ4col-mod/Mod/issues/1166