Bug Reports

[Mesix]

I'm off work for the next three days. It is difficult for me to find time to play games and read forums when I am at home. I will check back when I am at work on Saturday night though.

Thanks for your help. The difference between a good mod and a great mod is support for problems like this.

 

[Mesix]

BTW...the major difference between Unclethrill's laptop and mine is that his runs Ubuntu and mine shipped with a virus called Vista. Maybe that is part of the problem.

 

[phungus420]

The varying issues with Vista aside, it doesn't cause any known problems with LoR. I was just testing out the new installer over on my friends computer, which is a laptop with Vista, and things ran fine on it. Anyway I have forwarded the issue to folks who are more familiar with debugging software, as I don't do this as a profession, and all the coding I know has been learned from Google I completely understand about time issues and all that, it's also not your responsibility to debug my mod. But if you have time please check in on that thread I linked to in the BUG mod forums and see if anything useful comes to light.

 

[bestbrian]

I'm off work for the next three days. It is difficult for me to find time to play games and read forums when I am at home. I will check back when I am at work on Saturday night though.

Thanks for your help. The difference between a good mod and a great mod is support for problems like this.

Nice job.

 

[unclethrill]

When I start a custom game with all the choices on from Barbarian world to the bottom on the list, I start with a settler and warrior on one square and either a scout or warrior (depending on techs) on another square. When I regenerate the map from either <alt>-O or from the menu choice, the warrior that starts on the same square as the settler goes away.

Meaning, if I regenerate the map then I lose the extra starting unit.

 

[Snofru1]

I have played a game of LoR 0.9.8b until 1993 and I just can´t win.

I have reached the domination threshold - nothing happens.
I have 3 legendary cities - nothing happens.
I have finished the space ship - there is no button to start it.

What could be going on here?

All victory conditions are on. I am playing LoR in German if that matters at all...

 

[Bracasse]

Hello everybody !

I' m french and I don't speak english very well. I read it, but not really write it...

I should try...

I play LoR since yesterday. I like it. Congratulations.

I'm on Vista and i play without problem. But I have a message on the first tour, and many others during the game. I don't know why and there isn't other effects on the play.

This is the first message :
Error in GameStart event handler <bound method RevolutionInit on GameStart of <RevolutionInit. Revolutioninit instance at 0x20965FA8

...
I don't understand. But I'm afraid other problems should appear after some hours of game.

Can you help me ?

Sorry for my english...

 

[phungus420]

@Bracasse

No idea, haven't seen that error before. Though the loading done through RevolutionInit.py is going to be changed significantly shortly. So I'm not going to worry about that unless the problem persists with next patch.

@Snofru1

That sucks. I have no idea how I could have broken Victories. Hmmm. That's a wierd one, but certainly a huge problem I need to correct. Unfortunately I have christmas stuff to deal with the next couple of days, and will not be able to fix this until I after Boxing Day.

 

[phungus420]

Here is a hotfix for the victories issue:

http://forums.civfanatics.com/showpost.php?p=8755241&postcount=32

 

[Snofru1]

I am sorry Phungus, I definitely didn´t want to disturb your Christmas activities !

Thanks a lot for the hotfix, I get an instant cultural victory now, and reloading an earlier save I also get the Domination victory !

As you´ve written in the other thread there is still no launch button for the space ship.

Enjoy your holidays, I anyway enjoyed playing this great game!

 

[phungus420]

@Mesix and Bracasse

I believe the new 0.9.8c build should fix the user specific bugs you guys have reported. If they do not, please let me know and we'll go ahead and dig into things more and fix them. In the unlikely event they are not corrected in the new build, I'd like to get these bugs squashed even if they are user specific; just because you guys are the only ones who have reported them, doesn't mean you're the only ones who have experienced them.


@Everyone 0.9.8c released

It fixes the major issue with 0.9.8b where victories were broken, so you can now win games again when playing LoR

Sorry about the bug, that was a major one and it bothers me when stuff like that slips through, but it's all part of the development process. Currently though, other then the previously noted fact that multiplayer does not work, 0.9.8c is totally bug free. So if you find anything please report it.


Download Legends of Revolution 0.9.8c full version

Download LoR 0.9.8c (light) -aesthetic components like ethnic unit and city art removed

 

[SHS`]

There seems to be a minor bug with the full installer (I let the install uninstall 0.9.8b btw) in that the shortcuts for LoR etc are dumped into the user profiles start menu "Programs" folder, rather than within a sub-folder named "Legends of Revolutions". In Windows 7 x64 if that makes any difference...

 

[phungus420]

Well the start menu shortcut creation takes you to a page where you can put them in any folder in the Start Menu Programs directory. But I also set up new logic since the 0.9.8b install where it automatically sets it's installation to be in the Firaxis folder of the Start Menu Programs directory if that folder exists. Specifically the logic is such for the creation of the Start Menu Shortcuts:

   Function preStartMenu

	${Unless} ${SectionIsSelected} ${Section4}
		Abort
	${EndUnless}
	Push $0
	StrCpy $0 "$SMPROGRAMS\Firaxis Games"
	${If} ${FileExists} $0
		StrCpy $0 "${FIRAXIS}\${NAME}"
		StrCpy $StartMenuFolder $0
	${Else}
		StrCpy $StartMenuFolder ${NAME}
	${EndIf}
	Pop $0
	
  FunctionEnd

  Section "Start Menu Shortcut" Section4
	!insertmacro MUI_STARTMENU_WRITE_BEGIN Application
	Call preStartMenu
	CreateDirectory "$SMPROGRAMS\$StartMenuFolder"
	CreateShortCut "$SMPROGRAMS\$StartMenuFolder\${NAME}.lnk" "$INSTDIR1\Civ4BeyondSword.exe" "mod=$\"${MOD_LOC}$\"" "$INSTDIR\Mods\${MOD_LOC}\${RAW_ICON}" 0
	WriteINIStr "$SMPROGRAMS\$StartMenuFolder\${SHORT_NAME} Info.url" "InternetShortcut" "URL" "${URL}"
	CreateShortCut "$SMPROGRAMS\$StartMenuFolder\Uninstall.lnk" "$INSTDIR1\Mods\${MOD_LOC}\Uninstall.exe"
	!insertmacro MUI_STARTMENU_WRITE_END
	WriteRegStr ${USER_REG_ROOT} "Software\Microsoft\Windows\CurrentVersion\Uninstall\${SHORT_NAME}StartMenu" "StartMenuFolder" "$SMPROGRAMS\$StartMenuFolder"
   SectionEnd

The ${STUFF} instances are constants set by me, such as ${NAME} is "Legends of Revolution", the $SMPROGRAMS is a variable reserved by NSIS that indicates the Start Menu Programs folder on your computer (current user). Anyway I can't see how this could be messing up. When you select the option to install start menu shortcuts you get taken to the Start Menu shortcut creation setup window correct?

 

[phungus420]

Oh, I think I see why. If you don't have a Firaxis folder in your Start Menu Programs directory, the value of the $StartMenuFolder variable is set incorectly, so it's just "", ie nothing.

It should be

	${Else}
		StrCpy $StartMenuFolder "${NAME}"
	${EndIf}

instead of

	${Else}
		StrCpy $StartMenuFolder ${NAME}
	${EndIf}

For some reason NSIS requires you not to use "" quotation marks when assigning a variable a value that's contained within one of reserved variables (like $0, $R1, etc), but requires you to use "" quotation marks when setting the variable's value to something other then a reserved variable.

This isn't what I would consider a real bug (though there is a bug in the install script code), because the user can easily still create a start menu shortcut folder (they are taken to an install page where they are prompted to do so). It is nice to know about it though, since I would never have noticed. Thanks for the report, Just to make sure this is correct, please check this test install script and see if it behaves properly.

 

[SHS`]

Stop fixing bugs so fast! Kidding, kidding, kidding...

But yeah, that was why it failed as my Civ4 Complete doesn't install any start menu shortcuts and was just posting why the logic failed. Anyway, the script tester installs as it should. I know I can move the shortcuts around but installers dumping stuff into the start menu programs root is against MS's Windows usability guidelines (even though they themselves flout it... a certain version of Office (2003 IIRC) is guilty for example!).

 

[phungus420]

Does Civilization Complete put the BtS start menu shortcuts in any particular directory? I'm wondering if I should repackage the 0.9.8c release for this, it's so minor, but there are alot of players who use complete, and most people don't bother setting a start menu shortcut folder when installing, so it's a good idea to have it do so automatically anyway.

 

[SHS`]

I've got Civ4 Gold (Vanilla+Warlords) and Civ4 Complete (Vanilla+Warlords+BtS) and both of them never installed any start menu shortcuts nor give the option to... always thought it was a bit odd, but ho-hum! I wouldn't lose any sleep over it and it can be fixed for 0.9.9...

 

[phungus420]

Actually that turned out to be pretty serious, as it'll cause LoR's uninstaller to uninstall all shortcuts in your main Start Menu Shortcuts folder. I'm taking down the download until I fix that.

Edit:
Nevermind it doesn't, at least it didn't on my computer. The uninstaller tried to, but windows didn't let it. Either way I'm updating the installer so this doesn't occur. I can't be sure other users wol't have that problem.

 

[JustOneMoreTurn]

Actually that turned out to be pretty serious, as it'll cause LoR's uninstaller to uninstall all shortcuts in your main Start Menu Shortcuts folder. I'm taking down the download until I fix that.

Edit:
Nevermind it doesn't, at least it didn't on my computer. The uninstaller tried to, but windows didn't let it. Either way I'm updating the installer so this doesn't occur. I can't be sure other users wol't have that problem.

Phungus, thanks for all the work that you do on this project. I do appreciate it and your quick attention to the bugs. I'm sure there are many of us here who feel the same.

Cheers and a happy new year to you and yours!

 

[SHS`]

Sorry phungus420... it seems the installer for 0.9.8c+ is b0rked too.

It can read/write the shortcut for the DE (German) help file... ran installer as admin on Win7.