WildWeazel
Carthago Creanda Est
I never put in my two cents regarding the UX of the Christmas light feature, so here goes:
A more informative UI is good, but let's remember that the inspiration for the whole thing was that it's hard to see which units are ready to attack. Since you're looking for something that can attack, this would be best visually represented by the unique presence of something on only those units. I don't know that having several different states combining colors and icons really helps in that regard, because then you have to parse what they mean instead of just being drawn to the one that stands out. Interpreting a symbol is a higher mental load than seeing whether there is one or not.
IMO it would be more effective to simplify this down to one icon which indicates that a unit can still perform its action (whether that's attack, intercept, or start a job). I do like Erlend's idea of making the text more specific, as that could provide more information without visually cluttering the space for the attack symbol. In other words: if you want to know what a specific unit is doing, reading the text or even interpreting multiple symbols is fine. But if you just want to see if anything in this stack can attack, spotting the unit with a symbol is much faster.
A more informative UI is good, but let's remember that the inspiration for the whole thing was that it's hard to see which units are ready to attack. Since you're looking for something that can attack, this would be best visually represented by the unique presence of something on only those units. I don't know that having several different states combining colors and icons really helps in that regard, because then you have to parse what they mean instead of just being drawn to the one that stands out. Interpreting a symbol is a higher mental load than seeing whether there is one or not.
IMO it would be more effective to simplify this down to one icon which indicates that a unit can still perform its action (whether that's attack, intercept, or start a job). I do like Erlend's idea of making the text more specific, as that could provide more information without visually cluttering the space for the attack symbol. In other words: if you want to know what a specific unit is doing, reading the text or even interpreting multiple symbols is fine. But if you just want to see if anything in this stack can attack, spotting the unit with a symbol is much faster.