Courthouse bugs CvC36

[liosalpha]

So I made the Mesopotamian religious world wonder Hammurabi stele of law, giving me a free courthouse in all the cities. But those courthouses are not recognized as "fulfilled requirement for the "forbidden palace" , "district courthouse" and or "Subprime court"
I can build other things like the bailiwick, law school, law firm ect.

When I turn on hidden wonders it tell me is need 0/10 courthouses (and other nrs but I always have 0 courthouses build)

 

[Dancing Hoskuld]

Indeed it should be giving you a free Courthouse in every city and they should count towards the requirements for those other buildings.

The XML looks fine so @TB any ideas?

 

[liosalpha]

Just some more info...I don't think its the wonder. I tried to remove the wonder by the world edit, give the game a turn to update and than build them manually (like normal) But still those 3 wonders say I have 0 courthouses (after some turns) , when I have more then 20 build.

 

[Dancing Hoskuld]

The XML for all those looks fine as well.

 

[Taxman66]

I don't know that area of the tech tree by heart, but perhaps you have built the wonder giving you courthouse before you have the tech for courthouse itself?

 

[liosalpha]

Yea that is true. Hammurabi stele of law an era before the courthouse.
Hammurabi stele of law is mid sedimentary lifestyle (it needs dualism witch is by the oracle wonder)
Courthouses unlock in mid classical era. With codes of law.

But that does happen with some other wonders as well, I think.
(Eifel tower and broadcasting towers...)

 

[Thunderbrd]

Indeed it should be giving you a free Courthouse in every city and they should count towards the requirements for those other buildings.

The XML looks fine so @TB any ideas?

I'll have to look into the code to get some theories on this.

When the wonder was removed and the courthouses 'rebuilt' were they built in-game or were they placed by worldbuilder?

 

[liosalpha]

I build them in game.. not with world edit.

 

[Dancing Hoskuld]

I don't know that area of the tech tree by heart, but perhaps you have built the wonder giving you courthouse before you have the tech for courthouse itself?

Yea that is true. Hammurabi stele of law an era before the courthouse.
Hammurabi stele of law is mid sedimentary lifestyle (it needs dualism witch is by the oracle wonder)
Courthouses unlock in mid classical era. With codes of law.

But that does happen with some other wonders as well, I think.
(Eifel tower and broadcasting towers...)

It happens with a lot of wonders. It is why they are wonders. They do give the building early.

Free buildings are given without regard to the buildings requirements.

 

[Thunderbrd]

Free buildings are given without regard to the buildings requirements.

As of last night's commit, this is only 'mostly' true. ConstructConditions now do apply and generally only get checked at the time the free building would be added. This means we need to be careful to check uses of the constructcondition tag on buildings we intend to set to be given for free from any sources.

 

[Dancing Hoskuld]

As of last night's commit, this is only 'mostly' true. ConstructConditions now do apply and generally only get checked at the time the free building would be added. This means we need to be careful to check uses of the constructcondition tag on buildings we intend to set to be given for free from any sources.

There is no constructcondition tag on Courthouses. The only restrictions are

			<!-- Prerequisites -->
			<PrereqTech>TECH_CODE_OF_LAWS</PrereqTech>
			<iPrereqPopulation>6</iPrereqPopulation>
			<Bonus>BONUS_FURNITURE</Bonus>
			<PrereqBonuses>
				<Bonus>BONUS_WOOD</Bonus>
				<Bonus>BONUS_BAMBOO</Bonus>
				<Bonus>BONUS_TIMBER</Bonus>
				<Bonus>BONUS_BRICKS</Bonus>
				<Bonus>BONUS_CEMENT</Bonus>
				<Bonus>BONUS_MARBLE</Bonus>
			</PrereqBonuses>

and all of these should be ignored in the case of buildings being given free.

On the other hand building that require river or coast should only be given free to cities on a river or coast respectively. Those are boolean tags.

 

[Thunderbrd]

So you think it would be a good thing to add those river and coast conditions to the qualification check?

 

[Toffer90]

So you think it would be a good thing to add those river and coast conditions to the qualification check?

Think how ridicolous it would be if a wonder gave Harbor or drydock building for free to inland cities. ^^

Yeah this would be the first place to use the new constructcondition functionality.

The pyramid gives free irrigation channel.
irrigation channel should have river as a constructcondition.
Rivers are defined as routes.

 

[Dancing Hoskuld]

So you think it would be a good thing to add those river and coast conditions to the qualification check?

It would fix the problem with The Pyramids giving irrigation channel to all cities when those without a river. That was the original intent when I changed it from free granary when we added the Strategic Grain Reserve.

 

[Taxman66]

I know, I mention it because I once remembered running into a situation where a wonder gave me something early, that was a prereq. to do so something else but I couldn't do it until I got the base tech anyway. It was a some time ago, I'm just going off a vague memory... Or I could be completely off my rocker.

 

[Noriad2]

It would fix the problem with The Pyramids giving irrigation channel to all cities when those without a river. That was the original intent when I changed it from free granary when we added the Strategic Grain Reserve.

I still think that giving Irrigation channels to Pyramids is illogical. The purpose of the Pyramids was to elevate the Pharaoh to the status of a living god. Thus there should be a political and/or religious bonus to it. Even if the Pyramids would just give +1 free priest specialist in every city, that would be more fitting.

The free irrigation canals should then be added to the Great Bath wonder. As it actually took some major water engineering works to fill it.

 

[Dancing Hoskuld]

I still think that giving Irrigation channels to Pyramids is illogical. The purpose of the Pyramids was to elevate the Pharaoh to the status of a living god. Thus there should be a political and/or religious bonus to it. Even if the Pyramids would just give +1 free priest specialist in every city, that would be more fitting.

The free irrigation canals should then be added to the Great Bath wonder. As it actually took some major water engineering works to fill it.

There are far too many wonders that just add a priest or adjust priest values.

The thing about Egypt at that time was that they did not get earthquakes of flash flooding that affected the other nations and it was the gods and pharaoh that kept this order and prevented the chaos that afflicted other realms.

Perhaps now that we have the properties we can use them. Possibilities could be

• reduction in crime or revolutionary sentiment by each priest specialist
• increase in cultural stability by each priest specialist
• flat change in one or more of crime, revolutionary sentiment and cultural stability in each city

I agree that the irrigation canals would suit the Great Bath better.

 

[Thunderbrd]

There are far too many wonders that just add a priest or adjust priest values.

The thing about Egypt at that time was that they did not get earthquakes of flash flooding that affected the other nations and it was the gods and pharaoh that kept this order and prevented the chaos that afflicted other realms.

Perhaps now that we have the properties we can use them. Possibilities could be

• reduction in crime or revolutionary sentiment by each priest specialist
• increase in cultural stability by each priest specialist
• flat change in one or more of crime, revolutionary sentiment and cultural stability in each city

I agree that the irrigation canals would suit the Great Bath better.

I agree with that statement as well. I'm thinking revolutionary sentiment would be too specific to the rev mod for being useful.

But I can see the other two being a good way to go. And ultimately, yes, the point of building them, for the ones the Egyptians did actually build, would've been to enhance national pride and to give the people an unshakable faith in the power of the rulership to accomplish any task.

I should consider that when I get to working with the morale mod - they should give the nation a solid morale bonus throughout all its units. But morale really isn't well modeled yet so we can leave it off the troops for now.

Perhaps the best thing to do, since imo the Pyramids should be one of the most powerful and desired wonders in the game given their notoriety among real world wonders, is to do all of the above. The granaries and irrigation canals make no sense at all but they SHOULD be impressive and desireable! I'd also suggest to have them start a golden age given that there are few to no wonders that do so in the Ancient era and once completed, it would've been a major inspiration to the people of Egypt to have these impressive structures among them.

 

[Dancing Hoskuld]

I agree with that statement as well. I'm thinking revolutionary sentiment would be too specific to the rev mod for being useful.

But I can see the other two being a good way to go. And ultimately, yes, the point of building them, for the ones the Egyptians did actually build, would've been to enhance national pride and to give the people an unshakable faith in the power of the rulership to accomplish any task.

I should consider that when I get to working with the morale mod - they should give the nation a solid morale bonus throughout all its units. But morale really isn't well modeled yet so we can leave it off the troops for now.

Perhaps the best thing to do, since imo the Pyramids should be one of the most powerful and desired wonders in the game given their notoriety among real world wonders, is to do all of the above. The granaries and irrigation canals make no sense at all but they SHOULD be impressive and desireable! I'd also suggest to have them start a golden age given that there are few to no wonders that do so in the Ancient era and once completed, it would've been a major inspiration to the people of Egypt to have these impressive structures among them.

If you build the Sphinx and The Pyramids in the same city you get The Valley of the Kings which gives you a golden age.

 

[Thunderbrd]

Not enough. They pyramids may well should be the BEST wonder in the game period. But if you're saying that's a reason to not give a golden age then how about giving them a golden age length modifier in preparation FOR the valley of the kings if the player can get it?