Zlatko
CIW
That worry me.
What i want to do now:
I am download All ANM versions, but i will just use codes from ANM 2.1 because this is last version with CvEventManager.py and ANM 2.2 which have codes from #199th post in this thread.
Creatures in War [CIW] [Mod in the making] [Need some support and ideas]
- Thread starter Zlatko
- Start date
That worry me.
What i want to do now:
I am download All ANM versions, but i will just use codes from ANM 2.1 because this is last version with CvEventManager.py and ANM 2.2 which have codes from #199th post in this thread.
Zlatko
CIW
Codes from ANM 2.1
CvEventManager.py:
CvEventManager.py:
Spoiler :
Zlatko
CIW
Codes from ANM 2.1 continuing from 670th line, in last post codes end in 669th line.
CvEventManager.py:
CvEventManager.py:
Spoiler :
Zlatko
CIW
Codes from ANM 2.1 continuing from 1325th line, in last post codes end in 1324th line.
CvEventManager.py:
This is end of codes in CvEventManager.py
CvEventManager.py:
Spoiler :
This is end of codes in CvEventManager.py
Zlatko
CIW
I plan to use this part of codes from CvEventManager.py:
804th-809th lines:
851st-869th lines:
872nd-925th lines:
I will copy this codes in my CvEventManager.py.
Is this okay?
804th-809th lines:
Spoiler :
851st-869th lines:
Spoiler :
872nd-925th lines:
Spoiler :
I will copy this codes in my CvEventManager.py.
Is this okay?
Zlatko
CIW
I do what i say and i get this (ALL IMAGES ARE IN SPOILERS):
BBM
Ok, this work good without errors.
Fusion Nova (similar like The_J Planet Buster) when explode its destroy (destroyed range in City radius 1) everything and convert it in water terrain.
I get errors, look.
Plague Bringer, its work without errors:
Tactical Fusi (similar like Fusion Nova, just destroy one terrain plot on which is launched)
i get errors for this too.
Y.A.M. (this nuke take over enemy city, if you launch it, and if Y.A.M. explode, this nuke automatically capture city for you, like as mind control)
And for this i get errors.
All nukes do what they real do, but some nukes show errors. - this is problem.
BBM
Ok, this work good without errors.
Spoiler :
Fusion Nova (similar like The_J Planet Buster) when explode its destroy (destroyed range in City radius 1) everything and convert it in water terrain.
I get errors, look.
Spoiler :
Plague Bringer, its work without errors:
Spoiler :
Tactical Fusi (similar like Fusion Nova, just destroy one terrain plot on which is launched)
i get errors for this too.
Spoiler :
Y.A.M. (this nuke take over enemy city, if you launch it, and if Y.A.M. explode, this nuke automatically capture city for you, like as mind control)
And for this i get errors.
Spoiler :
All nukes do what they real do, but some nukes show errors. - this is problem.
Dancing Hoskuld
Deity
A couple of points on python that I have not seen mentioned.
1) leading white space is part of the code - I have found that sometimes when I compare code the software I am using will say that they are the same but one will have an extra tab or space in it and so the result falls over with an error.
2) tabs and spaces are not equivalent - just because you have tabs set to 5 spaces on your machine does not mean that I have it set the same on my machine. Mixing spaces and tabs may work on your machine when you run civ but will fail on my machine.
iArcologyCityID is defined in the onCityRazed function. It is set if the city has any of the Arcology buildings in it. If you do not have those buildings but may in the future you will need to add the bit setting this value otherwise the values is -1. Since it is only used to determine the type of city ruins that will be placed on the plot you can probably remove that if segment completely.
1) leading white space is part of the code - I have found that sometimes when I compare code the software I am using will say that they are the same but one will have an extra tab or space in it and so the result falls over with an error.
2) tabs and spaces are not equivalent - just because you have tabs set to 5 spaces on your machine does not mean that I have it set the same on my machine. Mixing spaces and tabs may work on your machine when you run civ but will fail on my machine.
iArcologyCityID is defined in the onCityRazed function. It is set if the city has any of the Arcology buildings in it. If you do not have those buildings but may in the future you will need to add the bit setting this value otherwise the values is -1. Since it is only used to determine the type of city ruins that will be placed on the plot you can probably remove that if segment completely.
Zlatko
CIW
I will tell what i am do.
First i am copy all XML and Python files from BTS in my mod (when i create mod) and i am modify that files.
After i am import Arcologies from NEXT WAR in my mod. After that i am import nukes. After that i get errors when nukes explode.
Now, about one hour ago i am create new mod (NUKES mod) in which i am test this crazy nukes (again copy all BTS files - XML and Python), i am add all which is necessary and this is work in this new created mod (NUKES mod). Nukes explode without errors and with their abilities all works nice! And i came to the conclusion that is problem - arcology in python.
In this (NUKE mod) i am only add nukes.
What to do? And one question, which program used for .py edit/merge?
platyping
Sleeping Dragon
All you need is just the section in def onNukeExplosion(self, argsList):
Effects:
If nuked plot is a city:
1) Take over the city
2) Attempts to kill units within 1 radius
3) Remove fallout if any within 1 radius
Things to Fix
1) It does NOT check ownership of city.
You can actually nuke your own teammate city you know... and take over it as a result.
2) numUnits refer to number of units in the nuke plot, yet it is trying to kill same amount of units in surrounding plots.
It is highly possible that there isn't that many units in surrounding, resulting in pUnit is None giving all sorts of errors.
3) Both radius of 1 are hard coded in python but you may want to change it to be based on the Nuke Radius as defined in XML
4) Codes only triggered when the nuked plot itself is the city plot. A.I. definitely wont understand and probably just nuke surrounding plot if that was a better location.
Effects:
1) Change all plots within 0 radius from peaks/hills to land
2) Change all plots within 0 radius to coastal terrain
Things to Fix
1) Similar to above, change radius to XML nuke radius is better unless intended, although for this case the radius is actually... 0, then why bother to use a loop
2) Totally redundant to change peaks/hills to land when eventually they are all turning to coast
3) It should be changing plot type to ocean rather than changing terrain to coast.
The latter means that if you nuke a plot in the middle of pacific ocean, you suddenly get a patch of coast there.
4) Again, this is bad idea for A.I. Sometimes it may be good to nuke your own plot when there is a huge SOD on it, but if the end result is that it will turn my only uranium mine there or my capital into ocean plot, I will think twice about it.
As for the other 2 nukes, unless you have those poison gas features, no doubt they will create problems for you.
Code:
if (gc.getInfoTypeForStringWithHiddenAssert("UNIT_TURN") > 0):
if (pNukeUnit is not None and pNukeUnit.getUnitType() == gc.getInfoTypeForString('UNIT_TURN')):
if (pPlot.isCity()==true):
iPlayer = pNukeUnit.getOwner()
pPlayer = gc.getPlayer(iPlayer)
pCity = pPlot.getPlotCity()
pPlayer.acquireCity(pCity,false,false)
iX = pPlot.getX()
iY = pPlot.getY()
for iiX in range(iX-1, iX+2, 1):
for iiY in range(iY-1, iY+2, 1):
numUnits = pPlot.getNumUnits()
for e in xrange(numUnits,0,-1):
pUnit = pPlot.getUnit(e)
pUnit.kill(false, -1)
pNukedPlot = CyMap().plot(iiX,iiY)
if (pNukedPlot.getFeatureType() == gc.getInfoTypeForString('FEATURE_FALLOUT')):
pNukedPlot.setFeatureType(-1, -1)Effects:
If nuked plot is a city:
1) Take over the city
2) Attempts to kill units within 1 radius
3) Remove fallout if any within 1 radius
Things to Fix
1) It does NOT check ownership of city.
You can actually nuke your own teammate city you know... and take over it as a result.
2) numUnits refer to number of units in the nuke plot, yet it is trying to kill same amount of units in surrounding plots.
It is highly possible that there isn't that many units in surrounding, resulting in pUnit is None giving all sorts of errors.
3) Both radius of 1 are hard coded in python but you may want to change it to be based on the Nuke Radius as defined in XML
4) Codes only triggered when the nuked plot itself is the city plot. A.I. definitely wont understand and probably just nuke surrounding plot if that was a better location.
Code:
if (gc.getInfoTypeForStringWithHiddenAssert("UNIT_FUSION_NUKE") > 0):
if (pNukeUnit is not None and pNukeUnit.getUnitType() == gc.getInfoTypeForString('UNIT_FUSION_NUKE')):
iX = pPlot.getX()
iY = pPlot.getY()
for iXLoop in range(iX - 0, iX + 1, 1):
for iYLoop in range(iY - 0, iY + 1, 1):
pPlot = CyMap().plot(iXLoop, iYLoop)
if (( pPlot.isPeak()==true ) or (pPlot.isHills()==true)):
pPlot.setPlotType(PlotTypes.PLOT_LAND, True, True)
pPlot.setTerrainType(gc.getInfoTypeForString( "TERRAIN_COAST" ), 1, 11) Change all plots within 0 radius from peaks/hills to land
2) Change all plots within 0 radius to coastal terrain
Things to Fix
1) Similar to above, change radius to XML nuke radius is better unless intended, although for this case the radius is actually... 0, then why bother to use a loop
2) Totally redundant to change peaks/hills to land when eventually they are all turning to coast
3) It should be changing plot type to ocean rather than changing terrain to coast.
The latter means that if you nuke a plot in the middle of pacific ocean, you suddenly get a patch of coast there.
4) Again, this is bad idea for A.I. Sometimes it may be good to nuke your own plot when there is a huge SOD on it, but if the end result is that it will turn my only uranium mine there or my capital into ocean plot, I will think twice about it.
As for the other 2 nukes, unless you have those poison gas features, no doubt they will create problems for you.
Zlatko
CIW
I am fix it!!!
I am make mistake. I am forget to copy this part of code from NEXT WAR mod:
and this make errors.
Yes, i am agree with you platy. This nukes sounds good, but everything which you are write in Things to Fix (BOTH), you are right. AI nuked my capital and destroy my source of Aluminum (only which i had), and it's very unreal if i send nuke in ocean which is far away from land, this make ocean in coast (it's crazy and stupid).
"Totally redundant to change peaks/hills to land when eventually they are all turning to coast" - Absolutely, this part of code is the excess:
if i am understand you.
This now work, i am try everything. Send nuke on cities, ocean, etc etc. I am not get any errors
But one more thing is stupid. I think that i send Fusion Nova or Tactical Fusi on FEATURE_ICE (and nuke don't destroy this feature). This is one more thing for fix, but that is not very important now.
I will start to import your promotions in my mod.
THANK YOU EVERYONE FOR HELP, BECAUSE YOU ARE SEPARATE YOUR TIME FOR ME!
I am make mistake. I am forget to copy this part of code from NEXT WAR mod:
PHP:
# Next War tracks cities that have been razed
self.iArcologyCityID = -1and this make errors.
Yes, i am agree with you platy. This nukes sounds good, but everything which you are write in Things to Fix (BOTH), you are right. AI nuked my capital and destroy my source of Aluminum (only which i had), and it's very unreal if i send nuke in ocean which is far away from land, this make ocean in coast (it's crazy and stupid).
"Totally redundant to change peaks/hills to land when eventually they are all turning to coast" - Absolutely, this part of code is the excess:
PHP:
if (( pPlot.isPeak()==true ) or (pPlot.isHills()==true)):
pPlot.setPlotType(PlotTypes.PLOT_LAND, True, True)This now work, i am try everything. Send nuke on cities, ocean, etc etc. I am not get any errors
But one more thing is stupid. I think that i send Fusion Nova or Tactical Fusi on FEATURE_ICE (and nuke don't destroy this feature). This is one more thing for fix, but that is not very important now.
I will start to import your promotions in my mod.
THANK YOU EVERYONE FOR HELP, BECAUSE YOU ARE SEPARATE YOUR TIME FOR ME!
Zlatko
CIW
Can someone tell me, where i can found some futuristic NAVAL units (not EE2 units pack [EE2 pack will be used as far away futuristic naval units, me need near futuristic naval units]; not Final Frontier space ships because i am import real space ships in game ;DDD ) ?
Zlatko
CIW
NEWS:
- Tech tree finished
- Units finished (not UU, not wild Units)
- Building finished (without Wonders, not UB)
- All Eras finished
- Platy promotions imported in game
- Platy traits imported in game (not all, i am import some old Platy traits)
- Mad nukes imported in game
- All Civilizations have their unique trait
- Gods of Old religions imported in game
- Tech tree finished
- Units finished (not UU, not wild Units)
- Building finished (without Wonders, not UB)
- All Eras finished
- Platy promotions imported in game
- Platy traits imported in game (not all, i am import some old Platy traits)
- Mad nukes imported in game
- All Civilizations have their unique trait
- Gods of Old religions imported in game
You've done an impressive amount of work and it will be interesting to see your mod.
Zlatko
CIW
Thank you Red Key.
Zlatko
CIW
DECISION:
- I am put space ships in mod, idea is fantastic, but with that idea comes problems.
- Spaceships can move all terrain + impossible terrain, but AI more like to load spaceships in transport and to unload spaceships on my island, continent whatever, AI only use spaceships for crossing seas and ocean if they want to pillage my land (if i am in War or AI vs AI war).
- If Land units which intercept enemies plains have more than 1 range AI don't want to build AIR units! It's mean for all mods, because all AI's land are covered with land units, because don't use more than 1 range in your mods.
- If settler can move all terrain AI don't want to use them. I don't know why it's some AI think.
QUESTION FOR READERS:
- Is normal if you have spaceships, to load them in transport, transported over sea and invade enemy land on this way? More real is if you have spaceship you can move every tile on map which you want.
- I will maybe remove spaceships from game, but i will not cut off some eras.
- I am put space ships in mod, idea is fantastic, but with that idea comes problems.
- Spaceships can move all terrain + impossible terrain, but AI more like to load spaceships in transport and to unload spaceships on my island, continent whatever, AI only use spaceships for crossing seas and ocean if they want to pillage my land (if i am in War or AI vs AI war).
- If Land units which intercept enemies plains have more than 1 range AI don't want to build AIR units! It's mean for all mods, because all AI's land are covered with land units, because don't use more than 1 range in your mods.
- If settler can move all terrain AI don't want to use them. I don't know why it's some AI think.
QUESTION FOR READERS:
- Is normal if you have spaceships, to load them in transport, transported over sea and invade enemy land on this way? More real is if you have spaceship you can move every tile on map which you want.
- I will maybe remove spaceships from game, but i will not cut off some eras.
Zlatko
CIW
I have one map script, i am converted for my mod and script works fine, but script have lots of forests almost on every tile. How i can reduce forest?
Here is map script:
Can this part of code reduce forest? Maybe iJunglePercent, iForestPercent, iHotForestPercent to set on lower value?
Here is map script:
Spoiler :
Can this part of code reduce forest? Maybe iJunglePercent, iForestPercent, iHotForestPercent to set on lower value?
Spoiler :
Zlatko
CIW
Thank you keldath, but that is not solve the problem.
I am solve the problem, i was looking and searching in file.
self.featureWoods = self.gc.getInfoTypeForString("FEATURE_FOREST")
I am search for this. And i am found this:
PHP:
def addWoodsAtPlot(self, pPlot, iX, iY, lat):
if pPlot.canHaveFeature(self.featureWoods):
pPlot.setFeatureType(self.featureWoods, -1)i am replace this with this:
PHP:
def addWoodsAtPlot(self, pPlot, iX, iY, lat):
if lat > 0.2:
if pPlot.canHaveFeature(self.featureWoods):
if self.forests.getHeight(iX, iY) <= self.iForestLevel:
pPlot.setFeatureType(self.featureWoods, -1)
else:
if pPlot.canHaveFeature(self.featureWoods):
if self.forests.getHeight(iX, iY) <= self.iHotForestLevel:
pPlot.setFeatureType(self.featureWoods, -1)and i am get what i am want
i am found this in Highland mapscript i am just copy from that of course i am replace self.featureForest with self.featureWoods.I am not experience programmer, i just have "C" knowledge + "Maybe luck".
I am not test map script yet i will test soon as possible, if i get some errors it's will be bad for me.
Zlatko
CIW
Can someone explain me something about mods versions. Alpha, Beta, Final Release, version 1.0, version 1.3, version 2.0 etc.
How I can determine?
How I can determine?
hehe thats a funny question.
alpha beta final
well :
beta - a pre release version - mainly for tests and stability
alpha one step before you release - after you finished what you wanted to fix in the beta.
final release - when you end your work on a mod and your not planing on getting out more updates.
v 1. ...1.3 - names for you to keep track of your work.
when i mod - i create a "version" to save my latest work - and i number it 0.1..0.2 ... so on,
when i release a mod - i call it version 1.0.
when i later add a patch to fix things - i name the patch with a version.
when i make a big update that changes and adds a lot of stuff - i call it - version 2 pr version 1.1.
good luck
alpha beta final
well :
beta - a pre release version - mainly for tests and stability
alpha one step before you release - after you finished what you wanted to fix in the beta.
final release - when you end your work on a mod and your not planing on getting out more updates.
v 1. ...1.3 - names for you to keep track of your work.
when i mod - i create a "version" to save my latest work - and i number it 0.1..0.2 ... so on,
when i release a mod - i call it version 1.0.
when i later add a patch to fix things - i name the patch with a version.
when i make a big update that changes and adds a lot of stuff - i call it - version 2 pr version 1.1.
good luck