ExtraModMod continued

[Tielby]

Heh, I almost never go smelting because I always go for GoH if I can. Not sure from a balance POV, though FFH2 tends to prefer deep research (which tech trading and proliferation hit, unfortunately, but that's a discussion for another day).

Same. But it doesn't seem to unbalance the owner of GoH, in relation to the civs that don't have it, IMHO.

 

[Qgqqqqq]

It's hard to tell. If you get late game with a decent sized empire in FFH2, it tends to be hard to lose, so it's hard to tell how much GoH is part of that vs. just being a indicator of a won game.

 

[lfgr]

Since notabug.org is broken, I moved the code repo here.

 

[Qgqqqqq]

Feature request: I like the 'Quick Domination' option, because the standard domination has such a high land area requirement. However, I feel the population requirement is too low - imo it should always be at least 50%.

Currently I'm competing with a runaway AI who looks likely to win domination under these settings, but I expect I will be able to match them on population. This leads to a scenario where theoretically we could both be at the winning threshold simultaneously.

 

[FireBlaze]

it's not possible to do terrain conditional workrate improvals in any efficient way, right? Was just thinking about how much of a hit to eco temples of hand can be for the illians with the +50% work rate for ice tiles.

 

[DuskTreader]

Maybe the winterborn race promotion could be used for this?

 

[lfgr]

it's not possible to do terrain conditional workrate improvals in any efficient way, right? Was just thinking about how much of a hit to eco temples of hand can be for the illians with the +50% work rate for ice tiles.

I like this idea, and I think tying it to the winterborn promotion is probably best. But it will be a bit of a hassle implementing it cleanly. I added it to the list.

Feature request: I like the 'Quick Domination' option, because the standard domination has such a high land area requirement. However, I feel the population requirement is too low - imo it should always be at least 50%.

Also a good idea, I noticed this before, too.

 

[MagisterCultuum]

I believe that it would be easy to make a promotion like Winterborn increase a worker's work rate regardless of terrain, but impossible (without some significant C++ changes) to make it only increase the unit's work rate when on specific terrains. It doesn't seem right to me that the Illians should be the best as building in deserts, plain, grasslands, jungles, etc.

You could also grant terrain specific workrate improvements by using python to switch out dummy promotions. That is how I ended up implementing the Arda system to make priests' spells stronger in areas dominated by faith in its god and weaker in areas dominated by faith in an opposing god. Just checking the terrain type to swap out promotions would be simpler and faster code that MagisterModmod uses for that.

You could easily give Winterborn a PyPerTurn effect and/or make it the prerequisite for a spell that can never actually be cast but whose PyPrereq checks the terrain type and then either adds or removes a dummy promotion which increase the unit's work rate.

I think the code you'd need for this could be as simple as this:
In CvSpellInterface.py

    def reqWinterbornWorkrate(pCaster, eSpell=-1):
        pCaster.setHasPromotion(gc.getInfoTypeForString('PROMOTION_WINTER_WORKER'), pCaster.plot().getTerrainType() == gc.getInfoTypeForString('TERRAIN_SNOW'))

in CIV4SpellInfos.xml

        <SpellInfo>
            <Type>SPELL_WINTER_WORKER</Type>
            <Description>TXT_KEY_SPELL_WINTER_WORKER</Description>
            <Civilopedia>TXT_KEY_SPELL_PLACEHOLDER_PEDIA</Civilopedia>
            <PromotionPrereq1>PROMOTION_WINTERBORN</PromotionPrereq1>
            <bAllowAI>1</bAllowAI>
            <bDisplayWhenDisabled>0</bDisplayWhenDisabled>
            <bIgnoreHasCasted>1</bIgnoreHasCasted>
            <AddPromotionType1>PROMOTION_WINTER_WORKER</AddPromotionType1>
            <bBuffCasterOnly>1</bBuffCasterOnly>
            <bNoInterruptUnitCycling>1</bNoInterruptUnitCycling>
            <PyRequirement>reqWinterbornWorkrate(pCaster, eSpell)</PyRequirement>
            <Effect>EFFECT_SPELL1</Effect>
            <Sound>AS3D_SPELL_HOPE</Sound>
            <Button>Art/Interface/Buttons/Spells/Whiteout.dds</Button>
        </SpellInfo>

in CIV4PromotionInfos.xml

        <PromotionInfo>
            <Type>PROMOTION_WINTERBORN</Type>
            <Description>TXT_KEY_PROMOTION_WINTERBORN</Description>
            <Sound>AS2D_IF_LEVELUP</Sound>
            <TerrainAttacks>
                <TerrainAttack>
                    <TerrainType>TERRAIN_SNOW</TerrainType>
                    <iTerrainAttack>10</iTerrainAttack>
                </TerrainAttack>
                <TerrainAttack>
                    <TerrainType>TERRAIN_TUNDRA</TerrainType>
                    <iTerrainAttack>10</iTerrainAttack>
                </TerrainAttack>
            </TerrainAttacks>
            <TerrainDefenses>
                <TerrainDefense>
                    <TerrainType>TERRAIN_SNOW</TerrainType>
                    <iTerrainDefense>10</iTerrainDefense>
                </TerrainDefense>
                <TerrainDefense>
                    <TerrainType>TERRAIN_TUNDRA</TerrainType>
                    <iTerrainDefense>10</iTerrainDefense>
                </TerrainDefense>
            </TerrainDefenses>
            <UnitCombats>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_ADEPT</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_ANIMAL</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_ARCHER</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_BEAST</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_DISCIPLE</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_MELEE</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_MOUNTED</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
                <UnitCombat>
                    <UnitCombatType>UNITCOMBAT_RECON</UnitCombatType>
                    <bUnitCombat>1</bUnitCombat>
                </UnitCombat>
            </UnitCombats>
            <Button>Art/Interface/Buttons/Promotions/Winterborn.dds</Button>
            <iMinLevel>-1</iMinLevel>
            <PyPerTurn>>reqWinterbornWorkrate(pCaster, -1)</PyPerTurn>
            <DamageTypeResists>
                <DamageTypeResist>
                    <DamageType>DAMAGE_COLD</DamageType>
                    <iResist>20</iResist>
                </DamageTypeResist>
                <DamageTypeResist>
                    <DamageType>DAMAGE_FIRE</DamageType>
                    <iResist>-10</iResist>
                </DamageTypeResist>
            </DamageTypeResists>
        </PromotionInfo>
        <PromotionInfo>
            <Type>PROMOTION_WINTER_WORKER</Type>
            <Description>TXT_KEY_PROMOTION_WINTER_WORKER</Description>
            <Sound>AS2D_IF_LEVELUP</Sound>
            <Button>Art/Interface/Buttons/Promotions/Winterborn.dds</Button>
            <iMinLevel>-1</iMinLevel>
            <bGraphicalOnly>1</bGraphicalOnly>
            <PyPerTurn>>reqWinterbornWorkrate(pCaster, -1)</PyPerTurn>
            <iWorkRateModify>100</iWorkRateModify>
            <PromotionNextLevel>PROMOTION_WINTERBORN</PromotionNextLevel>
        </PromotionInfo>

Of course, you could also make it more complicated to give different bonuses and penalties based on different terrains or features, maybe giving a minor bonus in Tundra or in Blizzards and a penalty in deserts.

 

[DuskTreader]

Another workaround would seem to be to give the Illians unique improvements that require snow tiles and are identical to standard improvements except that they require less work. This would deny the benefit to tolerant civs holding Illian cities, but that's probably ok.

 

[Qgqqqqq]

Another workaround would seem to be to give the Illians unique improvements that require snow tiles and are identical to standard improvements except that they require less work. This would deny the benefit to tolerant civs holding Illian cities, but that's probably ok.

This seems like it would have less impact on turn processing also.

 

[Tielby]

I can upload the save file if it helps, but... I'm playing Elohim (unrestricted leaders), and for some reason, I have a hunter that is casting Sanctuary at the start of the turn (207), before I have a chance to control any of my units. Is there something in EMM that gives a unit independent control of a world spell? That doesn't seem right.

 

[lfgr]

Thanks for the report, and yes, please upload a save.

 

[Tielby]

Thanks for the report, and yes, please upload a save.

Thanks!

 

[FireBlaze]

What about adding something like a -5 revolt risk to the Tower of Eyes wonder itself? Seems thematic and not overly strong, especially since something like the heroic/national epic give -3

 

[Akbarthegreat]

Is Rathus Denmora not eligible for Aeron's Chosen? I thought the requirement was level 6 recon unit with marksman ability; mine has reached level 8 but hasn't got it yet.

 

[Qgqqqqq]

I believe heroes can't become Aeron's Chosen.

 

[Akbarthegreat]

That wasn't it: I had a ghost get to level 7 but not get the promotion:

Spoiler :

But then many turns later, a different ghost who got to level 5 got the event

Spoiler :

 

[Tielby]

Bug report: This Freak unit that I just captured (using Command III) had, previously in the same turn, been given a disease by another unit in my stack (using Athame), even though it has the "Immune to Disease" promotion (from Mutate).

Do you want a save game?

 

[FireBlaze]

How do we feel about jungles converting to ancient forests under FotL? I think it happens in other forks and it feels properly thematic without being OP

e. How would we also feel about adding the Force damage type resistance to some existing promos like magic resistance? As-is magic missiles can trivialize some otherwise threatening encounters like the Horsemen
Also maybe having Magic Eyes persist until the start of your next turn, such that they can be spotted and are displayed for opponents so they know they've been scouted similarly to hawks?

 

[lfgr]

That wasn't it: I had a ghost get to level 7 but not get the promotion:

That's weird; the code says it should be a non-world-unit, non-temporary, and non-summoned unit of level 5 or higher. Maybe there is some way for ghosts to get the "summoned" flag?

How do we feel about jungles converting to ancient forests under FotL? I think it happens in other forks and it feels properly thematic without being OP

Should be fine balance-wise, and removing the need for bronze working seems thematic for EMM in particular. I'll add it to the list.

How would we also feel about adding the Force damage type resistance to some existing promos like magic resistance?

This might be on purpose, I'll have to check.

Also maybe having Magic Eyes persist until the start of your next turn

That's probably annoying to implement, unfortunately.