FreeBuilding

[Moriboe]

There's a mistake in InfoTooltipInclude.lua in AutoTips: the FreeBuilding column in the Buildings table refers to a building class, but the code refers to a building.

{"FreeBuilding"						, pBuildingInfo.FreeBuilding and Locale.ConvertTextKey(GameInfo.Building[COLOR="Red"]Classe[/COLOR]s[pBuildingInfo.FreeBuilding].Description) or false },

I have the line <FreeBuilding>BUILDINGCLASS_MEDICAL_LAB</FreeBuilding> in one of my wonders, which made the tech tree go

and made me go

... all because I didn't want to give up compatibility with CiVUP of course

 

[Thalassicus]

Thanks for pointing this out! I've fixed it for v8.3.

This means FreeBuilding and FreeBuildingThisCity are even more confusing attributes than I though!

I'm guessing FreeBuilding places an actual copy of the building in the city? FreeBuildingThisCity does not. A city with a Great Library does not actually get a Library, which can be confirmed by looking at the city's building list in the tuner. The game does some more complicated work behind the scenes.

More appropriate names would probably be ExtraBuildingClass and FreeBuildingClass, clarifying this difference. I wish we could fix problems like this directly.