Gaul should have double Mine Tourism but they made a mistake.

Brixter

Brixter

Warlord
Joined
Dec 18, 2022
Messages
170
Gaul was meant to have double tourism from mines. If you check the code, you see this.

<TraitType>TRAIT_CIVILIZATION_GAUL</TraitType>
<ModifierId>GAUL_MINE_TOURISM</ModifierId>

<ModifierId>GAUL_MINE_TOURISM</ModifierId>
<ModifierType>MODIFIER_PLAYER_ADJUST_PLOT_YIELD</ModifierType>
<SubjectRequirementSetId>PLAYER_HAS_FLIGHT</SubjectRequirementSetId>

<ModifierId>GAUL_MINE_TOURISM</ModifierId>
<Name>ImprovementType</Name>
<Value>IMPROVEMENT_MINE</Value>

<ModifierId>GAUL_MINE_TOURISM</ModifierId>
<Name>ScalingFactor</Name>
<Value>200</Value>

But they used the wrong ModifierType. It should be MODIFIER_PLAYER_CITIES_ADJUST_TOURISM. I corrected and it works properly now.

GaulMines.jpg
 
Brixter said:
Gaul was meant to have double tourism from mines. If you check the code, you see this.

<TraitType>TRAIT_CIVILIZATION_GAUL</TraitType>
<ModifierId>GAUL_MINE_TOURISM</ModifierId>

<ModifierId>GAUL_MINE_TOURISM</ModifierId>
<ModifierType>MODIFIER_PLAYER_ADJUST_PLOT_YIELD</ModifierType>
<SubjectRequirementSetId>PLAYER_HAS_FLIGHT</SubjectRequirementSetId>

<ModifierId>GAUL_MINE_TOURISM</ModifierId>
<Name>ImprovementType</Name>
<Value>IMPROVEMENT_MINE</Value>

<ModifierId>GAUL_MINE_TOURISM</ModifierId>
<Name>ScalingFactor</Name>
<Value>200</Value>

But they used the wrong ModifierType. It should be MODIFIER_PLAYER_CITIES_ADJUST_TOURISM. I corrected and it works properly now.

View attachment 660127
Click to expand...
Can you release it as a mod?
 
Brixter said:
Gaul was meant to have double tourism from mines. If you check the code, you see this.

But they used the wrong ModifierType. It should be MODIFIER_PLAYER_CITIES_ADJUST_TOURISM. I corrected and it works properly now.
Click to expand...
Yeah, that makes sense. Usually all improvements that generate Culture after researching Flight also generate Tourism.
 
Brixter said:
Thanks :) I was working on my tile improvements mod and by chance I saw this code. This particular code stuck out because the arguments are different so there must be sonething wrong.
Click to expand...
Good observation. I wonder if there are more cases like this. Off to the SQL then :lol:
 
I don't think this is a bug.

Gaul still gets tourism from mines from their addition to the Improvement_Tourism table.

And Gaul's ability doesn't state anywhere that mines should get 200% Tourism. Maybe that was the original concept, but I think this is just a vestigial entry in the database that should have been removed.
 
Noble Zarkon said:
I'm thinking of making a "Civ VI Community Patch" mod with identified fixes only.
Click to expand...
I am putting all my fixes into Real Fixes mod. It is on GitHub for others to contribute (now it is a part of a bigger rep, but I can make it a separate rep). There are atm several gameplay fixes plus many technical ones.
 
pokiehl said:
I don't think this is a bug.

Gaul still gets tourism from mines from their addition to the Improvement_Tourism table.

And Gaul's ability doesn't state anywhere that mines should get 200% Tourism. Maybe that was the original concept, but I think this is just a vestigial entry in the database that should have been removed.
Click to expand...
Yeah... but a) scaling factor is 0, so actually they don't produce anything b) Mine is a generic improvement; putting something here would work for all civs, not only Gauls.
Another mess :lol:
I believe the Gallic mines were supposed to give tourism. There's too many left-overs. But apparently they didn't know how to do it properly. Probably same situation as Elizabeth's ability.
They tried modifiers, and it didn't work. They tried table, and maybe it worked but someone noticed that it woudl affect others. again failure. So, it was easier to set scaling to 0 and change description.
If we agree that they were supposed to give Tourism, then the safe way is to use Modifiers.
 
The code is in the game files so clearly there was an intention to give Gaul double mine tourism. Most of the code is in there, it is just missing the correct ModifierType.
 
Infixo said:
Yeah... but a) scaling factor is 0, so actually they don't produce anything b) Mine is a generic improvement; putting something here would work for all civs, not only Gauls.
Another mess :lol:
I believe the Gallic mines were supposed to give tourism. There's too many left-overs. But apparently they didn't know how to do it properly. Probably same situation as Elizabeth's ability.
They tried modifiers, and it didn't work. They tried table, and maybe it worked but someone noticed that it woudl affect others. again failure. So, it was easier to set scaling to 0 and change description.
If we agree that they were supposed to give Tourism, then the safe way is to use Modifiers.
Click to expand...
The scaling factor in the table is 0 but it still gives Tourism like expected. Try it out yourself.

I also don't think the mine getting added to that table for all civs is a bug or unexpected behavior. It tracks with how the game works: improvements that provide Culture will provide Tourism. In most cases that's only Gaul, but obviously with certain abilities other civs can get Tourism with mines. Gaul's ability description doesn't actually reference Tourism at all.

Brixter said:
The code is in the game files so clearly there was an intention to give Gaul double mine tourism. Most of the code is in there, it is just missing the correct ModifierType.
Click to expand...
There's a lot of stuff in the game files that doesn't actually bear out. Genoa as a civ is referenced multiple times. Is it a bug that they're not in the game?

The best way to figure out their intent is to read the ability description. If Gaul's ability text specifically referenced 200% Tourism from mines, then I'd agree with you that it's a bug. I'd also say it's a bug if Gaul didn't get any Tourism from mines. But neither of those things is true.
 
Last edited:
To add to my above post, I seem to remember the entry for Mines in the Improvement_Tourism table was actually patched in after the Gaul release.

All in all, I think Gaul is working as intended here. Don't think there's any bug at all.
 
Last edited:
Since Mines currently give Tourism despite having ScalingFactor = 0, I suspect ScalingFactor is treated as 100 if it is below 100. All other instances of ScalingFactor are greater than or equal to 100.
 
pokiehl said:
To add to my above post, I seem to remember the entry for Mines in the Improvement_Tourism table was actually patched in after the Gaul release.

All in all, I think Gaul is working as intended here. Don't think there's any bug at all.
Click to expand...
I believe the same.

At launch, players were surprised that the Gallic mines did not yield Tourism at Flight. I believe the code found up there was their first try to implement the Culture to Tourism at Flight for Gallic mines specifically.

In the December 2020 Game Update, they wrote "Mines built by Gaul now provide tourism."

So I think they always intended to have Gallic Mines generates Tourism at Flight, but only Gallic Mines. Instead, they put all Mines eligible to yield Tourism at Flight. It achieves almost the same thing, whith very few side-effects (or emergent gameplays). It adds (or does not add):
  • Mines over a Luxury Resources yielding Culture does NOT generate Tourism at Flight (like Amber).
  • Mines over a tile that generates Culture from outside influence generate Tourism:
    • Like a Rainforest tiles with Chichen Itza
    • Like a Tundra tiles with St Basil's Cathedral
    • Like a tile adjacent to a Natural Wonder yielding Culture like Matterhorn...
    • Like 4+ Appeal tiles next to Woods or Wonders when playing as Bull Moose (it seems quite potent...)
    • Like a Luxury resources tiles next to a Château or a Theatre Square when playing as Magnificent (should it be extended to Camp and Quarry?).
    • Like a feature tiles with a Marae when playing as the Maōri
      • There is some side effects. A Maōri's Mine with a Marae yields 2 Tourism: 1 from the Marae and 1 from the Mine.
    • Probably more exceptions that I have forgotten.

Perhaps they really intended the Gallic to have double Tourism because they believed having Mines, Oppidum and spread districts everywhere will screw them for National Parks due to the lowered Appeal and missing space. What is sure for me is that they intended only the Gallic to generate Mines from Tourism. But I disagree: I believe many tiles should be able to generate Tourism, or at least Camp and Quarry so that Catherine de Medici could fully exploit them. Even if I am afraid of Bull Moose's Lumber Mills Tourism attraction.

Those codes, I believe there are leftovers of the team trying to implement the Tourism from Mines for Gaul but didn't remove it. In a sense of "don't clean up to not mix things up"? Or perhaps there are many coders, and the last coder was unaware of the first coder tries?
 
Last edited:
pokiehl said:
All in all, I think Gaul is working as intended here. Don't think there's any bug at all.
Click to expand...
You've just said that despite having ScalingFactor as 0 it actually gets Tourism. And yet the description does not say so :hmm:
Something is off, no matter the angle you look at it...
 
Infixo said:
You've just said that despite having ScalingFactor as 0 it actually gets Tourism. And yet the description does not say so :hmm:
Something is off, no matter the angle you look at it...
Click to expand...
Right, the tourism works fine and it generates the standard tourism based on culture.

This does not need to be specified in the ability because it’s an understood global game mechanic that improvements which provide culture will eventually provide tourism at Flight. It’s also why it’s not surprising or a bug that other civs get tourism if their mines happen to provide culture for whatever reason.

What would be strange is if Gaul inexplicably got double tourism from their mines for no reason or no explanation in the ability.

Nothing strange is going on beyond the fact that they left the vestiges of the old code/concept in the game files. Don’t think too hard ;)
 
so, looking like the game is working as intended, with gallic mines not giving double the normal tourism. that being said, i think they should, that seems like a good and cool and fun thing to give them. so i fully support this being made a standalone mod. i just dont think itd be able to be rightly called a bug fix.

that being said, do we know if this change
Brixter said:
Gaul was meant to have double tourism from mines. If you check the code, you see this.

<TraitType>TRAIT_CIVILIZATION_GAUL</TraitType>
<ModifierId>GAUL_MINE_TOURISM</ModifierId>

<ModifierId>GAUL_MINE_TOURISM</ModifierId>
<ModifierType>MODIFIER_PLAYER_ADJUST_PLOT_YIELD</ModifierType>
<SubjectRequirementSetId>PLAYER_HAS_FLIGHT</SubjectRequirementSetId>

<ModifierId>GAUL_MINE_TOURISM</ModifierId>
<Name>ImprovementType</Name>
<Value>IMPROVEMENT_MINE</Value>

<ModifierId>GAUL_MINE_TOURISM</ModifierId>
<Name>ScalingFactor</Name>
<Value>200</Value>

But they used the wrong ModifierType. It should be MODIFIER_PLAYER_CITIES_ADJUST_TOURISM. I corrected and it works properly now.
Click to expand...
has any effects other than gallic mines now getting double tourism? everyone else's mines remain unchanged?
 
You must log in or register to reply here.

Similar threads

Narvana
I've tried giving Maori's ability to Pericles, but it just won't have an effect
Replies
1
Views
859
TLC
T
SlySlySly
Leader Ability and Adding New Leader to Existing Civ
Replies
3
Views
5K
SlySlySly
SlySlySly
Back
Top Bottom