Reworked ethic work belief does not work after repairing a Lavra?!
(If you are the mod author 태연 on Steam)
INSERT INTO Types
(Type, Kind)
VALUES ('DYNMOD_WORK_ETHIC', 'KIND_MODIFIER');
INSERT INTO DynamicModifiers
(ModifierType, CollectionType, EffectType)
VALUES ('DYNMOD_WORK_ETHIC', 'COLLECTION_CITY_DISTRICTS', 'EFFECT_ADJUST_DISTRICT_YIELD_BASED_ON_ADJACENCY_BONUS');
UPDATE Modifiers SET ModifierType = 'DYNMOD_WORK_ETHIC', SubjectRequirementSetId = 'BWE_OBJECT_IS_HOLY_SITE'
WHERE ModifierId = 'WORK_ETHIC_ADJACENCY_PRODUCTION_MODIFIER';
INSERT INTO RequirementSets
(RequirementSetId, RequirementSetType)
VALUES ('BWE_OBJECT_IS_HOLY_SITE', 'REQUIREMENTSET_TEST_ALL');
INSERT INTO RequirementSetRequirements
(RequirementSetId, RequirementId)
VALUES ('BWE_OBJECT_IS_HOLY_SITE', 'REQUIRES_PLOT_HAS_HOLY_SITE');
Reworked ethic work belief does not work after repairing a Lavra?!
The mod basically changes the CollectionType from "COLLECTION_OWNER" to "COLLECTION_CITY_DISTRICTS" and the RequirementType from "REQUIREMENT_DISTRICT_TYPE_MATCHES" to "REQUIREMENT_PLOT_DISTRICT_TYPE_MATCHES".
It seems to work just fine and corrects the problem from my testing. Well done @Namhyeok !
I think you could also simplify the mod to the following and achieve the same result:
Code:INSERT INTO Types (Type, Kind) VALUES ('DYNMOD_WORK_ETHIC', 'KIND_MODIFIER'); INSERT INTO DynamicModifiers (ModifierType, CollectionType, EffectType) VALUES ('DYNMOD_WORK_ETHIC', 'COLLECTION_CITY_DISTRICTS', 'EFFECT_ADJUST_DISTRICT_YIELD_BASED_ON_ADJACENCY_BONUS'); UPDATE Modifiers SET ModifierType = 'DYNMOD_WORK_ETHIC', SubjectRequirementSetId = 'BWE_OBJECT_IS_HOLY_SITE' WHERE ModifierId = 'WORK_ETHIC_ADJACENCY_PRODUCTION_MODIFIER'; INSERT INTO RequirementSets (RequirementSetId, RequirementSetType) VALUES ('BWE_OBJECT_IS_HOLY_SITE', 'REQUIREMENTSET_TEST_ALL'); INSERT INTO RequirementSetRequirements (RequirementSetId, RequirementId) VALUES ('BWE_OBJECT_IS_HOLY_SITE', 'REQUIRES_PLOT_HAS_HOLY_SITE');
There's no need to account for UDs anymore (e.g. Lavra) as the game has done that automatically for some time now.
It’s likely they are trying to fix what is breaking it under the hood. Only they can fix what causes certain modifiers to break in district pillage.Wait, the fix is just swapping like a few .xml tags around? How is this taking Firaxis multiple patch cycles to deal with?
Just like the forest fire bug, someone put in a patch that was just a few lines of code and Firaxis still hasn't gotten around to it yet. And remember how long it took to fix the stealing Great Works bug.Wait, the fix is just swapping like a few .xml tags around? How is this taking Firaxis multiple patch cycles to deal with?
Wasn't this only a problem when continuing a save from a previous game version? I seem to remember Carl mentioning it.
It is. But some people are playing long games so it is still an issue...
That's always been the case, though, going back to 2016. Updates will always have the possibility of breaking save games. It's going to be worse now, of course, with the monthly updates. I wouldn't even consider this a bug, though, as it's a problem with deprecated code. In any event, making a mod with BBS's modified ProductionPanel.lua should be pretty straightforward. Btw, does legacy access not work anymore?
Maybe civ fix the bug themselves? I haven't used work ethic in my game recently.
