Keldath addons

[jollyroger3]

I've just had a CTD while playing patch 2

I captured one American city, without city walls, ordered my units to heal in it. Meanwhile I got Great General and assigned it to one Dark Legion (Polish Swordsman), gave promotions and moved it... End of turn caused CTD

I'll try to find out in the Save game what caused that CTD, I'll post this Save game here in 10 minutes...

 

[keldath]

great jolly - ill need it.


***edit***

i want you try somthing,

try to play the game without the file
promotioninfo.xml

its located under
assets\xml\unit

 

[jollyroger3]

I'm not sure if it wasn't American Battering Ram Attacking my city, what caused CTD - got to check if there were City Walls in my probably attacked city...

This mod is starting really slowly But in a week or so I'll get a new 64 bit Athlon 3000+, much more RAM and much better graphic card, so I'll be able to play more in the same time

Loading the mod right now

 

[keldath]

phh... lucky you....

well try the game with my suggestion -if its a promortion problem - this will answer if the cause is because of the new promotions

 

[jollyroger3]

Yes, there were City Walls in my maybe Attacked City. But the CTD occurs right after giving promotions.

Here are Savegames:

1. View attachment 137893

This is about 1 turn before CTD (and before promotions)

2. View attachment 137894

And this is exactly one click before CTD.

If I remove the file you say - will I be able to load this game, or will I have to start from the very beginning ?

 

[keldath]

try both - i think its better if you try a new game.

i try your saves.


you know......
you have no idea how i appreciate your help

 

[jollyroger3]

I'll try loading this game without that file. If it fails I'll try to load it with that file but to avoid that promotions in this turn

PS. And you don't know how much I love your mod

 

[zulu9812]

Zulu it appears to be something to do with the city attack promotion , units with city attack promotopn attacking walled cities once the Great wall is built CTD the game.

Could it be something to do with CvGame.cpp and CvUnit.cpp? I got warning messages on these 2 files whilst compiling the DLL ('unreferenced local variable' on 'pLoopUnit' and 'iStrengthFactor' respectively) and I'm pretty sure it's nothing that I did (I didn't even touch CvGame.cpp, for example).

 

[jollyroger3]

it appears to be something to do with the city attack promotion , units with city attack promotopn attacking walled cities once the Great wall is built CTD the game

No, it's not that particular promotion... In my game attached above I attacked city walled city many times with units with city attack promotion and there was no CTD. CTD occured when I captured the city and/or gave promotions to my units from Great General in that captured and rebelling city.

 

[keldath]

zulu, tis line that you recived - is due to one of the mods,

i think dales,

he deletes the 2 lines and do a different code there,

its the same in the vanilla,
im certain its not a dll problem,
the sdk merging i did with extreme care.

i compared each mod i wanted to add to the "vanilla" un chaged file (either from warlords or civ4 vanilla) and this is how i new what exact line to merge and where.

im possitive thats its because of the xml.

ive created different sdk files from dales1.02 and 1.03 - both cases the ctd was still there. also tryed to play without the dll - still ctd.

 

[jollyroger3]

Unfortunately playing without Promotions xml file I got a CTD while attacking city walled city with Battering Ram (strength I, city attack I, city bombarding I) exactly in the moment of attack.

I'm going sleep now

 

[keldath]

good night buddy, thanks for the help - ill see to the bug i promiss!!!!!!!


***one more thing***

tommorow i begin create a mod for amra modpack for 5uu+dale!!!!

he gave me the sdk!!!!!!

woooohhhhooooo

now we could all enjoy a stable working mod for warlords with my additions with out ctd.

im gonna completley rework the units and perhaps will incorporate some of sevo's civs.

 

[zulu9812]

I've successfully added TheLopez's Airforce mod and set the number of max players in a game to 24. Here is the code:

http://forums.civfanatics.com/uploads/11460/SDK_code_for_KelGir_Warlords_AirforceMod_24civs.zip

 

[rockinroger]

hey gang, i hate shopping for cars. for my son with my ex wife, aurgh,lol. welcome zulu9812. thanks for your efforts mr. genie. keldath you continue to work tremendously hard. looking forward to your merge with ammra. ive been playing dales version 1.03 for warlords. seems fairly stable. unfortunately after playing your kelgir mod, then other mods seem rather drab. lets hope we can get a warlords mod with dales combat in it, and get it stable. i realize my only contribution is toward playing a mod. so if that helps, then i am at your service.

 

[Ket]

Kel, when compiling do not compile with warnings or shall I say dont release the .dll when there are warnings. It's usualy a "Bad Sign"

To isolate it to the .dll cant you just remove all the XML so it loads the default stuff throw it on autoplay and if it still crash's its the DLL

 

[keldath]

zulu, thanks! ill use it!

thanks rockinroegr for the help - work shall begin momenterly!

ket, there is always one worning that i get:
szString += L"{}~\\ְֱֲֳִֵֶַָֹֺֻּֽ־ֿ׀ׁׂ׃װױײ״Ÿאבגדהוזחטיךכלםמןנסעףפץצקרשת‎‏¿¡«»°ŠŒŽšœž™©®€£¢”‘“…’";


and i read about it in the forum, that i need to delete it,

and i had no problems at all in the vanilla mod.

also, i tested the game without the dll (i think) and it was ok.

the warnings that was mentioned above - was given because of a merge of another mod that didnt include those lines.

 

[Ket]

Im seeing hebrew characters show up when you copy that. I dont know if its meant to do that.

What mod has that text in it?

 

[serax_99]

At year 1522 I built a Tank and my City Guard Upgraded it to an Albanian Tank, and now my game CTD when I end the turn. I can't upload the file due to it being 41kb too big. Any helpy would be appreciated.

 

[Axil]

Also available to beta test / bug fix any mod anything you want to test keldath. I know a little XML and Python to be able to spot any obvious errors but I'm more likely to be more use as a play tester.

I may have a look at the texture sizes on the new units later as my current Vanilla Civ4 game is unable to run in high detail as Civ is saying it can't allocate enough graphics Mem ( and I have a 1900XT 512 Mb ) !!!

 

[mrgenie]

im possitive thats its because of the xml.

ive created different sdk files from dales1.02 and 1.03 - both cases the ctd was still there. also tryed to play without the dll - still ctd.

I'm positive about that it has to do with the data of the xml keldath, but not that it is inside the xml...it must be something how the xml is handled...i talked with s4evo about it...he said 1single problem in a xml doesn't need to give you an error but could make the WHOLE XML give corrupted data to the game!

this MIGHT BE the case since i noticed, when im attacking in open field enemy units, i have sometimes 90% chance of winning, but my units go down to 5% power left!! and this is not once, but many times...so...somehow, the values which the combat routines is getting from the xml, to determine the combat probabilities, and the actual combat ..is NOT the same!!
if it's an error IN the XML files...i dont know..but fact is, between the date inside the XML and the actualy combat routine is wrong...when i look at strenght and the combat probability(this is written in some python files) this is correct if you do the maths! 12versus 6 gives you 100%winning chance..though fighting this combat many times lead your units to go down RED completely!! not oncer, like i said, i noticed this many times to happen...